diff --git a/.gitignore b/.gitignore
index 64ad90a0775214cd762d423e2f24ed70e94dcd52..3fac94e23995b2ce0d7727525f2014868de41002 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,6 +22,8 @@ SCIPOST_JOURNALS
UPLOADS
docs/_build
+local_files
+static/
local_files/
static/
diff --git a/README.md b/README.md
index 85b4385bf5438c74d0e747b94a5b02999718a2c0..1ebdbdcb35812fa89ac24d46b31d27a810349794 100644
--- a/README.md
+++ b/README.md
@@ -118,10 +118,10 @@ In order to use the admin site, you'll need a superuser.
```
### Create groups and permissions
-Groups and their respective permissions are created using the management command. Since users depend on the *Contributor* object to work properly, setup the first (admin) user using the `-u` and `-a` arguments.
+Groups and their respective permissions are created using the management command.
```shell
-(scipostenv) $ ./manage.py add_groups_and_permissions -u=<username> -a
+(scipostenv) $ ./manage.py add_groups_and_permissions
```
### Run development server
diff --git a/SciPost_v1/settings.py b/SciPost_v1/settings.py
index 4e6a5fc96a19b7b16c793cfa9f3ea3948db188d6..c8b6bf5e07241682fcabb72a6a9356aeaee0f41c 100644
--- a/SciPost_v1/settings.py
+++ b/SciPost_v1/settings.py
@@ -193,7 +193,7 @@ STATICFILES_DIRS = (
WEBPACK_LOADER = {
'DEFAULT': {
'CACHE': not DEBUG,
- 'BUNDLE_DIR_NAME': 'static/bundles/',
+ 'BUNDLE_DIR_NAME': host_settings["STATIC_ROOT"] + 'bundles/',
'STATS_FILE': os.path.join(BASE_DIR, 'webpack-stats.json'),
'POLL_INTERVAL': 0.1,
'TIMEOUT': None,
diff --git a/commentaries/migrations/0014_auto_20170201_1243.py b/commentaries/migrations/0014_auto_20170201_1243.py
new file mode 100644
index 0000000000000000000000000000000000000000..060845cb8a82fa26f888bdc2cbadbf30b0541526
--- /dev/null
+++ b/commentaries/migrations/0014_auto_20170201_1243.py
@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-02-01 11:43
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.utils.timezone
+import scipost.db.fields
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('commentaries', '0013_auto_20161213_2328'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='commentary',
+ name='created',
+ field=models.DateTimeField(default=django.utils.timezone.now),
+ ),
+ migrations.AlterField(
+ model_name='commentary',
+ name='latest_activity',
+ field=scipost.db.fields.AutoDateTimeField(blank=True, default=django.utils.timezone.now, editable=False),
+ ),
+ ]
diff --git a/comments/migrations/0006_auto_20170201_1243.py b/comments/migrations/0006_auto_20170201_1243.py
new file mode 100644
index 0000000000000000000000000000000000000000..f13cde452317daf5ba4f231ef446d5d8311727c6
--- /dev/null
+++ b/comments/migrations/0006_auto_20170201_1243.py
@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-02-01 11:43
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.utils.timezone
+import scipost.db.fields
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('comments', '0005_auto_20170131_2141'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='comment',
+ name='created',
+ field=models.DateTimeField(default=django.utils.timezone.now),
+ ),
+ migrations.AlterField(
+ model_name='comment',
+ name='latest_activity',
+ field=scipost.db.fields.AutoDateTimeField(blank=True, default=django.utils.timezone.now, editable=False),
+ ),
+ ]
diff --git a/journals/forms.py b/journals/forms.py
index 8bbb70cc12ee333901d3525b0cb25849001b83dd..6df90b1adad9b4a9980ef1160749142dcc5be20e 100644
--- a/journals/forms.py
+++ b/journals/forms.py
@@ -1,14 +1,10 @@
from django import forms
from django.utils import timezone
-from .models import SCIPOST_JOURNALS
from .models import UnregisteredAuthor, Issue, Publication
from submissions.models import Submission
-from crispy_forms.helper import FormHelper
-from crispy_forms.layout import Layout, Div, Field, HTML, Submit
-
class InitiatePublicationForm(forms.Form):
accepted_submission = forms.ModelChoiceField(
@@ -25,65 +21,13 @@ class InitiatePublicationForm(forms.Form):
self.fields['acceptance_date'].widget.attrs.update(
{'placeholder': 'YYYY-MM-DD'})
-# class InitiatePublicationForm(forms.ModelForm):
-# class Meta:
-# model = Publication
-# fields = ['accepted_submission',
-# #'in_journal', 'volume', 'issue',
-# 'in_issue', 'paper_nr',
-# 'pdf_file',
-# 'submission_date', 'acceptance_date',
-# ]
-# # accepted_submission = forms.ModelChoiceField(
-# # queryset=Submission.objects.filter(status='accepted'))
-# # in_journal = forms.ChoiceField(choices=SCIPOST_JOURNALS,)
-# # volume = forms.IntegerField()
-# # issue = forms.IntegerField()
-
-# def __init__(self, *args, **kwargs):
-# super(InitiatePublicationForm, self).__init__(*args, **kwargs)
-# self.fields['accepted_submission'] = forms.ModelChoiceField(
-# queryset=Submission.objects.filter(status='accepted'))
-# self.fields['accepted_submission'].label=''
-# #self.fields['in_journal'].label=''
-# #self.fields['journal'].label=''
-# #self.fields['volume'].label=''
-# #self.fields['issue'].label=''
-# self.fields['in_issue'].label=''
-# self.fields['paper_nr'].label=''
-# self.fields['acceptance_date'].label=''
-# self.fields['submission_date'].label=''
-# self.helper = FormHelper()
-# self.helper.layout = Layout(
-# Div(HTML('<h3>Which Submission is ready for publishing?</h3>'),
-# Field('accepted_submission')),
-# # Div(HTML('<h3>In which Journal?</h3>'),
-# # #Field('in_journal')),
-# # Field('journal')),
-# # Div(HTML('<h3>Which Volume?</h3>'),
-# # Field('volume')),
-# # Div(HTML('<h3>Which issue?</h3>'),
-# # Field('issue')),
-# Div(HTML('<h3>Which Journal/Volume/Issue?</h3>'),
-# Field('in_issue')),
-# Div(HTML('<h3>Which paper number?</h3>'),
-# Field('paper_nr')),
-# Div(HTML('<h3>pdf file (post-proof stage):</h3>'),
-# Field('pdf_file')),
-# Div(HTML('<h3>When was the paper originally submitted?</h3>'),
-# Field('submission_date')),
-# Div(HTML('<h3>When was the paper accepted?</h3>'),
-# Field('acceptance_date')),
-# Submit('submit', 'Initiate publication'),
-# )
-
class ValidatePublicationForm(forms.ModelForm):
class Meta:
model = Publication
exclude = ['authors', 'authors_claims', 'authors_false_claims',
'metadata', 'metadata_xml',
- 'latest_activity',]
+ 'latest_activity', ]
class UnregisteredAuthorForm(forms.ModelForm):
diff --git a/journals/migrations/0007_auto_20170210_1521.py b/journals/migrations/0007_auto_20170210_1521.py
new file mode 100644
index 0000000000000000000000000000000000000000..62880f9f0b7a35ad9c95157f1bba5a9a60235609
--- /dev/null
+++ b/journals/migrations/0007_auto_20170210_1521.py
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-02-10 14:21
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('journals', '0006_publication_citedby'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='issue',
+ name='number',
+ field=models.PositiveSmallIntegerField(),
+ ),
+ migrations.AlterUniqueTogether(
+ name='issue',
+ unique_together=set([('number', 'in_volume')]),
+ ),
+ ]
diff --git a/journals/migrations/0008_auto_20170210_1524.py b/journals/migrations/0008_auto_20170210_1524.py
new file mode 100644
index 0000000000000000000000000000000000000000..6d4488fed13a119c82b28f24ab39ab9885784afb
--- /dev/null
+++ b/journals/migrations/0008_auto_20170210_1524.py
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-02-10 14:24
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('journals', '0007_auto_20170210_1521'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='volume',
+ name='number',
+ field=models.PositiveSmallIntegerField(),
+ ),
+ migrations.AlterUniqueTogether(
+ name='volume',
+ unique_together=set([('number', 'in_journal')]),
+ ),
+ ]
diff --git a/journals/models.py b/journals/models.py
index f5b65028034176f1c7e97d1ee01d00958df8defc..15f46621ac052c3e44e4d5133d226bea03854c7c 100644
--- a/journals/models.py
+++ b/journals/models.py
@@ -1,10 +1,10 @@
-from django.contrib.postgres.fields import ArrayField, JSONField
+from django.contrib.postgres.fields import JSONField
from django.db import models
from django.template import Template, Context
from django.utils import timezone
-from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS, subject_areas_dict
-from scipost.models import ChoiceArrayField, Contributor, TITLE_CHOICES
+from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS
+from scipost.models import ChoiceArrayField, Contributor
class UnregisteredAuthor(models.Model):
@@ -30,6 +30,7 @@ class JournalNameError(Exception):
def __str__(self):
return self.name
+
def journal_name_abbrev_citation(journal_name):
if journal_name == 'SciPost Physics':
return 'SciPost Phys.'
@@ -40,6 +41,7 @@ def journal_name_abbrev_citation(journal_name):
else:
raise JournalNameError(journal_name)
+
def journal_name_abbrev_doi(journal_name):
if journal_name == 'SciPost Physics':
return 'SciPostPhys'
@@ -50,12 +52,15 @@ def journal_name_abbrev_doi(journal_name):
else:
raise JournalNameError(journal_name)
+
class PaperNumberError(Exception):
def __init__(self, nr):
self.nr = nr
+
def __str__(self):
return self.nr
+
def paper_nr_string(nr):
if nr < 10:
return '00' + str(nr)
@@ -66,13 +71,16 @@ def paper_nr_string(nr):
else:
raise PaperNumberError(nr)
+
class PaperNumberingError(Exception):
def __init__(self, nr):
self.nr = nr
+
def __str__(self):
return self.nr
-SCIPOST_JOURNALS_SUBMIT = ( # Same as SCIPOST_JOURNALS, but SP Select deactivated
+
+SCIPOST_JOURNALS_SUBMIT = ( # Same as SCIPOST_JOURNALS, but SP Select deactivated
('SciPost Physics', 'SciPost Physics'),
('SciPost Physics Lecture Notes', 'SciPost Physics Lecture Notes'),
)
@@ -104,7 +112,6 @@ SCIPOST_JOURNALS_SPECIALIZATIONS = (
journals_spec_dict = dict(SCIPOST_JOURNALS_SPECIALIZATIONS)
-
class Journal(models.Model):
name = models.CharField(max_length=100, choices=SCIPOST_JOURNALS,
unique=True)
@@ -117,28 +124,32 @@ class Journal(models.Model):
class Volume(models.Model):
in_journal = models.ForeignKey(Journal, on_delete=models.CASCADE)
- number = models.PositiveSmallIntegerField(unique=True)
+ number = models.PositiveSmallIntegerField()
start_date = models.DateField(default=timezone.now)
until_date = models.DateField(default=timezone.now)
doi_string = models.CharField(max_length=200, blank=True, null=True)
+ class Meta:
+ unique_together = ('number', 'in_journal')
+
def __str__(self):
return str(self.in_journal) + ' Vol. ' + str(self.number)
class Issue(models.Model):
in_volume = models.ForeignKey(Volume, on_delete=models.CASCADE)
- number = models.PositiveSmallIntegerField(unique=True)
+ number = models.PositiveSmallIntegerField()
start_date = models.DateField(default=timezone.now)
until_date = models.DateField(default=timezone.now)
doi_string = models.CharField(max_length=200, blank=True, null=True)
# absolute path on filesystem: (JOURNALS_DIR)/journal/vol/issue/
path = models.CharField(max_length=200)
+ class Meta:
+ unique_together = ('number', 'in_volume')
+
def __str__(self):
text = str(self.in_volume) + ' issue ' + str(self.number)
- #if self.until_date >= timezone.now().date():
- # text += ' (in progress)'
if self.start_date.month == self.until_date.month:
text += ' (' + self.until_date.strftime('%B') + ' ' + self.until_date.strftime('%Y') + ')'
else:
@@ -146,7 +157,7 @@ class Issue(models.Model):
' ' + self.until_date.strftime('%Y') + ')')
return text
- def period (self):
+ def period(self):
text = 'up to {{ until_month }} {{ year }}'
template = Template(text)
context = Context({'until_month': self.start_date.strftime('%B'),
@@ -168,23 +179,23 @@ class Publication(models.Model):
title = models.CharField(max_length=300)
author_list = models.CharField(max_length=1000, verbose_name="author list")
# Authors which have been mapped to contributors:
- authors = models.ManyToManyField (Contributor, blank=True, related_name='authors_pub')
- authors_unregistered = models.ManyToManyField (UnregisteredAuthor, blank=True,
- related_name='authors_unregistered')
- first_author = models.ForeignKey (Contributor, blank=True, null=True, on_delete=models.CASCADE)
- first_author_unregistered = models.ForeignKey (UnregisteredAuthor, blank=True, null=True,
- on_delete=models.CASCADE,
- related_name='first_author_unregistered')
- authors_claims = models.ManyToManyField (Contributor, blank=True,
- related_name='authors_pub_claims')
- authors_false_claims = models.ManyToManyField (Contributor, blank=True,
- related_name='authors_pub_false_claims')
+ authors = models.ManyToManyField(Contributor, blank=True, related_name='authors_pub')
+ authors_unregistered = models.ManyToManyField(UnregisteredAuthor, blank=True,
+ related_name='authors_unregistered')
+ first_author = models.ForeignKey(Contributor, blank=True, null=True, on_delete=models.CASCADE)
+ first_author_unregistered = models.ForeignKey(UnregisteredAuthor, blank=True, null=True,
+ on_delete=models.CASCADE,
+ related_name='first_author_unregistered')
+ authors_claims = models.ManyToManyField(Contributor, blank=True,
+ related_name='authors_pub_claims')
+ authors_false_claims = models.ManyToManyField(Contributor, blank=True,
+ related_name='authors_pub_false_claims')
abstract = models.TextField()
pdf_file = models.FileField(upload_to='UPLOADS/PUBLICATIONS/%Y/%m/', max_length=200)
metadata = JSONField(default={}, blank=True, null=True)
- metadata_xml = models.TextField(blank=True, null=True) # for Crossref deposit
+ metadata_xml = models.TextField(blank=True, null=True) # for Crossref deposit
BiBTeX_entry = models.TextField(blank=True, null=True)
- doi_label = models.CharField(max_length=200, blank=True, null=True) # Used for file name
+ doi_label = models.CharField(max_length=200, blank=True, null=True) # Used for file name
doi_string = models.CharField(max_length=200, blank=True, null=True)
submission_date = models.DateField(verbose_name='submission date')
acceptance_date = models.DateField(verbose_name='acceptance date')
@@ -192,22 +203,20 @@ class Publication(models.Model):
latest_activity = models.DateTimeField(default=timezone.now)
citedby = JSONField(default={}, blank=True, null=True)
- def __str__ (self):
+ def __str__(self):
header = (self.citation() + ', '
+ self.title[:30] + ' by ' + self.author_list[:30]
+ ', published ' + self.publication_date.strftime('%Y-%m-%d'))
return header
- def citation (self):
+ def citation(self):
return (journal_name_abbrev_citation(self.in_issue.in_volume.in_journal.name)
+ ' ' + str(self.in_issue.in_volume.number)
- #+ '(' + str(self.in_issue.number) + ')'
+ ', ' + paper_nr_string(self.paper_nr)
- + ' (' + self.publication_date.strftime('%Y') + ')' )
+ + ' (' + self.publication_date.strftime('%Y') + ')')
- def citation_for_web (self):
+ def citation_for_web(self):
citation = ('{{ abbrev }} <strong>{{ volume_nr }}</strong>'
- #'({{ issue_nr }})'
', {{ paper_nr }} ({{ year }})')
template = Template(citation)
context = Context(
@@ -215,13 +224,12 @@ class Publication(models.Model):
'volume_nr': str(self.in_issue.in_volume.number),
'issue_nr': str(self.in_issue.number),
'paper_nr': paper_nr_string(self.paper_nr),
- 'year': self.publication_date.strftime('%Y'),})
+ 'year': self.publication_date.strftime('%Y'), })
return template.render(context)
- def citation_for_web_linked (self):
+ def citation_for_web_linked(self):
citation = ('<a href="{% url \'scipost:publication_detail\' doi_string=doi_string %}">'
'{{ abbrev }} <strong>{{ volume_nr }}</strong>'
- #'({{ issue_nr }})'
', {{ paper_nr }} ({{ year }})')
template = Template(citation)
context = Context(
@@ -230,20 +238,10 @@ class Publication(models.Model):
'volume_nr': str(self.in_issue.in_volume.number),
'issue_nr': str(self.in_issue.number),
'paper_nr': paper_nr_string(self.paper_nr),
- 'year': self.publication_date.strftime('%Y'),})
+ 'year': self.publication_date.strftime('%Y'), })
return template.render(context)
-
- # def doi_label_as_str(self):
- # label = (
- # journal_name_abbrev_doi(self.in_issue.in_volume.in_journal.name)
- # + '.' + str(self.in_issue.in_volume.number)
- # + '.' + str(self.in_issue.number)
- # + '.' + paper_nr_string(self.paper_nr) )
- # return label
-
-
- def header_as_li (self):
+ def header_as_li(self):
header = ('<li class="publicationHeader">'
'<p class="publicationTitle"><a href="{% url \'scipost:publication_detail\' doi_string=doi_string %}">{{ title }}</a></p>'
'<p class="publicationAuthors">{{ author_list }}</p>'
@@ -256,17 +254,17 @@ class Publication(models.Model):
'</ul>'
'</li>')
template = Template(header)
- context = Context({'doi_string': self.doi_string,
- 'title': self.title,
- 'author_list': self.author_list,
- 'citation': self.citation,
- 'pub_date': self.publication_date.strftime('%d %B %Y'),
- 'abstract': self.abstract,
- })
+ context = Context({
+ 'doi_string': self.doi_string,
+ 'title': self.title,
+ 'author_list': self.author_list,
+ 'citation': self.citation,
+ 'pub_date': self.publication_date.strftime('%d %B %Y'),
+ 'abstract': self.abstract,
+ })
return template.render(context)
-
- def details (self):
+ def details(self):
"""
This method is called from the publication_detail template.
It provides all the details for a publication.
@@ -292,15 +290,16 @@ class Publication(models.Model):
'<h2>BiBTeX</h2><p>{{ BiBTeX|linebreaks }}</p></div></div>'
)
template = Template(pub_details)
- context = Context({'title': self.title,
- 'author_list': self.author_list,
- 'citation': self.citation_for_web,
- 'pub_date': self.publication_date.strftime('%d %B %Y'),
- 'abstract': self.abstract,
- 'doi_string': self.doi_string,
- 'BiBTeX': self.BiBTeX_entry,
- 'arxiv_identifier_w_vn_nr': self.accepted_submission.arxiv_identifier_w_vn_nr
- })
+ context = Context({
+ 'title': self.title,
+ 'author_list': self.author_list,
+ 'citation': self.citation_for_web,
+ 'pub_date': self.publication_date.strftime('%d %B %Y'),
+ 'abstract': self.abstract,
+ 'doi_string': self.doi_string,
+ 'BiBTeX': self.BiBTeX_entry,
+ 'arxiv_identifier_w_vn_nr': self.accepted_submission.arxiv_identifier_w_vn_nr
+ })
return template.render(context)
def citations_as_ul(self):
@@ -314,11 +313,13 @@ class Publication(models.Model):
if cit['multiauthors']:
output += ' <em>et al.</em>'
output += (', <em>{{ title_' + str(nr) + ' }}</em>, <br/>'
- '{{ journal_abbrev_' + str(nr) + ' }} '
- '<strong>{{ volume_' + str(nr) + ' }}</strong>, ')
+ '{{ journal_abbrev_' + str(nr) + ' }}')
context['title_' + str(nr)] = cit['article_title']
context['journal_abbrev_' + str(nr)] = cit['journal_abbreviation']
- context['volume_' + str(nr)] = cit['volume']
+ if cit['volume']:
+ context['volume_' + str(nr)] = cit['volume']
+ output += ' <strong>{{ volume_' + str(nr) + ' }}</strong>'
+ output += ', '
if cit['first_page']:
output += '{{ first_page_' + str(nr) + ' }}'
context['first_page_' + str(nr)] = cit['first_page']
@@ -350,5 +351,5 @@ class Deposit(models.Model):
deposition_date = models.DateTimeField(default=timezone.now)
def __str__(self):
- return (deposition_date.strftime('%Y-%m-%D') +
- ' for ' + publication.doi_string)
+ return (self.deposition_date.strftime('%Y-%m-%D') +
+ ' for ' + self.publication.doi_string)
diff --git a/journals/templates/journals/journals_terms_and_conditions.html b/journals/templates/journals/journals_terms_and_conditions.html
index 83e6074c226fb6ad5807706ed5b5e25935c59037..b6b316c7d3a75c9f3dc8e316613d172cf111809d 100644
--- a/journals/templates/journals/journals_terms_and_conditions.html
+++ b/journals/templates/journals/journals_terms_and_conditions.html
@@ -19,7 +19,8 @@
<br/>
<hr class="hr12"/>
<h2>General</h2>
- SciPost expects the following from submitters:
+
+ <h3>SciPost expects the following from submitters:</h3>
<ul>
<li>The manuscript which is submitted for publication has not been published before except in
the form of an abstract or electronic preprint or other similar formats which have not undergone
@@ -58,9 +59,15 @@
respect to the material contained herein. Any opinions expressed in SciPost journals are
the views of the authors and are not the views of SciPost.</li>
</ul>
+ <br/>
+ <hr class="hr12"/>
+
+ <h2>Open Access policy</h2>
+ <p>All SciPost Journals are Open Access which means that all content is freely available without charge to the user or his/her institution. Users are allowed to read, download, copy, distribute, print, search, or link to the full texts of the articles, or use them for any other lawful purpose, without asking prior permission from the publisher or the author. This is in accordance with the BOAI definition of Open Access.</p>
<br/>
<hr class="hr12"/>
+
<h2 id="license_and_copyright_agreement">License and copyright agreement</h2>
<p>The following license and copyright agreement is valid for any article published in any
SciPost journal and web portal.</p>
diff --git a/journals/utils.py b/journals/utils.py
index 0e5845e8d4a2f99b380dde570ef96df0e8886e20..71d5cae1cd91cb6373334c5fd1d76b607bdb32bf 100644
--- a/journals/utils.py
+++ b/journals/utils.py
@@ -2,6 +2,7 @@ from django.core.mail import EmailMessage
from scipost.models import title_dict
+
class JournalUtils(object):
@classmethod
@@ -9,7 +10,6 @@ class JournalUtils(object):
for var_name in dict:
setattr(cls, var_name, dict[var_name])
-
@classmethod
def send_authors_paper_published_email(cls):
""" Requires loading 'publication' attribute. """
@@ -38,7 +38,6 @@ class JournalUtils(object):
reply_to=['admin@scipost.org'])
emailmessage.send(fail_silently=False)
-
@classmethod
def generate_metadata_xml_file(cls):
""" Requires loading 'publication' attribute. """
diff --git a/journals/views.py b/journals/views.py
index e3ba969601240c8255c1caa91a267b871f3e1eb1..14322088039fcc6502f455166641eb71196079eb 100644
--- a/journals/views.py
+++ b/journals/views.py
@@ -1,4 +1,3 @@
-import datetime
import hashlib
import os
import random
@@ -7,72 +6,35 @@ import string
import xml.etree.ElementTree as ET
from django.conf import settings
-#from django.core import serializers
from django.utils import timezone
from django.shortcuts import get_object_or_404, render, redirect
-from django.contrib.auth import authenticate, login, logout
-from django.contrib.auth.models import User
from django.core.files import File
-from django.core.mail import EmailMessage
from django.core.urlresolvers import reverse
from django.db import transaction
-from django.http import HttpResponse, HttpResponseRedirect
-from django.views.decorators.csrf import csrf_protect
-from django.db.models import Avg
+from django.http import HttpResponse
-from .models import *
-from .forms import *
+from .models import Issue, Publication, PaperNumberingError,\
+ journal_name_abbrev_doi, paper_nr_string, journal_name_abbrev_citation,\
+ UnregisteredAuthor
+from .forms import FundingInfoForm, InitiatePublicationForm, ValidatePublicationForm,\
+ UnregisteredAuthorForm, CreateMetadataXMLForm, CitationListBibitemsForm
+from .utils import JournalUtils
-from journals.utils import JournalUtils
-
-from submissions.models import SUBMISSION_STATUS_PUBLICLY_UNLISTED
from submissions.models import Submission
+from scipost.models import Contributor
from guardian.decorators import permission_required
-from guardian.decorators import permission_required_or_403
-from guardian.shortcuts import assign_perm
-
-
-# from requests.adapters import HTTPAdapter
-# from requests.packages.urllib3.poolmanager import PoolManager
-# import ssl
-
-# class MyAdapter(HTTPAdapter):
-# def init_poolmanager(self, connections, maxsize, block=False):
-# self.poolmanager = PoolManager(num_pools=connections,
-# maxsize=maxsize,
-# block=block,
-# ssl_version=ssl.PROTOCOL_TLSv1)
############
# Journals
############
-
-# Utilities
-
-
-# @permission_required('scipost.can_publish_accepted_submission', return_403=True)
-# @transaction.atomic
-# def open_new_issue(request):
-# """
-# For a Journal/Volume, creates a new issue.
-# """
-
-# settings.JOURNALS_DIR
-# + journal_name_abbrev_doi(publication.in_issue.in_volume.in_journal.name)
-# + '/' + str(publication.in_issue.in_volume.number)
-# + '/' + str(publication.in_issue.number)
-
-
def journals(request):
return render(request, 'journals/journals.html')
def scipost_physics(request):
- #issues = Issue.objects.filter(
- # in_volume__in_journal__name='SciPost Physics').order_by('-until_date')
current_issue = Issue.objects.filter(
in_volume__in_journal__name='SciPost Physics',
start_date__lte=timezone.now(),
@@ -80,23 +42,9 @@ def scipost_physics(request):
latest_issue = Issue.objects.filter(
in_volume__in_journal__name='SciPost Physics',
until_date__lte=timezone.now()).order_by('-until_date').first()
- #recent_papers = Publication.objects.filter(
- # #in_issue=latest_issue).order_by('paper_nr')
- # in_issue__in_volume__in_journal__name='SciPost Physics').order_by('-publication_date')[:20]
- #accepted_SP_submissions = Submission.objects.filter(
- # submitted_to_journal='SciPost Physics', status='accepted'
- #).order_by('-latest_activity')
- #current_SP_submissions = Submission.objects.filter(
- # submitted_to_journal='SciPost Physics'
- # ).exclude(status__in=SUBMISSION_STATUS_PUBLICLY_UNLISTED
- # ).order_by('-submission_date')
context = {
- #'issues': issues,
'current_issue': current_issue,
- 'latest_issue': latest_issue,
- #'recent_papers': recent_papers,
- #'accepted_SP_submissions': accepted_SP_submissions,
- #'current_SP_submissions': current_SP_submissions,
+ 'latest_issue': latest_issue
}
return render(request, 'journals/scipost_physics.html', context)
@@ -104,7 +52,7 @@ def scipost_physics(request):
def scipost_physics_issues(request):
issues = Issue.objects.filter(
in_volume__in_journal__name='SciPost Physics').order_by('-until_date')
- context = {'issues': issues,}
+ context = {'issues': issues, }
return render(request, 'journals/scipost_physics_issues.html', context)
@@ -112,13 +60,10 @@ def scipost_physics_recent(request):
"""
Display page for the most recent 20 publications in SciPost Physics.
"""
- #latest_issue = Issue.objects.filter(
- # in_volume__in_journal__name='SciPost Physics').order_by('-until_date').first()
+
recent_papers = Publication.objects.filter(
- #in_issue=latest_issue).order_by('-publication_date')
in_issue__in_volume__in_journal__name='SciPost Physics').order_by('-publication_date')[:20]
- context = {#'latest_issue': latest_issue,
- 'recent_papers': recent_papers}
+ context = {'recent_papers': recent_papers}
return render(request, 'journals/scipost_physics_recent.html', context)
@@ -134,19 +79,6 @@ def scipost_physics_accepted(request):
return render(request, 'journals/scipost_physics_accepted.html', context)
-# def scipost_physics_submissions(request):
-# """
-# Display page for submissions to SciPost Physics which
-# have been accepted but are not yet published.
-# """
-# current_SP_submissions = Submission.objects.filter(
-# submitted_to_journal='SciPost Physics'
-# ).exclude(status__in=SUBMISSION_STATUS_PUBLICLY_UNLISTED
-# ).order_by('-submission_date')
-# context = {'current_SP_submissions': current_SP_submissions}
-# return render(request, 'journals/scipost_physics_submissions.html', context)
-
-
def scipost_physics_info_for_authors(request):
return render(request, 'journals/scipost_physics_info_for_authors.html')
@@ -155,16 +87,14 @@ def scipost_physics_about(request):
return render(request, 'journals/scipost_physics_about.html')
-
def scipost_physics_issue_detail(request, volume_nr, issue_nr):
- issue = get_object_or_404 (Issue, in_volume__in_journal__name='SciPost Physics',
- number=issue_nr)
+ issue = get_object_or_404(Issue, in_volume__in_journal__name='SciPost Physics',
+ number=issue_nr, in_volume__number=volume_nr)
papers = issue.publication_set.order_by('paper_nr')
context = {'issue': issue, 'papers': papers}
return render(request, 'journals/scipost_physics_issue_detail.html', context)
-
#######################
# Publication process #
#######################
@@ -187,6 +117,7 @@ def upload_proofs(request):
"""
return render(request, 'journals/upload_proofs.html')
+
@permission_required('scipost.can_publish_accepted_submission', return_403=True)
@transaction.atomic
def initiate_publication(request):
@@ -199,16 +130,15 @@ def initiate_publication(request):
if request.method == 'POST':
initiate_publication_form = InitiatePublicationForm(request.POST)
if initiate_publication_form.is_valid():
- submission = get_object_or_404(Submission,
- pk=initiate_publication_form.cleaned_data['accepted_submission'].id)
- current_issue = get_object_or_404(Issue,
- pk=initiate_publication_form.cleaned_data['to_be_issued_in'].id)
+ submission = get_object_or_404(Submission, pk=initiate_publication_form.cleaned_data[
+ 'accepted_submission'].id)
+ current_issue = get_object_or_404(Issue, pk=initiate_publication_form.cleaned_data[
+ 'to_be_issued_in'].id)
+
# Determine next available paper number:
- #papers_in_current_issue = Publication.objects.filter(in_issue=current_issue)
papers_in_current_volume = Publication.objects.filter(
in_issue__in_volume=current_issue.in_volume)
paper_nr = 1
- #while papers_in_current_issue.filter(paper_nr=paper_nr).exists():
while papers_in_current_volume.filter(paper_nr=paper_nr).exists():
paper_nr += 1
if paper_nr > 999:
@@ -218,7 +148,7 @@ def initiate_publication(request):
+ '.' + str(current_issue.in_volume.number)
+ '.' + str(current_issue.number) + '.' + paper_nr_string(paper_nr)
)
- doi_string='10.21468/' + doi_label
+ doi_string = '10.21468/' + doi_label
BiBTeX_entry = (
'@Article{' + doi_label + ',\n'
'\ttitle={{' + submission.title + '}},\n'
@@ -255,7 +185,7 @@ def initiate_publication(request):
'latest_activity': timezone.now(),
}
validate_publication_form = ValidatePublicationForm(initial=initial)
- context = {'validate_publication_form': validate_publication_form,}
+ context = {'validate_publication_form': validate_publication_form, }
return render(request, 'journals/validate_publication.html', context)
else:
errormessage = 'The form was not filled validly.'
@@ -292,8 +222,8 @@ def validate_publication(request):
publication.save()
# Move file to final location
initial_path = publication.pdf_file.path
- new_dir = (publication.in_issue.path + '/'
- + paper_nr_string(publication.paper_nr))
+ new_dir = (publication.in_issue.path + '/'
+ + paper_nr_string(publication.paper_nr))
new_path = new_dir + '/' + publication.doi_label.replace('.', '_') + '.pdf'
os.makedirs(new_dir)
os.rename(initial_path, new_path)
@@ -308,7 +238,7 @@ def validate_publication(request):
JournalUtils.load({'publication': publication})
JournalUtils.send_authors_paper_published_email()
ack_header = 'The publication has been validated.'
- context = {'ack_header': ack_header,}
+ context = {'ack_header': ack_header, }
return render(request, 'scipost/acknowledgement.html', context)
else:
errormessage = 'The form was invalid.'
@@ -331,7 +261,7 @@ def mark_first_author(request, publication_id, contributor_id):
publication.first_author_unregistered = None
publication.save()
return redirect(reverse('scipost:publication_detail',
- kwargs={'doi_string': publication.doi_string,}))
+ kwargs={'doi_string': publication.doi_string, }))
@permission_required('scipost.can_publish_accepted_submission', return_403=True)
@@ -343,7 +273,7 @@ def mark_first_author_unregistered(request, publication_id, unregistered_author_
publication.first_author_unregistered = unregistered_author
publication.save()
return redirect(reverse('scipost:publication_detail',
- kwargs={'doi_string': publication.doi_string,}))
+ kwargs={'doi_string': publication.doi_string, }))
@permission_required('scipost.can_publish_accepted_submission', return_403=True)
@@ -361,7 +291,7 @@ def add_author(request, publication_id, contributor_id=None, unregistered_author
publication.authors.add(contributor)
publication.save()
return redirect(reverse('scipost:publication_detail',
- kwargs={'doi_string': publication.doi_string,}))
+ kwargs={'doi_string': publication.doi_string, }))
if request.method == 'POST':
form = UnregisteredAuthorForm(request.POST)
if form.is_valid():
@@ -371,7 +301,7 @@ def add_author(request, publication_id, contributor_id=None, unregistered_author
last_name__icontains=form.cleaned_data['last_name'])
new_unreg_author_form = UnregisteredAuthorForm(
initial={'first_name': form.cleaned_data['first_name'],
- 'last_name': form.cleaned_data['last_name'],})
+ 'last_name': form.cleaned_data['last_name'], })
else:
errormessage = 'Please fill in the form properly'
return render(request, 'scipost/error.html', context={'errormessage': errormessage})
@@ -384,7 +314,7 @@ def add_author(request, publication_id, contributor_id=None, unregistered_author
'contributors_found': contributors_found,
'unregistered_authors_found': unregistered_authors_found,
'form': form,
- 'new_unreg_author_form': new_unreg_author_form,}
+ 'new_unreg_author_form': new_unreg_author_form, }
return render(request, 'journals/add_author.html', context)
@@ -396,7 +326,7 @@ def add_unregistered_author(request, publication_id, unregistered_author_id):
publication.unregistered_authors.add(unregistered_author)
publication.save()
return redirect(reverse('scipost:publication_detail',
- kwargs={'doi_string': publication.doi_string,}))
+ kwargs={'doi_string': publication.doi_string, }))
@permission_required('scipost.can_publish_accepted_submission', return_403=True)
@@ -407,12 +337,12 @@ def add_new_unreg_author(request, publication_id):
new_unreg_author_form = UnregisteredAuthorForm(request.POST)
if new_unreg_author_form.is_valid():
new_unreg_author = UnregisteredAuthor(
- first_name = new_unreg_author_form.cleaned_data['first_name'],
- last_name = new_unreg_author_form.cleaned_data['last_name'],)
+ first_name=new_unreg_author_form.cleaned_data['first_name'],
+ last_name=new_unreg_author_form.cleaned_data['last_name'],)
new_unreg_author.save()
publication.authors_unregistered.add(new_unreg_author)
return redirect(reverse('scipost:publication_detail',
- kwargs={'doi_string': publication.doi_string,}))
+ kwargs={'doi_string': publication.doi_string, }))
errormessage = 'Method add_new_unreg_author can only be called with POST.'
return render(request, 'scipost/error.html', context={'errormessage': errormessage})
@@ -432,16 +362,17 @@ def create_citation_list_metadata(request, doi_string):
publication.metadata['citation_list'] = []
entries_list = bibitems_form.cleaned_data['latex_bibitems'].split('\doi{')
nentries = 1
- for entry in entries_list[1:]: # drop first bit before first \doi{
+ for entry in entries_list[1:]: # drop first bit before first \doi{
publication.metadata['citation_list'].append(
{'key': 'ref' + str(nentries),
- 'doi': entry.partition('}')[0],}
+ 'doi': entry.partition('}')[0], }
)
nentries += 1
publication.save()
bibitems_form = CitationListBibitemsForm()
- context = {'publication': publication,
- 'bibitems_form': bibitems_form,
+ context = {
+ 'publication': publication,
+ 'bibitems_form': bibitems_form,
}
if request.method == 'POST':
context['citation_list'] = publication.metadata['citation_list']
@@ -460,10 +391,11 @@ def create_funding_info_metadata(request, doi_string):
if request.method == 'POST':
funding_info_form = FundingInfoForm(request.POST)
if funding_info_form.is_valid():
- publication.metadata['funding_statement'] = funding_info_form.cleaned_data['funding_statement']
+ publication.metadata['funding_statement'] = funding_info_form.cleaned_data[
+ 'funding_statement']
publication.save()
- initial = {'funding_statement': '',}
+ initial = {'funding_statement': '', }
funding_statement = ''
try:
initial['funding_statement'] = publication.metadata['funding_statement']
@@ -472,7 +404,7 @@ def create_funding_info_metadata(request, doi_string):
pass
context = {'publication': publication,
'funding_info_form': FundingInfoForm(initial=initial),
- 'funding_statement': funding_statement,}
+ 'funding_statement': funding_statement, }
return render(request, 'journals/create_funding_info_metadata.html', context)
@@ -494,7 +426,7 @@ def create_metadata_xml(request, doi_string):
publication.metadata_xml = create_metadata_xml_form.cleaned_data['metadata_xml']
publication.save()
return redirect(reverse('scipost:publication_detail',
- kwargs={'doi_string': publication.doi_string,}))
+ kwargs={'doi_string': publication.doi_string, }))
# create a doi_batch_id
salt = ""
@@ -505,7 +437,6 @@ def create_metadata_xml(request, doi_string):
idsalt = idsalt.encode('utf8')
doi_batch_id = hashlib.sha1(salt+idsalt).hexdigest()
- #publication.metadata_xml = (
initial = {'metadata_xml': ''}
initial['metadata_xml'] += (
'<?xml version="1.0" encoding="UTF-8"?>\n'
@@ -553,44 +484,37 @@ def create_metadata_xml(request, doi_string):
# this to be checked by EdAdmin before publishing.
for author in publication.authors.all():
if author == publication.first_author:
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'<person_name sequence=\'first\' contributor_role=\'author\'> '
'<given_name>' + author.user.first_name + '</given_name> '
'<surname>' + author.user.last_name + '</surname> '
)
else:
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'<person_name sequence=\'additional\' contributor_role=\'author\'> '
'<given_name>' + author.user.first_name + '</given_name> '
'<surname>' + author.user.last_name + '</surname> '
)
if author.orcid_id:
- #publication.metadata_xml += '<ORCID>http://orcid.org' + author.orcid_id + '</ORCID>'
initial['metadata_xml'] += '<ORCID>http://orcid.org/' + author.orcid_id + '</ORCID>'
initial['metadata_xml'] += '</person_name>\n'
for author_unreg in publication.authors_unregistered.all():
if author_unreg == publication.first_author_unregistered:
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'<person_name sequence=\'first\' contributor_role=\'author\'> '
'<given_name>' + author_unreg.first_name + '</given_name> '
'<surname>' + author_unreg.last_name + '</surname> '
)
else:
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'<person_name sequence=\'additional\' contributor_role=\'author\'> '
'<given_name>' + author_unreg.first_name + '</given_name> '
'<surname>' + author_unreg.last_name + '</surname> '
)
initial['metadata_xml'] += '</person_name>\n'
- #publication.metadata_xml += '</contributors>\n'
initial['metadata_xml'] += '</contributors>\n'
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'<publication_date media_type=\'online\'>\n'
'<month>' + publication.publication_date.strftime('%m') + '</month>'
@@ -612,29 +536,22 @@ def create_metadata_xml(request, doi_string):
)
try:
if publication.metadata['citation_list']:
- #publication.metadata_xml += '<citation_list>\n'
initial['metadata_xml'] += '<citation_list>\n'
for ref in publication.metadata['citation_list']:
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'<citation key="' + ref['key'] + '">'
'<doi>' + ref['doi'] + '</doi>'
'</citation>\n'
)
- #publication.metadata_xml += '</citation_list>\n'
initial['metadata_xml'] += '</citation_list>\n'
except KeyError:
pass
- #publication.metadata_xml += (
initial['metadata_xml'] += (
'</journal_article>\n'
'</journal>\n'
)
- #publication.metadata_xml += '</body>\n</doi_batch>'
initial['metadata_xml'] += '</body>\n</doi_batch>'
publication.save()
- #else:
- # errormessage = 'The form was invalidly filled.'
context = {'publication': publication,
'create_metadata_xml_form': CreateMetadataXMLForm(initial=initial),
@@ -642,41 +559,6 @@ def create_metadata_xml(request, doi_string):
return render(request, 'journals/create_metadata_xml.html', context)
-# @permission_required('scipost.can_publish_accepted_submission', return_403=True)
-# @transaction.atomic
-# def test_metadata_xml_deposit(request, doi_string):
-# """
-# Prior to the actual Crossref metadata deposit,
-# test the metadata_xml using the Crossref test server.
-# Makes use of the python requests module.
-# """
-# publication = get_object_or_404 (Publication, doi_string=doi_string)
-# url = 'http://test.crossref.org/servlet/deposit'
-# #headers = {'Content-type': 'multipart/form-data'}
-# params = {'operation': 'doMDUpload',
-# 'login_id': settings.CROSSREF_LOGIN_ID,
-# 'login_passwd': settings.CROSSREF_LOGIN_PASSWORD,
-# }
-# #files = {'fname': ('metadata.xml', publication.metadata_xml, 'multipart/form-data', {'Expires': '0'})}
-# files = {'fname': ('metadata.xml', publication.metadata_xml, 'multipart/form-data')}
-# r = requests.post(url,
-# params=params,
-# files=files,
-# #verify=settings.CERTFILE,
-# #verify=False,
-# )
-# #s = requests.Session()
-# #s.mount('https://', MyAdapter())
-# #r = s.post(url, params=params, files=files)
-# response_headers = r.headers
-# response_text = r.text
-# context = {'publication': publication,
-# 'response_headers': response_headers,
-# 'response_text': response_text,
-# }
-# return render(request, 'journals/test_metadata_xml_deposit.html', context)
-
-
@permission_required('scipost.can_publish_accepted_submission', return_403=True)
@transaction.atomic
def metadata_xml_deposit(request, doi_string, option='test'):
@@ -685,30 +567,32 @@ def metadata_xml_deposit(request, doi_string, option='test'):
If test==True, test the metadata_xml using the Crossref test server.
Makes use of the python requests module.
"""
- publication = get_object_or_404 (Publication, doi_string=doi_string)
- if option=='deposit':
+ publication = get_object_or_404(Publication, doi_string=doi_string)
+ if option == 'deposit':
url = 'http://doi.crossref.org/servlet/deposit'
- elif option=='test':
+ elif option == 'test':
url = 'http://test.crossref.org/servlet/deposit'
else:
- {'errormessage': 'metadata_xml_deposit can only be called with options test or deposit',}
+ errormessage = 'metadata_xml_deposit can only be called with options test or deposit'
return render(request, 'scipost/error.html', context={'errormessage': errormessage})
- params = {'operation': 'doMDUpload',
- 'login_id': settings.CROSSREF_LOGIN_ID,
- 'login_passwd': settings.CROSSREF_LOGIN_PASSWORD,
- }
+ params = {
+ 'operation': 'doMDUpload',
+ 'login_id': settings.CROSSREF_LOGIN_ID,
+ 'login_passwd': settings.CROSSREF_LOGIN_PASSWORD,
+ }
files = {'fname': ('metadata.xml', publication.metadata_xml, 'multipart/form-data')}
r = requests.post(url,
params=params,
files=files,
- )
+ )
response_headers = r.headers
response_text = r.text
- context = {'option': option,
- 'publication': publication,
- 'response_headers': response_headers,
- 'response_text': response_text,
+ context = {
+ 'option': option,
+ 'publication': publication,
+ 'response_headers': response_headers,
+ 'response_text': response_text,
}
return render(request, 'journals/metadata_xml_deposit.html', context)
@@ -744,10 +628,9 @@ def harvest_citedby_links(request, doi_string):
params = {'usr': settings.CROSSREF_LOGIN_ID,
'pwd': settings.CROSSREF_LOGIN_PASSWORD,
'qdata': query_xml,
- 'doi': publication.doi_string,}
+ 'doi': publication.doi_string, }
r = requests.post(url, params=params,)
response_headers = r.headers
- #response_text = bytes(r.text, 'utf-8').decode('unicode_escape')
response_text = r.text
response_deserialized = ET.fromstring(r.text)
prefix = '{http://www.crossref.org/qrschema/2.0}'
@@ -757,7 +640,10 @@ def harvest_citedby_links(request, doi_string):
article_title = link.find(prefix + 'journal_cite').find(prefix + 'article_title').text
journal_abbreviation = link.find(prefix + 'journal_cite').find(
prefix + 'journal_abbreviation').text
- volume = link.find(prefix + 'journal_cite').find(prefix + 'volume').text
+ try:
+ volume = link.find(prefix + 'journal_cite').find(prefix + 'volume').text
+ except AttributeError:
+ volume = None
try:
first_page = link.find(prefix + 'journal_cite').find(prefix + 'first_page').text
except:
@@ -783,31 +669,31 @@ def harvest_citedby_links(request, doi_string):
'volume': volume,
'first_page': first_page,
'item_number': item_number,
- 'year': year,})
+ 'year': year, })
publication.citedby = citations
publication.save()
- context = {'publication': publication,
- 'response_headers': response_headers,
- 'response_text': response_text,
- 'response_deserialized': response_deserialized,
- 'citations': citations,
+ context = {
+ 'publication': publication,
+ 'response_headers': response_headers,
+ 'response_text': response_text,
+ 'response_deserialized': response_deserialized,
+ 'citations': citations,
}
return render(request, 'journals/harvest_citedby_links.html', context)
-
###########
# Viewing #
###########
def publication_detail(request, doi_string):
- publication = get_object_or_404 (Publication, doi_string=doi_string)
- context = {'publication': publication,}
+ publication = get_object_or_404(Publication, doi_string=doi_string)
+ context = {'publication': publication, }
return render(request, 'journals/publication_detail.html', context)
def publication_pdf(request, doi_string):
- publication = get_object_or_404 (Publication, doi_string=doi_string)
+ publication = get_object_or_404(Publication, doi_string=doi_string)
pdf = File(publication.pdf_file)
response = HttpResponse(pdf, content_type='application/pdf')
response['Content-Disposition'] = ('filename='
@@ -816,13 +702,13 @@ def publication_pdf(request, doi_string):
def publication_detail_from_doi_label(request, doi_label):
- publication = get_object_or_404 (Publication, doi_label=doi_label)
- context = {'publication': publication,}
+ publication = get_object_or_404(Publication, doi_label=doi_label)
+ context = {'publication': publication, }
return render(request, 'journals/publication_detail.html', context)
def publication_pdf_from_doi_label(request, doi_label):
- publication = get_object_or_404 (Publication, doi_label=doi_label)
+ publication = get_object_or_404(Publication, doi_label=doi_label)
pdf = File(publication.pdf_file)
response = HttpResponse(pdf, content_type='application/pdf')
response['Content-Disposition'] = ('filename='
diff --git a/scipost/admin.py b/scipost/admin.py
index 3c7650cc21f679532b38d44ebae768826dcbde6e..799517e9b63c9541937e8669a9945ea2361b77f9 100644
--- a/scipost/admin.py
+++ b/scipost/admin.py
@@ -20,6 +20,30 @@ admin.site.unregister(User)
admin.site.register(User, UserAdmin)
+class VGMAdmin(admin.ModelAdmin):
+ search_fields = ['start_date']
+
+admin.site.register(VGM, VGMAdmin)
+
+
+class FeedbackAdmin(admin.ModelAdmin):
+ search_fields = ['feedback', 'by']
+
+admin.site.register(Feedback, FeedbackAdmin)
+
+
+class NominationAdmin(admin.ModelAdmin):
+ search_fields = ['last_name', 'first_name', 'by']
+
+admin.site.register(Nomination, NominationAdmin)
+
+
+class MotionAdmin(admin.ModelAdmin):
+ search_fields = ['background', 'motion', 'put_forward_by']
+
+admin.site.register(Motion, MotionAdmin)
+
+
class RemarkAdmin(admin.ModelAdmin):
search_fields = ['contributor', 'remark']
diff --git a/scipost/db/fields.py b/scipost/db/fields.py
new file mode 100644
index 0000000000000000000000000000000000000000..ebbd6e74100d71dbb5985cb9692f76c10fd13b8d
--- /dev/null
+++ b/scipost/db/fields.py
@@ -0,0 +1,14 @@
+from django.db import models
+from django.utils import timezone
+
+
+class AutoDateTimeField(models.DateTimeField):
+ '''Create an auto_now DateTimeField instead of auto_now.'''
+
+ def __init__(self, *args, **kwargs):
+ kwargs['editable'] = False
+ kwargs['blank'] = True
+ super(AutoDateTimeField, self).__init__(*args, **kwargs)
+
+ def pre_save(self, model_instance, add):
+ return timezone.now()
diff --git a/scipost/factories.py b/scipost/factories.py
index 5e22d34f51ad3ca28de962b1876cc840a56f8d13..27ebc93ef459df1de461cf65af874680d0ecbb48 100644
--- a/scipost/factories.py
+++ b/scipost/factories.py
@@ -1,7 +1,7 @@
import factory
from django.contrib.auth import get_user_model
-from django.contrib.auth.models import Group, User
+from django.contrib.auth.models import Group
from .models import Contributor
diff --git a/scipost/forms.py b/scipost/forms.py
index d58a27352b45f3827e88aef7ae39e47e43ab7514..b4d7422a13dda2bc52cc11d3d2c9a4e228c00234 100644
--- a/scipost/forms.py
+++ b/scipost/forms.py
@@ -1,5 +1,6 @@
from django import forms
+from django.contrib.auth.models import User, Group
from django.db.models import Q
from django_countries import countries
@@ -8,10 +9,15 @@ from django_countries.fields import LazyTypedChoiceField
from captcha.fields import CaptchaField
from crispy_forms.helper import FormHelper
-from crispy_forms.layout import Layout, Div, Field, Fieldset, HTML, Submit
+from crispy_forms.layout import Layout, Div, Field, HTML, Submit
-from .models import *
-from .constants import SCIPOST_DISCIPLINES
+from .constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS
+from .models import TITLE_CHOICES, SCIPOST_FROM_ADDRESSES, ARC_LENGTHS,\
+ Contributor, DraftInvitation, RegistrationInvitation,\
+ SupportingPartner, SPBMembershipAgreement,\
+ UnavailabilityPeriod, PrecookedEmail,\
+ List, Team, Graph, Node,\
+ Feedback, Nomination, Motion
from journals.models import Publication
from submissions.models import SUBMISSION_STATUS_PUBLICLY_UNLISTED
@@ -26,6 +32,7 @@ REGISTRATION_REFUSAL_CHOICES = (
)
reg_ref_dict = dict(REGISTRATION_REFUSAL_CHOICES)
+
class RegistrationForm(forms.Form):
title = forms.ChoiceField(choices=TITLE_CHOICES, label='* Title')
first_name = forms.CharField(label='* First name', max_length=100)
@@ -38,7 +45,9 @@ class RegistrationForm(forms.Form):
discipline = forms.ChoiceField(choices=SCIPOST_DISCIPLINES, label='* Main discipline')
country_of_employment = LazyTypedChoiceField(
choices=countries, label='* Country of employment', initial='NL',
- widget=CountrySelectWidget(layout='{widget}<img class="country-select-flag" id="{flag_id}" style="margin: 6px 4px 0" src="{country.flag}">'))
+ widget=CountrySelectWidget(layout=(
+ '{widget}<img class="country-select-flag" id="{flag_id}"'
+ ' style="margin: 6px 4px 0" src="{country.flag}">')))
affiliation = forms.CharField(label='* Affiliation', max_length=300)
address = forms.CharField(
label='Address', max_length=1000,
@@ -60,7 +69,7 @@ class DraftInvitationForm(forms.ModelForm):
fields = ['title', 'first_name', 'last_name', 'email',
'invitation_type',
'cited_in_submission', 'cited_in_publication'
- ]
+ ]
def __init__(self, *args, **kwargs):
super(DraftInvitationForm, self).__init__(*args, **kwargs)
@@ -94,12 +103,13 @@ class RegistrationInvitationForm(forms.ModelForm):
'invitation_type',
'cited_in_submission', 'cited_in_publication',
'message_style', 'personal_message'
- ]
+ ]
def __init__(self, *args, **kwargs):
super(RegistrationInvitationForm, self).__init__(*args, **kwargs)
self.fields['personal_message'].widget.attrs.update(
- {'placeholder': 'NOTE: a personal phrase or two. The bulk of the text will be auto-generated.'})
+ {'placeholder': ('NOTE: a personal phrase or two.'
+ ' The bulk of the text will be auto-generated.')})
self.fields['cited_in_submission'] = forms.ModelChoiceField(
queryset=Submission.objects.all().exclude(
status__in=SUBMISSION_STATUS_PUBLICLY_UNLISTED).order_by('-submission_date'),
@@ -124,6 +134,7 @@ class RegistrationInvitationForm(forms.ModelForm):
Div(Field('cited_in_publication'),),
)
+
class ModifyPersonalMessageForm(forms.Form):
personal_message = forms.CharField(widget=forms.Textarea())
@@ -133,37 +144,44 @@ class UpdateUserDataForm(forms.ModelForm):
model = User
fields = ['email', 'first_name', 'last_name']
+
class UpdatePersonalDataForm(forms.ModelForm):
class Meta:
model = Contributor
fields = ['title', 'discipline', 'expertises', 'orcid_id', 'country_of_employment',
'affiliation', 'address', 'personalwebpage',
'accepts_SciPost_emails'
- ]
+ ]
widgets = {'country_of_employment': CountrySelectWidget()}
+
class VetRegistrationForm(forms.Form):
- promote_to_registered_contributor = forms.BooleanField(required=False, label='Accept registration')
+ promote_to_registered_contributor = forms.BooleanField(required=False,
+ label='Accept registration')
refuse = forms.BooleanField(required=False)
refusal_reason = forms.ChoiceField(choices=REGISTRATION_REFUSAL_CHOICES, required=False)
email_response_field = forms.CharField(widget=forms.Textarea(),
label='Justification (optional)', required=False)
+
class AuthenticationForm(forms.Form):
username = forms.CharField(label='Username', max_length=100)
password = forms.CharField(label='Password', widget=forms.PasswordInput())
+
class PasswordChangeForm(forms.Form):
password_prev = forms.CharField(label='Existing password', widget=forms.PasswordInput())
password_new = forms.CharField(label='New password', widget=forms.PasswordInput())
password_verif = forms.CharField(label='Reenter new password', widget=forms.PasswordInput())
+
AUTHORSHIP_CLAIM_CHOICES = (
('-', '-'),
('True', 'I am an author'),
('False', 'I am not an author'),
)
+
class AuthorshipClaimForm(forms.Form):
claim = forms.ChoiceField(choices=AUTHORSHIP_CLAIM_CHOICES, required=False)
@@ -185,12 +203,14 @@ class RemarkForm(forms.Form):
def __init__(self, *args, **kwargs):
super(RemarkForm, self).__init__(*args, **kwargs)
self.fields['remark'].widget.attrs.update(
- {'rows': 3, 'cols': 40, 'placeholder': 'Enter your remarks here. You can use LaTeX in $...$ or \[ \].'})
+ {'rows': 3, 'cols': 40,
+ 'placeholder': 'Enter your remarks here. You can use LaTeX in $...$ or \[ \].'})
class SearchForm(forms.Form):
query = forms.CharField(max_length=100, label='',
- widget=forms.TextInput(attrs={'class': 'form-control mr-0 mb-2 mr-lg-2 mb-lg-0'}))
+ widget=forms.TextInput(attrs={
+ 'class': 'form-control mr-0 mb-2 mr-lg-2 mb-lg-0'}))
class EmailGroupMembersForm(forms.Form):
@@ -290,7 +310,7 @@ class ManageTeamsForm(forms.Form):
def __init__(self, *args, **kwargs):
contributor = kwargs.pop('contributor')
super(ManageTeamsForm, self).__init__(*args, **kwargs)
- self.fields['teams_with_access'].queryset=Team.objects.filter(
+ self.fields['teams_with_access'].queryset = Team.objects.filter(
Q(leader=contributor) | Q(members__in=[contributor]))
self.fields['teams_with_access'].widget.attrs.update(
{'placeholder': 'Team(s) to be given access rights:'})
@@ -314,7 +334,6 @@ class CreateArcForm(forms.Form):
self.fields['target'].queryset = Node.objects.filter(graph=graph)
-
#############################
# Supporting Partners Board #
#############################
@@ -325,13 +344,13 @@ class SupportingPartnerForm(forms.ModelForm):
fields = ['partner_type', 'institution',
'institution_acronym', 'institution_address',
'consortium_members'
- ]
+ ]
def __init__(self, *args, **kwargs):
super(SupportingPartnerForm, self).__init__(*args, **kwargs)
- self.fields['institution_address'].widget = forms.Textarea({'rows': 8,})
+ self.fields['institution_address'].widget = forms.Textarea({'rows': 8, })
self.fields['consortium_members'].widget.attrs.update(
- {'placeholder': 'Please list the names of the institutions within the consortium',})
+ {'placeholder': 'Please list the names of the institutions within the consortium', })
self.helper = FormHelper()
self.helper.layout = Layout(
Div(
@@ -347,6 +366,7 @@ class SupportingPartnerForm(forms.ModelForm):
css_class='row')
)
+
class SPBMembershipForm(forms.ModelForm):
class Meta:
model = SPBMembershipAgreement
@@ -371,3 +391,60 @@ class SPBMembershipForm(forms.ModelForm):
css_class="col-4"),
css_class="row"),
)
+
+
+#################
+# VGMs, Motions #
+#################
+
+class FeedbackForm(forms.ModelForm):
+ class Meta:
+ model = Feedback
+ fields = ['feedback']
+
+
+class NominationForm(forms.ModelForm):
+ class Meta:
+ model = Nomination
+ fields = ['first_name', 'last_name',
+ 'discipline', 'expertises', 'webpage']
+
+ def __init__(self, *args, **kwargs):
+ super(NominationForm, self).__init__(*args, **kwargs)
+ self.fields['expertises'].widget = forms.SelectMultiple(choices=SCIPOST_SUBJECT_AREAS)
+
+
+class MotionForm(forms.ModelForm):
+ class Meta:
+ model = Motion
+ fields = ['category', 'background', 'motion']
+
+ def __init__(self, *args, **kwargs):
+ super(MotionForm, self).__init__(*args, **kwargs)
+ self.fields['background'].label = ''
+ self.fields['background'].widget.attrs.update(
+ {'rows': 8, 'cols': 100,
+ 'placeholder': 'Provide useful background information on your Motion.'})
+ self.fields['motion'].label = ''
+ self.fields['motion'].widget.attrs.update(
+ {'rows': 8, 'cols': 100,
+ 'placeholder': 'Phrase your Motion as clearly and succinctly as possible.'})
+ self.helper = FormHelper()
+ self.helper.layout = Layout(
+ Field('category'),
+ Div(
+ Div(HTML('<p>Background:</p>'),
+ css_class="col-2"),
+ Div(
+ Field('background'),
+ css_class="col-10"),
+ css_class="row"),
+ Div(
+ Div(HTML('<p>Motion:</p>'),
+ css_class="col-2"),
+ Div(
+ Field('motion'),
+ css_class="col-10"),
+ css_class="row"),
+ Submit('submit', 'Submit'),
+ )
diff --git a/scipost/global_methods.py b/scipost/global_methods.py
index 1115ac33f4b96fe12074bb93def181aad67ebee1..3510aef9ea26803d370bc4035445190599249f0e 100644
--- a/scipost/global_methods.py
+++ b/scipost/global_methods.py
@@ -1,9 +1,10 @@
-from django.contrib.auth.models import User
+from .models import Contributor
-from .models import *
class Global(object):
+ ''' Is this thing really being used?'''
@classmethod
def get_contributor(cls, request):
+ '''This should be fixed within the user model itself?'''
Contributor.objects.get(user=request.user)
diff --git a/scipost/management/commands/add_groups_and_permissions.py b/scipost/management/commands/add_groups_and_permissions.py
index 7dbe007f4d9199739afb4ca4256122dc8ff9d178..e3977e696ae23584a4b2f846d1e5a10834fe08c2 100644
--- a/scipost/management/commands/add_groups_and_permissions.py
+++ b/scipost/management/commands/add_groups_and_permissions.py
@@ -1,6 +1,6 @@
-from django.core.management.base import BaseCommand, CommandError
+from django.core.management.base import BaseCommand
-from django.contrib.auth.models import Group, Permission, User
+from django.contrib.auth.models import Group, Permission
from django.contrib.contenttypes.models import ContentType
from scipost.models import Contributor
@@ -9,15 +9,6 @@ from scipost.models import Contributor
class Command(BaseCommand):
help = 'Defines groups and permissions'
- def add_arguments(self, parser):
- """Append arguments optionally for setup of Contributor roles."""
- parser.add_argument('-u', '--setup-user', metavar='<username>', type=str, required=False,
- help='Username to make registered contributor')
- parser.add_argument('-a', '--make-admin', required=False, action='store_true',
- help='Grant admin permissions to user (superuser only)')
- parser.add_argument('-t', '--make-tester', required=False, action='store_true',
- help='Grant test permissions to user')
-
def handle(self, *args, **options):
"""Append all user Groups and setup a Contributor roles to user."""
@@ -27,11 +18,13 @@ class Command(BaseCommand):
EditorialAdmin, created = Group.objects.get_or_create(name='Editorial Administrators')
EditorialCollege, created = Group.objects.get_or_create(name='Editorial College')
VettingEditors, created = Group.objects.get_or_create(name='Vetting Editors')
- RegisteredContributors, created = Group.objects.get_or_create(name='Registered Contributors')
+ RegisteredContributors, created = Group.objects.get_or_create(
+ name='Registered Contributors')
Developers, created = Group.objects.get_or_create(name='Developers')
Testers, created = Group.objects.get_or_create(name='Testers')
Ambassadors, created = Group.objects.get_or_create(name='Ambassadors')
JuniorAmbassadors, created = Group.objects.get_or_create(name='Junior Ambassadors')
+ ProductionOfficers, created = Group.objects.get_or_create(name='Production Officers')
# Create Permissions
content_type = ContentType.objects.get_for_model(Contributor)
@@ -69,6 +62,10 @@ class Command(BaseCommand):
codename='view_bylaws',
name='Can view By-laws of Editorial College',
content_type=content_type)
+ can_attend_VGMs, created = Permission.objects.get_or_create(
+ codename='can_attend_VGMs',
+ name='Can attend Virtual General Meetings',
+ content_type=content_type)
# Contributions (not related to submissions)
can_submit_comments, created = Permission.objects.get_or_create(
@@ -158,7 +155,6 @@ class Command(BaseCommand):
name='Can view docs: scipost',
content_type=content_type)
-
# Assign permissions to groups
SciPostAdmin.permissions.add(
can_manage_registration_invitations,
@@ -173,9 +169,11 @@ class Command(BaseCommand):
can_assign_submissions,
can_prepare_recommendations_for_voting,
can_fix_College_decision,
+ can_attend_VGMs,
)
AdvisoryBoard.permissions.add(
can_manage_registration_invitations,
+ can_attend_VGMs,
)
EditorialAdmin.permissions.add(
can_view_pool,
@@ -183,12 +181,14 @@ class Command(BaseCommand):
can_prepare_recommendations_for_voting,
can_fix_College_decision,
can_publish_accepted_submission,
+ can_attend_VGMs,
)
EditorialCollege.permissions.add(
can_view_pool,
can_take_charge_of_submissions,
can_vet_submitted_reports,
view_bylaws,
+ can_attend_VGMs,
)
VettingEditors.permissions.add(
can_vet_commentary_requests,
@@ -213,29 +213,8 @@ class Command(BaseCommand):
JuniorAmbassadors.permissions.add(
can_draft_registration_invitations,
)
+ ProductionOfficers.permissions.add(
+ can_view_docs_scipost,
+ )
self.stdout.write(self.style.SUCCESS('Successfully created groups and permissions.'))
-
- if options['setup_user']:
- # Username is given, check options
- try:
- user = User.objects.get(username=str(options['setup_user']))
- except User.DoesNotExist:
- self.stdout.write(self.style.WARNING('User <%s> not found.' % options['update_user']))
- return None
-
- user.groups.add(RegisteredContributors)
- self.stdout.write(self.style.SUCCESS('Successfully setup %s as contributor.' % user))
-
- if user.is_superuser and options['make_admin']:
- # Setup admin contributor
- user.groups.add(SciPostAdmin)
- self.stdout.write(self.style.SUCCESS('Successfully made %s admin.' % user))
- elif options['make_admin']:
- # Make admin failed, user not a superuser
- self.stdout.write(self.style.WARNING('User %s is not a superuser.' % user))
-
- if options['make_tester']:
- # Setup test contributor
- user.groups.add(Testers)
- self.stdout.write(self.style.SUCCESS('Successfully made %s tester.' % user))
diff --git a/scipost/migrations/0030_auto_20170118_1406.py b/scipost/migrations/0030_auto_20170118_1406.py
new file mode 100644
index 0000000000000000000000000000000000000000..c938c3a399e751dec47bdabb829fed2c6a0cbc88
--- /dev/null
+++ b/scipost/migrations/0030_auto_20170118_1406.py
@@ -0,0 +1,64 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-18 13:06
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+import django.utils.timezone
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0029_remark_submission'),
+ ]
+
+ operations = [
+ migrations.CreateModel(
+ name='Motion',
+ fields=[
+ ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+ ('background', models.TextField()),
+ ('motion', models.TextField()),
+ ('date', models.DateField()),
+ ('nr_A', models.PositiveIntegerField(default=0)),
+ ('nr_N', models.PositiveIntegerField(default=0)),
+ ('nr_D', models.PositiveIntegerField(default=0)),
+ ('voting_deadline', models.DateTimeField(default=django.utils.timezone.now, verbose_name='voting deadline')),
+ ('accepted', models.NullBooleanField()),
+ ],
+ ),
+ migrations.CreateModel(
+ name='VGM',
+ fields=[
+ ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+ ('start_date', models.DateField()),
+ ('end_date', models.DateField()),
+ ],
+ ),
+ migrations.AddField(
+ model_name='motion',
+ name='VGM',
+ field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='scipost.VGM'),
+ ),
+ migrations.AddField(
+ model_name='motion',
+ name='in_agreement',
+ field=models.ManyToManyField(blank=True, related_name='in_agreement_with_motion', to='scipost.Contributor'),
+ ),
+ migrations.AddField(
+ model_name='motion',
+ name='in_disagreement',
+ field=models.ManyToManyField(blank=True, related_name='in_disagreement_with_motion', to='scipost.Contributor'),
+ ),
+ migrations.AddField(
+ model_name='motion',
+ name='in_notsure',
+ field=models.ManyToManyField(blank=True, related_name='in_notsure_with_motion', to='scipost.Contributor'),
+ ),
+ migrations.AddField(
+ model_name='motion',
+ name='put_forward_by',
+ field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='scipost.Contributor'),
+ ),
+ ]
diff --git a/scipost/migrations/0031_remark_motion.py b/scipost/migrations/0031_remark_motion.py
new file mode 100644
index 0000000000000000000000000000000000000000..cd4f9fc8bc5659a59d3794d4031f3de1c31c76b3
--- /dev/null
+++ b/scipost/migrations/0031_remark_motion.py
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-18 16:45
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0030_auto_20170118_1406'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='remark',
+ name='motion',
+ field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='scipost.Motion'),
+ ),
+ ]
diff --git a/scipost/migrations/0032_auto_20170121_1032.py b/scipost/migrations/0032_auto_20170121_1032.py
new file mode 100644
index 0000000000000000000000000000000000000000..0ed75e0e513916b1b25223e3aea4a3d11e62339a
--- /dev/null
+++ b/scipost/migrations/0032_auto_20170121_1032.py
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-21 09:32
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+import django.utils.timezone
+import scipost.models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0031_remark_motion'),
+ ]
+
+ operations = [
+ migrations.CreateModel(
+ name='Nomination',
+ fields=[
+ ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+ ('date', models.DateField()),
+ ('first_name', models.CharField(default='', max_length=30)),
+ ('last_name', models.CharField(default='', max_length=30)),
+ ('discipline', models.CharField(choices=[('physics', 'Physics'), ('astrophysics', 'Astrophysics'), ('mathematics', 'Mathematics'), ('computerscience', 'Computer Science')], default='physics', max_length=20, verbose_name='Main discipline')),
+ ('expertises', scipost.models.ChoiceArrayField(base_field=models.CharField(choices=[('Physics', (('Phys:AE', 'Atomic, Molecular and Optical Physics - Experiment'), ('Phys:AT', 'Atomic, Molecular and Optical Physics - Theory'), ('Phys:BI', 'Biophysics'), ('Phys:CE', 'Condensed Matter Physics - Experiment'), ('Phys:CT', 'Condensed Matter Physics - Theory'), ('Phys:FD', 'Fluid Dynamics'), ('Phys:GR', 'Gravitation, Cosmology and Astroparticle Physics'), ('Phys:HE', 'High-Energy Physics - Experiment'), ('Phys:HT', 'High-Energy Physics- Theory'), ('Phys:HP', 'High-Energy Physics - Phenomenology'), ('Phys:MP', 'Mathematical Physics'), ('Phys:NE', 'Nuclear Physics - Experiment'), ('Phys:NT', 'Nuclear Physics - Theory'), ('Phys:QP', 'Quantum Physics'), ('Phys:SM', 'Statistical and Soft Matter Physics'))), ('Astrophysics', (('Astro:GA', 'Astrophysics of Galaxies'), ('Astro:CO', 'Cosmology and Nongalactic Astrophysics'), ('Astro:EP', 'Earth and Planetary Astrophysics'), ('Astro:HE', 'High Energy Astrophysical Phenomena'), ('Astro:IM', 'Instrumentation and Methods for Astrophysics'), ('Astro:SR', 'Solar and Stellar Astrophysics'))), ('Mathematics', (('Math:AG', 'Algebraic Geometry'), ('Math:AT', 'Algebraic Topology'), ('Math:AP', 'Analysis of PDEs'), ('Math:CT', 'Category Theory'), ('Math:CA', 'Classical Analysis and ODEs'), ('Math:CO', 'Combinatorics'), ('Math:AC', 'Commutative Algebra'), ('Math:CV', 'Complex Variables'), ('Math:DG', 'Differential Geometry'), ('Math:DS', 'Dynamical Systems'), ('Math:FA', 'Functional Analysis'), ('Math:GM', 'General Mathematics'), ('Math:GN', 'General Topology'), ('Math:GT', 'Geometric Topology'), ('Math:GR', 'Group Theory'), ('Math:HO', 'History and Overview'), ('Math:IT', 'Information Theory'), ('Math:KT', 'K-Theory and Homology'), ('Math:LO', 'Logic'), ('Math:MP', 'Mathematical Physics'), ('Math:MG', 'Metric Geometry'), ('Math:NT', 'Number Theory'), ('Math:NA', 'Numerical Analysis'), ('Math:OA', 'Operator Algebras'), ('Math:OC', 'Optimization and Control'), ('Math:PR', 'Probability'), ('Math:QA', 'Quantum Algebra'), ('Math:RT', 'Representation Theory'), ('Math:RA', 'Rings and Algebras'), ('Math:SP', 'Spectral Theory'), ('Math:ST', 'Statistics Theory'), ('Math:SG', 'Symplectic Geometry'))), ('Computer Science', (('Comp:AI', 'Artificial Intelligence'), ('Comp:CC', 'Computational Complexity'), ('Comp:CE', 'Computational Engineering, Finance, and Science'), ('Comp:CG', 'Computational Geometry'), ('Comp:GT', 'Computer Science and Game Theory'), ('Comp:CV', 'Computer Vision and Pattern Recognition'), ('Comp:CY', 'Computers and Society'), ('Comp:CR', 'Cryptography and Security'), ('Comp:DS', 'Data Structures and Algorithms'), ('Comp:DB', 'Databases'), ('Comp:DL', 'Digital Libraries'), ('Comp:DM', 'Discrete Mathematics'), ('Comp:DC', 'Distributed, Parallel, and Cluster Computing'), ('Comp:ET', 'Emerging Technologies'), ('Comp:FL', 'Formal Languages and Automata Theory'), ('Comp:GL', 'General Literature'), ('Comp:GR', 'Graphics'), ('Comp:AR', 'Hardware Architecture'), ('Comp:HC', 'Human-Computer Interaction'), ('Comp:IR', 'Information Retrieval'), ('Comp:IT', 'Information Theory'), ('Comp:LG', 'Learning'), ('Comp:LO', 'Logic in Computer Science'), ('Comp:MS', 'Mathematical Software'), ('Comp:MA', 'Multiagent Systems'), ('Comp:MM', 'Multimedia'), ('Comp:NI', 'Networking and Internet Architecture'), ('Comp:NE', 'Neural and Evolutionary Computing'), ('Comp:NA', 'Numerical Analysis'), ('Comp:OS', 'Operating Systems'), ('Comp:OH', 'Other Computer Science'), ('Comp:PF', 'Performance'), ('Comp:PL', 'Programming Languages'), ('Comp:RO', 'Robotics'), ('Comp:SI', 'Social and Information Networks'), ('Comp:SE', 'Software Engineering'), ('Comp:SD', 'Sound'), ('Comp:SC', 'Symbolic Computation'), ('Comp:SY', 'Systems and Control')))], max_length=10), blank=True, null=True, size=None)),
+ ('nr_A', models.PositiveIntegerField(default=0)),
+ ('nr_N', models.PositiveIntegerField(default=0)),
+ ('nr_D', models.PositiveIntegerField(default=0)),
+ ('voting_deadline', models.DateTimeField(default=django.utils.timezone.now, verbose_name='voting deadline')),
+ ('accepted', models.NullBooleanField()),
+ ('by', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='scipost.Contributor')),
+ ('in_agreement', models.ManyToManyField(blank=True, related_name='in_agreement_with_nomination', to='scipost.Contributor')),
+ ('in_disagreement', models.ManyToManyField(blank=True, related_name='in_disagreement_with_nomination', to='scipost.Contributor')),
+ ('in_notsure', models.ManyToManyField(blank=True, related_name='in_notsure_with_nomination', to='scipost.Contributor')),
+ ],
+ ),
+ migrations.AddField(
+ model_name='remark',
+ name='nomination',
+ field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='scipost.Nomination'),
+ ),
+ ]
diff --git a/scipost/migrations/0033_nomination_vgm.py b/scipost/migrations/0033_nomination_vgm.py
new file mode 100644
index 0000000000000000000000000000000000000000..ea1713d6ae70acbcc619b6140f7e8b12c2000168
--- /dev/null
+++ b/scipost/migrations/0033_nomination_vgm.py
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-21 09:53
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0032_auto_20170121_1032'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='nomination',
+ name='VGM',
+ field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='scipost.VGM'),
+ ),
+ ]
diff --git a/scipost/migrations/0034_motion_category.py b/scipost/migrations/0034_motion_category.py
new file mode 100644
index 0000000000000000000000000000000000000000..2f3ab3c6657ecc2fc6ecced854612b826fb79b74
--- /dev/null
+++ b/scipost/migrations/0034_motion_category.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-21 10:12
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0033_nomination_vgm'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='motion',
+ name='category',
+ field=models.CharField(choices=[('ByLawAmend', 'Amendments to by-laws'), ('Workflow', 'Editorial workflow improvements'), ('General', 'General')], default='General', max_length=10),
+ ),
+ ]
diff --git a/scipost/migrations/0035_vgm_information.py b/scipost/migrations/0035_vgm_information.py
new file mode 100644
index 0000000000000000000000000000000000000000..9037d41378cc0095783a212485b4700f42c8fb24
--- /dev/null
+++ b/scipost/migrations/0035_vgm_information.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-21 13:19
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0034_motion_category'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='vgm',
+ name='information',
+ field=models.TextField(default=''),
+ ),
+ ]
diff --git a/scipost/migrations/0036_feedback.py b/scipost/migrations/0036_feedback.py
new file mode 100644
index 0000000000000000000000000000000000000000..ed0da2b20125fbfd2c9d6c083adcf7983e6db1b6
--- /dev/null
+++ b/scipost/migrations/0036_feedback.py
@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-21 14:17
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0035_vgm_information'),
+ ]
+
+ operations = [
+ migrations.CreateModel(
+ name='Feedback',
+ fields=[
+ ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+ ('date', models.DateField()),
+ ('feedback', models.TextField()),
+ ('VGM', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='scipost.VGM')),
+ ('by', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='scipost.Contributor')),
+ ],
+ ),
+ ]
diff --git a/scipost/migrations/0037_remark_feedback.py b/scipost/migrations/0037_remark_feedback.py
new file mode 100644
index 0000000000000000000000000000000000000000..2c07b7f723a2b95fffed6f1d1903369939e56f0b
--- /dev/null
+++ b/scipost/migrations/0037_remark_feedback.py
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-21 18:22
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0036_feedback'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='remark',
+ name='feedback',
+ field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='scipost.Feedback'),
+ ),
+ ]
diff --git a/scipost/migrations/0038_nomination_webpage.py b/scipost/migrations/0038_nomination_webpage.py
new file mode 100644
index 0000000000000000000000000000000000000000..f53718c7133b45b12ba7d8969630b31e5c6004ee
--- /dev/null
+++ b/scipost/migrations/0038_nomination_webpage.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2017-01-24 09:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('scipost', '0037_remark_feedback'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='nomination',
+ name='webpage',
+ field=models.URLField(default=''),
+ ),
+ ]
diff --git a/scipost/models.py b/scipost/models.py
index 85f5b085086c85eb376ba8b7886131d78cddeb56..1a4ca8bc79b79dc9b85fbf1d9c4e060e18141750 100644
--- a/scipost/models.py
+++ b/scipost/models.py
@@ -1,9 +1,10 @@
import datetime
from django import forms
-from django.contrib.auth.models import User, Group
-from django.contrib.postgres.fields import ArrayField, JSONField
+from django.contrib.auth.models import User
+from django.contrib.postgres.fields import ArrayField
from django.db import models
+from django.shortcuts import get_object_or_404
from django.template import Template, Context
from django.utils import timezone
from django.utils.safestring import mark_safe
@@ -12,8 +13,7 @@ from django_countries.fields import CountryField
from .constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS,\
disciplines_dict, subject_areas_dict
-
-from scipost.models import *
+from .db.fields import AutoDateTimeField
class ChoiceArrayField(ArrayField):
@@ -66,8 +66,8 @@ class TimeStampedModel(models.Model):
This will ensure the creation of created and modified
timestamps in the objects.
"""
- created = models.DateTimeField(auto_now_add=True)
- latest_activity = models.DateTimeField(auto_now=True)
+ created = models.DateTimeField(default=timezone.now)
+ latest_activity = AutoDateTimeField(default=timezone.now)
class Meta:
abstract = True
@@ -151,7 +151,6 @@ class Contributor(models.Model):
})
return template.render(context)
-
def public_info_as_table(self):
"""Prints out all publicly-accessible info as a table."""
@@ -185,11 +184,19 @@ class Contributor(models.Model):
def expertises_as_ul(self):
output = '<ul>'
- for exp in self.expertises:
- output += '<li>%s</li>' % subject_areas_dict[exp]
+ if self.expertises:
+ for exp in self.expertises:
+ output += '<li>%s</li>' % subject_areas_dict[exp]
output += '</ul>'
return mark_safe(output)
+ def expertises_as_string(self):
+ output = ''
+ if self.expertises:
+ for exp in self.expertises:
+ output += subject_areas_dict[exp] + ', '
+ return output
+
def assignments_summary_as_td(self):
assignments = self.editorialassignment_set.all()
nr_ongoing = assignments.filter(accepted=True, completed=False).count()
@@ -244,6 +251,12 @@ class UnavailabilityPeriod(models.Model):
class Remark(models.Model):
contributor = models.ForeignKey(Contributor, on_delete=models.CASCADE)
+ feedback = models.ForeignKey('scipost.Feedback', on_delete=models.CASCADE,
+ blank=True, null=True)
+ nomination = models.ForeignKey('scipost.Nomination', on_delete=models.CASCADE,
+ blank=True, null=True)
+ motion = models.ForeignKey('scipost.Motion', on_delete=models.CASCADE,
+ blank=True, null=True)
submission = models.ForeignKey('submissions.Submission',
on_delete=models.CASCADE,
blank=True, null=True)
@@ -254,22 +267,21 @@ class Remark(models.Model):
remark = models.TextField()
def __str__(self):
- return (title_dict[self.contributor.title] + ' '
- + self.contributor.user.first_name + ' '
+ return (self.contributor.user.first_name + ' '
+ self.contributor.user.last_name + ' on '
+ self.date.strftime("%Y-%m-%d"))
def as_li(self):
- output = '<li>{{ by }}<p>{{ remark }}</p>'
+ output = '<li><em>{{ by }}</em><p>{{ remark }}</p>'
context = Context({'by': str(self),
'remark': self.remark})
template = Template(output)
return template.render(context)
-##################
-## Invitations ###
-##################
+###############
+# Invitations #
+###############
INVITATION_TYPE = (
('F', 'Editorial Fellow'),
@@ -284,6 +296,7 @@ INVITATION_STYLE = (
('P', 'personal'),
)
+
class DraftInvitation(models.Model):
"""
Draft of an invitation, filled in by an officer.
@@ -305,7 +318,7 @@ class DraftInvitation(models.Model):
date_drafted = models.DateTimeField(default=timezone.now)
processed = models.BooleanField(default=False)
- def __str__ (self):
+ def __str__(self):
return (self.invitation_type + ' ' + self.first_name + ' ' + self.last_name)
@@ -337,7 +350,7 @@ class RegistrationInvitation(models.Model):
responded = models.BooleanField(default=False)
declined = models.BooleanField(default=False)
- def __str__ (self):
+ def __str__(self):
return (self.invitation_type + ' ' + self.first_name + ' ' + self.last_name
+ ' on ' + self.date_sent.strftime("%Y-%m-%d"))
@@ -362,12 +375,14 @@ class CitationNotification(models.Model):
text += ' (processed)'
return text
+
AUTHORSHIP_CLAIM_STATUS = (
(1, 'accepted'),
(0, 'not yet vetted (pending)'),
(-1, 'rejected'),
)
+
class AuthorshipClaim(models.Model):
claimant = models.ForeignKey(Contributor,
on_delete=models.CASCADE,
@@ -381,9 +396,9 @@ class AuthorshipClaim(models.Model):
thesislink = models.ForeignKey('theses.ThesisLink',
on_delete=models.CASCADE,
blank=True, null=True)
- vetted_by = models.ForeignKey (Contributor,
- on_delete=models.CASCADE,
- blank=True, null=True)
+ vetted_by = models.ForeignKey(Contributor,
+ on_delete=models.CASCADE,
+ blank=True, null=True)
status = models.SmallIntegerField(choices=AUTHORSHIP_CLAIM_STATUS, default=0)
@@ -433,10 +448,10 @@ class NewsItem(models.Model):
'<h3 class="NewsHeadline">{{ headline }}</h3>'
'<p>{{ date }}</p>'
'<p>{{ blurb }}</p>'
- )
+ )
context = Context({'headline': self.headline,
'date': self.date.strftime('%Y-%m-%d'),
- 'blurb': self.blurb,})
+ 'blurb': self.blurb, })
if self.followup_link:
descriptor += '<p><a href="{{ followup_link }}">{{ followup_link_text }}</a></p>'
context['followup_link'] = self.followup_link
@@ -445,16 +460,15 @@ class NewsItem(models.Model):
template = Template(descriptor)
return template.render(context)
-
def descriptor_small(self):
""" For index page. """
descriptor = ('<h3 class="NewsHeadline">{{ headline }}</h3>'
'<p>{{ date }}</p>'
'<p>{{ blurb }}</p>'
- )
+ )
context = Context({'headline': self.headline,
'date': self.date.strftime('%Y-%m-%d'),
- 'blurb': self.blurb,})
+ 'blurb': self.blurb, })
if self.followup_link:
descriptor += '<p><a href="{{ followup_link }}">{{ followup_link_text }}</a></p>'
context['followup_link'] = self.followup_link
@@ -463,6 +477,219 @@ class NewsItem(models.Model):
return template.render(context)
+#####################################
+# Virtual General Meetings, Motions #
+#####################################
+
+class VGM(models.Model):
+ """
+ Each year, a Virtual General Meeting is held during which operations at
+ SciPost are discussed. A VGM can be attended by Administrators,
+ Advisory Board members and Editorial Fellows.
+ """
+ start_date = models.DateField()
+ end_date = models.DateField()
+ information = models.TextField(default='')
+
+ def __str__(self):
+ return 'From %s to %s' % (self.start_date.strftime('%Y-%m-%d'),
+ self.end_date.strftime('%Y-%m-%d'))
+
+
+class Feedback(models.Model):
+ """
+ Feedback, suggestion or criticism on any aspect of SciPost.
+ """
+ VGM = models.ForeignKey(VGM, blank=True, null=True)
+ by = models.ForeignKey(Contributor)
+ date = models.DateField()
+ feedback = models.TextField()
+
+ def __str__(self):
+ return '%s: %s' % (self.by, self.feedback[:50])
+
+ def as_li(self):
+ html = ('<div class="Feedback">'
+ '<h3><em>by {{ by }}</em></h3>'
+ '<p>{{ feedback|linebreaks }}</p>'
+ '</div>')
+ context = Context({
+ 'feedback': self.feedback,
+ 'by': '%s %s' % (self.by.user.first_name,
+ self.by.user.last_name)})
+ template = Template(html)
+ return template.render(context)
+
+
+class Nomination(models.Model):
+ """
+ Nomination to an Editorial Fellowship.
+ """
+ VGM = models.ForeignKey(VGM, blank=True, null=True)
+ by = models.ForeignKey(Contributor)
+ date = models.DateField()
+ first_name = models.CharField(max_length=30, default='')
+ last_name = models.CharField(max_length=30, default='')
+ discipline = models.CharField(max_length=20, choices=SCIPOST_DISCIPLINES,
+ default='physics', verbose_name='Main discipline')
+ expertises = ChoiceArrayField(
+ models.CharField(max_length=10, choices=SCIPOST_SUBJECT_AREAS),
+ blank=True, null=True)
+ webpage = models.URLField(default='')
+ nr_A = models.PositiveIntegerField(default=0)
+ in_agreement = models.ManyToManyField(Contributor,
+ related_name='in_agreement_with_nomination', blank=True)
+ nr_N = models.PositiveIntegerField(default=0)
+ in_notsure = models.ManyToManyField(Contributor,
+ related_name='in_notsure_with_nomination', blank=True)
+ nr_D = models.PositiveIntegerField(default=0)
+ in_disagreement = models.ManyToManyField(Contributor,
+ related_name='in_disagreement_with_nomination',
+ blank=True)
+ voting_deadline = models.DateTimeField('voting deadline', default=timezone.now)
+ accepted = models.NullBooleanField()
+
+ def __str__(self):
+ return '%s %s (nominated by %s)' % (self.first_name,
+ self.last_name,
+ self.by)
+
+ def as_li(self):
+ html = ('<div class="Nomination" id="nomination_id{{ nomination_id }}" '
+ 'style="background-color: #eeeeee;">'
+ '<div class="row">'
+ '<div class="col-4">'
+ '<h3><em> {{ name }}</em></h3>'
+ '<p>Nominated by {{ proposer }}</p>'
+ '</div>'
+ '<div class="col-4">'
+ '<p><a href="{{ webpage }}">Webpage</a></p>'
+ '<p>Discipline: {{ discipline }}</p></div>'
+ '<div class="col-4"><p>expertise:<ul>')
+ for exp in self.expertises:
+ html += '<li>%s</li>' % subject_areas_dict[exp]
+ html += '</ul></div></div></div>'
+ context = Context({
+ 'nomination_id': self.id,
+ 'proposer': '%s %s' % (self.by.user.first_name,
+ self.by.user.last_name),
+ 'name': self.first_name + ' ' + self.last_name,
+ 'discipline': disciplines_dict[self.discipline],
+ 'webpage': self.webpage,
+ })
+ template = Template(html)
+ return template.render(context)
+
+ def votes_as_ul(self):
+ template = Template('''
+ <ul class="opinionsDisplay">
+ <li style="background-color: #000099">Agree {{ nr_A }}</li>
+ <li style="background-color: #555555">Abstain {{ nr_N }}</li>
+ <li style="background-color: #990000">Disagree {{ nr_D }}</li>
+ </ul>
+ ''')
+ context = Context({'nr_A': self.nr_A, 'nr_N': self.nr_N, 'nr_D': self.nr_D})
+ return template.render(context)
+
+ def update_votes(self, contributor_id, vote):
+ contributor = get_object_or_404(Contributor, pk=contributor_id)
+ self.in_agreement.remove(contributor)
+ self.in_notsure.remove(contributor)
+ self.in_disagreement.remove(contributor)
+ if vote == 'A':
+ self.in_agreement.add(contributor)
+ elif vote == 'N':
+ self.in_notsure.add(contributor)
+ elif vote == 'D':
+ self.in_disagreement.add(contributor)
+ self.nr_A = self.in_agreement.count()
+ self.nr_N = self.in_notsure.count()
+ self.nr_D = self.in_disagreement.count()
+ self.save()
+
+
+MOTION_CATEGORIES = (
+ ('ByLawAmend', 'Amendments to by-laws'),
+ ('Workflow', 'Editorial workflow improvements'),
+ ('General', 'General'),
+)
+motion_categories_dict = dict(MOTION_CATEGORIES)
+
+
+class Motion(models.Model):
+ """
+ Motion instances are put forward to the Advisory Board and Editorial College
+ and detail suggested changes to rules, procedures etc.
+ They are meant to be voted on at the annual VGM.
+ """
+ category = models.CharField(max_length=10, choices=MOTION_CATEGORIES,
+ default='General')
+ VGM = models.ForeignKey(VGM, blank=True, null=True)
+ background = models.TextField()
+ motion = models.TextField()
+ put_forward_by = models.ForeignKey(Contributor)
+ date = models.DateField()
+ nr_A = models.PositiveIntegerField(default=0)
+ in_agreement = models.ManyToManyField(Contributor,
+ related_name='in_agreement_with_motion', blank=True)
+ nr_N = models.PositiveIntegerField(default=0)
+ in_notsure = models.ManyToManyField(Contributor,
+ related_name='in_notsure_with_motion', blank=True)
+ nr_D = models.PositiveIntegerField(default=0)
+ in_disagreement = models.ManyToManyField(Contributor,
+ related_name='in_disagreement_with_motion',
+ blank=True)
+ voting_deadline = models.DateTimeField('voting deadline', default=timezone.now)
+ accepted = models.NullBooleanField()
+
+ def __str__(self):
+ return self.motion[:32]
+
+ def as_li(self):
+ html = ('<div class="Motion" id="motion_id{{ motion_id }}">'
+ '<h3><em>Motion {{ motion_id }}, put forward by {{ proposer }}</em></h3>'
+ '<h3>Background:</h3><p>{{ background|linebreaks }}</p>'
+ '<h3>Motion:</h3>'
+ '<div class="flex-container"><div class="flex-greybox">'
+ '<p style="background-color: #eeeeee;">{{ motion|linebreaks }}</p>'
+ '</div></div>'
+ '</div>')
+ context = Context({
+ 'motion_id': self.id,
+ 'proposer': '%s %s' % (self.put_forward_by.user.first_name,
+ self.put_forward_by.user.last_name),
+ 'background': self.background,
+ 'motion': self.motion, })
+ template = Template(html)
+ return template.render(context)
+
+ def votes_as_ul(self):
+ template = Template('''
+ <ul class="opinionsDisplay">
+ <li style="background-color: #000099">Agree {{ nr_A }}</li>
+ <li style="background-color: #555555">Abstain {{ nr_N }}</li>
+ <li style="background-color: #990000">Disagree {{ nr_D }}</li>
+ </ul>
+ ''')
+ context = Context({'nr_A': self.nr_A, 'nr_N': self.nr_N, 'nr_D': self.nr_D})
+ return template.render(context)
+
+ def update_votes(self, contributor_id, vote):
+ contributor = get_object_or_404(Contributor, pk=contributor_id)
+ self.in_agreement.remove(contributor)
+ self.in_notsure.remove(contributor)
+ self.in_disagreement.remove(contributor)
+ if vote == 'A':
+ self.in_agreement.add(contributor)
+ elif vote == 'N':
+ self.in_notsure.add(contributor)
+ elif vote == 'D':
+ self.in_disagreement.add(contributor)
+ self.nr_A = self.in_agreement.count()
+ self.nr_N = self.in_notsure.count()
+ self.nr_D = self.in_disagreement.count()
+ self.save()
+
#########
# Lists #
@@ -491,10 +718,9 @@ class List(models.Model):
class Meta:
default_permissions = ['add', 'view', 'change', 'delete']
-
def __str__(self):
- return '%s (owner: %s %s)' % (self.title[:30], self.owner.user.first_name, self.owner.user.last_name)
-
+ return '%s (owner: %s %s)' % (self.title[:30],
+ self.owner.user.first_name, self.owner.user.last_name)
def header(self):
context = Context({'id': self.id, 'title': self.title,
@@ -506,7 +732,6 @@ class List(models.Model):
''')
return template.render(context)
-
def header_as_li(self):
context = Context({'id': self.id, 'title': self.title,
'first_name': self.owner.user.first_name,
@@ -517,7 +742,6 @@ class List(models.Model):
''')
return template.render(context)
-
def contents(self):
context = Context({})
output = '<p>' + self.description + '</p>'
@@ -569,19 +793,18 @@ class Team(models.Model):
class Meta:
default_permissions = ['add', 'view', 'change', 'delete']
-
def __str__(self):
return (self.name + ' (led by ' + self.leader.user.first_name + ' '
+ self.leader.user.last_name + ')')
def header_as_li(self):
- context = Context({'name': self.name,})
+ context = Context({'name': self.name, })
output = ('<li><p>Team {{ name }}, led by ' + self.leader.user.first_name + ' '
+ self.leader.user.last_name + '</p>')
output += '<p>Members: '
if not self.members.all():
output += '(none yet, except for the leader)'
- else :
+ else:
for member in self.members.all():
output += member.user.first_name + ' ' + member.user.last_name + ', '
output += '</p></li>'
@@ -609,9 +832,9 @@ class Graph(models.Model):
class Meta:
default_permissions = ['add', 'view', 'change', 'delete']
-
def __str__(self):
- return '%s (owner: %s %s)' % (self.title[:30], self.owner.user.first_name, self.owner.user.last_name)
+ return '%s (owner: %s %s)' % (self.title[:30],
+ self.owner.user.first_name, self.owner.user.last_name)
def header_as_li(self):
context = Context({'id': self.id, 'title': self.title,
@@ -651,7 +874,6 @@ class Node(models.Model):
class Meta:
default_permissions = ['add', 'view', 'change', 'delete']
-
def __str__(self):
return self.graph.title[:20] + ': ' + self.name[:20]
@@ -678,10 +900,11 @@ class Node(models.Model):
ARC_LENGTHS = [
-# (4, '4'), (8, '8'), (16, '16'), (32, '32'), (64, '64'), (128, '128')
+ # (4, '4'), (8, '8'), (16, '16'), (32, '32'), (64, '64'), (128, '128')
(1, '1'), (2, '2'), (3, '3'), (4, '4'), (5, '5'), (6, '6'), (7, '7'), (8, '8'),
]
+
class Arc(models.Model):
"""
Arc of a graph, linking two nodes.
@@ -695,7 +918,6 @@ class Arc(models.Model):
length = models.PositiveSmallIntegerField(choices=ARC_LENGTHS, default=32)
-
#######################
# Affiliation Objects #
#######################
@@ -745,6 +967,7 @@ class SupportingPartner(models.Model):
def __str__(self):
return self.institution_acronym + ' (' + partner_status_dict[self.status] + ')'
+
SPB_MEMBERSHIP_AGREEMENT_STATUS = (
('Submitted', 'Request submitted by Partner'),
('Pending', 'Sent to Partner, response pending'),
@@ -762,6 +985,7 @@ SPB_MEMBERSHIP_DURATION = (
)
spb_membership_duration_dict = dict(SPB_MEMBERSHIP_DURATION)
+
class SPBMembershipAgreement(models.Model):
"""
Agreement for membership of the Supporting Partners Board.
diff --git a/scipost/templates/scipost/SPB_membership_request.html b/scipost/templates/scipost/SPB_membership_request.html
index 9be4a6c3ed76c2f0c532f86da736a52c798bc0d6..455ce5b04347aeaae62171bcc03432c5f58adc77 100644
--- a/scipost/templates/scipost/SPB_membership_request.html
+++ b/scipost/templates/scipost/SPB_membership_request.html
@@ -32,24 +32,31 @@ $(document).ready(function(){
</div>
</div>
- <p>You can hereby initiate the process to become one of our Supporting Partners.</p>
- <p>After filling this form, SciPost Administration will contact you with a Partnership
- Agreement offer.</p>
- <p><em>Note: you will automatically be considered as the contact person for this Partner.</em></p>
-
- {% if errormessage %}
- <p style="color: red;">{{ errormessage }}</p>
- {% endif %}
-
- <form action="{% url 'scipost:SPB_membership_request' %}" method="post">
- {% csrf_token %}
- <h3>Partner details:</h3>
- {% load crispy_forms_tags %}
- {% crispy SP_form %}
- <h3>Agreement terms:</h3>
- {% crispy membership_form %}
- <input type="submit" value="Submit"/>
- </form>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+ <p>You can hereby initiate the process to become one of our Supporting Partners.</p>
+ <p>Filling in this form does not yet constitute a binding agreement.</p>
+ <p>It simply expresses your interest in considering joining our Supporting Partners Board.</p>
+ <p>After filling this form, SciPost Administration will contact you with a Partnership
+ Agreement offer.</p>
+ <p><em>Note: you will automatically be considered as the contact person for this Partner.</em></p>
+
+ {% if errormessage %}
+ <p style="color: red;">{{ errormessage }}</p>
+ {% endif %}
+
+ <form action="{% url 'scipost:SPB_membership_request' %}" method="post">
+ {% csrf_token %}
+ <h3>Partner details:</h3>
+ {% load crispy_forms_tags %}
+ {% crispy SP_form %}
+ <h3>Agreement terms:</h3>
+ {% crispy membership_form %}
+ <input type="submit" value="Submit"/>
+ </form>
+
+ </div>
+ </div>
</section>
diff --git a/scipost/templates/scipost/VGM_detail.html b/scipost/templates/scipost/VGM_detail.html
new file mode 100644
index 0000000000000000000000000000000000000000..69b5a224772da1497dd1b1040cb97344f42e3f5b
--- /dev/null
+++ b/scipost/templates/scipost/VGM_detail.html
@@ -0,0 +1,352 @@
+{% extends 'scipost/base.html' %}
+
+{% block pagetitle %}: VGM detail{% endblock pagetitle %}
+
+{% load staticfiles %}
+
+{% block bodysup %}
+
+<script>
+$(document).ready(function(){
+
+ $("#submitFeedbackForm").hide();
+ $("#submitFeedbackButton").click( function() {
+ $(this).next("form").toggle();
+ });
+
+ $("#FellowshipListing").hide();
+ $("#FellowshipListingButton").click( function() {
+ $("#FellowshipListing").toggle();
+ });
+
+ $("#submitNominationForm").hide();
+ $("#submitNominationButton").click( function() {
+ $(this).next("form").toggle();
+ });
+
+ $("#submitMotionForm").hide();
+ $("#submitMotionButton").click( function() {
+ $(this).next("form").toggle();
+ });
+
+ $(".submitRemarkForm").hide();
+
+ $(".submitRemarkButton").click( function() {
+ $(this).next("div").toggle();
+ });
+ });
+
+</script>
+
+<section>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h1>SciPost Virtual General Meeting</h1>
+ </div>
+ </div>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+ <h2>On this page:</h2>
+ <ul>
+ <li><a href="#Information">Information message</a></li>
+ <li><a href="#Feedback">Feedback</a></li>
+ <li><a href="#Nominations">Nominations</a></li>
+ <li><a href="#Motions">Motions</a></li>
+ </ul>
+ </div>
+ </div>
+ <hr class="hr12"/>
+</section>
+
+
+<section id="Information">
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h2>Information message from SciPost Administration</h2>
+ </div>
+ </div>
+ <div class="flex-whitebox">
+ {{ VGM_information }}
+ </div>
+ <br/>
+ <div class="flex-whitebox">
+ <h3>Quick bullet points:</h3>
+ <ul>
+ <li>This VGM is scheduled from {{ VGM.start_date|date:'Y-m-d' }} to {{ VGM.end_date|date:'Y-m-d' }}.</li>
+ <li>Your feedback/suggestions/criticisms on any aspect of SciPost are greatly valued. Provide them by filling the <a href="#FeedbackBox">feedback form</a>.</li>
+ <li>Your nominations to the Editorial College are welcome. Simply fill the <a href="#NominationBox">nomination form</a>, and cast your vote on current nominations.</li>
+ <li>For substantial changes, for example to the by-laws, new Motions can be put forward until the end of the meeting using the <a href="#MotionBox">form</a>.</li>
+ <li>Voting on Motions is open until one week after the meeting.</li>
+ <li>You a referred to the <a href="{% url 'scipost:EdCol_by-laws' %}">by-laws</a>, section 2 for further details about the procedures.</li>
+ </ul>
+ </div>
+ <br/>
+ <hr class="hr12"/>
+</section>
+
+<section id="Feedback">
+ <div class="flex-container">
+ <div class="flex-greybox" id="FeedbackBox">
+ <h2>Feedback on SciPost</h2>
+ <button id="submitFeedbackButton">Provide feedback</button>
+ <form id="submitFeedbackForm" action="{% url 'scipost:feedback' VGM_id=VGM.id %}" method="post">
+ {% csrf_token %}
+ {{ feedback_form.as_p }}
+ <input type="submit" value="Submit"/>
+ </form>
+ </div>
+ </div>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h2>General Feedback provided</h2>
+ </div>
+ </div>
+ <div class="row">
+ <div class="col-1"></div>
+ <div class="col-10">
+ <ul>
+ {% for feedback in feedback_received %}
+ <li>{{ feedback.as_li }}</li>
+ <button class="submitRemarkButton" id="remarkButton{{ nomination.id }}">Add a remark on this Feedback</button>
+ <div class="submitRemarkForm" id="remarkForm{{ feedback.id }}">
+ <form action="{% url 'scipost:add_remark_on_feedback' VGM_id=VGM.id feedback_id=feedback.id %}" method="post">
+ {% csrf_token %}
+ {{ remark_form.as_p }}
+ <input type="submit" value="Submit" />
+ </form>
+ </div>
+ {% if feedback.remark_set.all %}
+ <h3>Remarks on this feedback:</h3>
+ <ul>
+ {% for rem in feedback.remark_set.all %}
+ {{ rem.as_li }}
+ {% endfor %}
+ </ul>
+ {% endif %}
+ {% endfor %}
+ </ul>
+ </div>
+ </div>
+ <hr class="hr12"/>
+</section>
+
+<section id="Nominations">
+ <div class="flex-container">
+ <div class="flex-greybox" id="NominationBox">
+ <h2>Nominations to the Editorial College</h2>
+ <button id="submitNominationButton">Nominate an Editorial Fellow candidate</button>
+ <form id="submitNominationForm" action="{% url 'scipost:nominate_Fellow' VGM_id=VGM.id %}" method="post">
+ {% csrf_token %}
+ {{ nomination_form.as_p }}
+ <input type="submit" value="Submit"/>
+ </form>
+ </div>
+ </div>
+ <button id="FellowshipListingButton">View/hide Fellows and Invitations listings</button>
+ <div class="row" id="FellowshipListing">
+ <div class="col-6">
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h3>Current Fellows</h3>
+ </div>
+ </div>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+ <table class="tableofInviteesResponded">
+ {% for Fellow in current_Fellows %}
+ <tr><td>{{ Fellow }}</td><td>{{ Fellow.discipline_as_string }}</td>
+ <td>{{ Fellow.expertises_as_string }}</td></tr>
+ {% endfor %}
+ </table>
+ </div>
+ </div>
+ </div>
+ <div class="col-6">
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h3>Invitations currently outstanding</h3>
+ </div>
+ </div>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+ <table class="tableofInvitees">
+ {% for invitee in pending_inv_Fellows %}
+ <tr><td>{{ invitee.first_name }} {{ invitee.last_name }}</td></tr>
+ {% endfor %}
+ </table>
+ </div>
+ </div>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h3>Invitations which have been turned down</h3>
+ </div>
+ </div>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+ <table class="tableofInviteesDeclined">
+ {% for invitee in declined_inv_Fellows %}
+ <tr><td>{{ invitee.first_name }} {{ invitee.last_name }}</td></tr>
+ {% endfor %}
+ </table>
+ </div>
+ </div>
+ </div>
+ </div>
+
+ {% if nominations %}
+ <div class="row">
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h2>Nominations under consideration</h2>
+ </div>
+ </div>
+ </div>
+ <div class="row">
+ <div class="col-1"></div>
+ <div class="col-10">
+ <ul style="list-style-type: none;">
+ {% for nomination in nominations %}
+ <li>
+ {{ nomination.as_li }}
+ <br/>
+ <div class="opinionsDisplay">
+ <h4>Your opinion on this Nomination (voting deadline: {{ nomination.voting_deadline|date:'y-m-d' }}):</h4>
+ <form action="{% url 'scipost:vote_on_nomination' nomination_id=nomination.id vote='A' %}" method="post">
+ {% csrf_token %}
+ <input type="submit" class="agree" value="Agree {{ nomination.nr_A }} "/>
+ </form>
+ <form action="{% url 'scipost:vote_on_nomination' nomination_id=nomination.id vote='N' %}" method="post">
+ {% csrf_token %}
+ <input type="submit" class="notsure" value="Not sure {{ nomination.nr_N }}"/>
+ </form>
+ <form action="{% url 'scipost:vote_on_nomination' nomination_id=nomination.id vote='D'%}" method="post">
+ {% csrf_token %}
+ <input type="submit" class="disagree" value="Disagree {{ nomination.nr_D }}"/>
+ </form>
+ {% if request.user.contributor in nomination.in_agreement.all %}
+ <strong>(you have voted: Agreed)</strong>
+ {% elif request.user.contributor in nomination.in_notsure.all %}
+ <strong>(you have voted: Not sure)</strong>
+ {% elif request.user.contributor in nomination.in_disagreement.all %}
+ <strong>(you have voted: Disagree)</strong>
+ {% endif %}
+ </div>
+ <br/><br/>
+ <button class="submitRemarkButton" id="remarkButton{{ nomination.id }}">Add a remark on this Nomination</button>
+ <div class="submitRemarkForm" id="remarkForm{{ nomination.id }}">
+ <form action="{% url 'scipost:add_remark_on_nomination' VGM_id=VGM.id nomination_id=nomination.id %}" method="post">
+ {% csrf_token %}
+ {{ remark_form.as_p }}
+ <input type="submit" value="Submit" />
+ </form>
+ </div>
+ {% if nomination.remark_set.all %}
+ <h3>Remarks on this nomination:</h3>
+ <ul>
+ {% for rem in nomination.remark_set.all %}
+ {{ rem.as_li }}
+ {% endfor %}
+ </ul>
+ {% endif %}
+ <hr class="hr6"/>
+ <br/>
+ </li>
+ {% endfor %}
+ </ul>
+ </div>
+ </div>
+ {% endif %}
+
+ <hr class="hr12"/>
+
+</section>
+
+<section id="Motions">
+ <div class="flex-container">
+ <div class="flex-greybox" id="MotionBox">
+ <h2>Submit a new Motion</h2>
+ <button id="submitMotionButton">Put a new Motion forward</button>
+ <form id="submitMotionForm" action="{% url 'scipost:put_motion_forward' VGM_id=VGM.id %}" method="post">
+ {% csrf_token %}
+ {% load crispy_forms_tags %}
+ {% crispy motion_form %}
+ </form>
+ </div>
+ </div>
+
+ <div class="row">
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h2>Motions under consideration</h2>
+ </div>
+ </div>
+ </div>
+ {% for key, val in motion_categories_dict.items %}
+ <div class="row">
+ <div class="col-1"></div>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h3>{{ val }}:</h3>
+ </div>
+ </div>
+ <div class="col-1"></div>
+ <div class="col-10">
+ <ul>
+ {% for motion in VGM.motion_set.all %}
+ {% if motion.category == key %}
+ <li>
+ {{ motion.as_li }}
+ <br/>
+ <div class="opinionsDisplay">
+ <h4>Your opinion on this Motion (voting deadline: {{ motion.voting_deadline|date:'y-m-d' }}):</h4>
+ <form action="{% url 'scipost:vote_on_motion' motion_id=motion.id vote='A' %}" method="post">
+ {% csrf_token %}
+ <input type="submit" class="agree" value="Agree {{ motion.nr_A }} "/>
+ </form>
+ <form action="{% url 'scipost:vote_on_motion' motion_id=motion.id vote='N' %}" method="post">
+ {% csrf_token %}
+ <input type="submit" class="notsure" value="Not sure {{ motion.nr_N }}"/>
+ </form>
+ <form action="{% url 'scipost:vote_on_motion' motion_id=motion.id vote='D'%}" method="post">
+ {% csrf_token %}
+ <input type="submit" class="disagree" value="Disagree {{ motion.nr_D }}"/>
+ </form>
+ {% if request.user.contributor in motion.in_agreement.all %}
+ <strong>(you have voted: Agreed)</strong>
+ {% elif request.user.contributor in motion.in_notsure.all %}
+ <strong>(you have voted: Not sure)</strong>
+ {% elif request.user.contributor in motion.in_disagreement.all %}
+ <strong>(you have voted: Disagree)</strong>
+ {% endif %}
+ </div>
+ <br/><br/>
+ <button class="submitRemarkButton" id="remarkButton{{ motion.id }}">Add a remark on this Motion</button>
+ <div class="submitRemarkForm" id="remarkForm{{ motion.id }}">
+ <form action="{% url 'scipost:add_remark_on_motion' motion_id=motion.id %}" method="post">
+ {% csrf_token %}
+ {{ remark_form.as_p }}
+ <input type="submit" value="Submit" />
+ </form>
+ </div>
+ {% if motion.remark_set.all %}
+ <h3>Remarks on this motion:</h3>
+ <ul>
+ {% for rem in motion.remark_set.all %}
+ {{ rem.as_li }}
+ {% endfor %}
+ </ul>
+ {% endif %}
+ <hr class="hr6"/>
+ <br/>
+ </li>
+ {% endif %}
+ {% endfor %}
+ </ul>
+ </div>
+ </div>
+ {% endfor %}
+
+</section>
+
+
+{% endblock bodysup %}
diff --git a/scipost/templates/scipost/VGMs.html b/scipost/templates/scipost/VGMs.html
new file mode 100644
index 0000000000000000000000000000000000000000..493eefde5df67e226514048c5410da811aae0b57
--- /dev/null
+++ b/scipost/templates/scipost/VGMs.html
@@ -0,0 +1,26 @@
+{% extends 'scipost/base.html' %}
+
+{% block pagetitle %}: VGMs{% endblock pagetitle %}
+
+{% load staticfiles %}
+
+{% block bodysup %}
+
+
+<section>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h1>SciPost Virtual General Meetings</h1>
+ </div>
+ </div>
+
+ <ul>
+ {% for VGM in VGM_list %}
+ <li><a href="{% url 'scipost:VGM_detail' VGM_id=VGM.id %}">{{ VGM }}</a></li>
+ {% endfor %}
+ </ul>
+
+</section>
+
+
+{% endblock bodysup %}
diff --git a/scipost/templates/scipost/about.html b/scipost/templates/scipost/about.html
index 6b89228b362007b8563070cd70cde2770c69569b..415843cfa14a607a891f3a627577f736e9bfbaef 100644
--- a/scipost/templates/scipost/about.html
+++ b/scipost/templates/scipost/about.html
@@ -118,7 +118,7 @@
<div class="flex-container">
<div class="flex-whitebox">
<ul>
- <li>Prof. <a href="http://www.nwo.nl/en/about-nwo/organisation/governing+board/Jos+Engelen">J. J. Engelen</a><br/>(Chairman NWO;<br/> U. van Amsterdam)</li>
+ <li>Prof. <a href="http://www.nikhef.nl/~h02/">J. J. Engelen</a><br/>(U. van Amsterdam)</li>
<li>Prof. <a href="https://www.asc.ox.ac.uk/person/18">P. Fendley</a><br/>(Oxford; <a href="https://www.asc.ox.ac.uk/all-souls-college-oxford">All Souls College</a>)</li>
<li>Prof. <a href="http://www.ru.nl/highenergyphysics/ehep/persons/sijbrand_de_jong/">S. J. de Jong</a><br/>(Radboud Univ. Nijmegen,<br/>President CERN Council)</li>
</ul>
diff --git a/scipost/templates/scipost/personal_page.html b/scipost/templates/scipost/personal_page.html
index 01045558655e17da7f9d6bdd07b11819aba58d26..72627b79c85afc445d8f0f003afd6e17a5c1bc11 100644
--- a/scipost/templates/scipost/personal_page.html
+++ b/scipost/templates/scipost/personal_page.html
@@ -282,6 +282,12 @@
<li><a href="{% url 'submissions:vet_submitted_reports' %}">Vet submitted Reports</a> ({{ nr_reports_to_vet }})</li>
{% endif %}
</ul>
+ {% if perms.scipost.can_attend_VGMs %}
+ <h3>Virtual General Meetings</h3>
+ <ul>
+ <li><a href="{% url 'scipost:VGMs' %}">List of VGMs</a></li>
+ </ul>
+ {% endif %}
</div>
{% if request.user|is_in_group:'Editorial Administrators' or request.user|is_in_group:'Editorial College' %}
@@ -293,6 +299,7 @@
<h3>Submissions assignments</h3>
<ul>
{% if perms.scipost.can_view_pool %}
+ <li><a href="{% url 'submissions:assignments' %}">Your assignments</a></li>
<li><a href="{% url 'scipost:Fellow_activity_overview' %}">View assignments overview</a></li>
{% endif %}
{% if perms.scipost.can_assign_submissions %}
diff --git a/scipost/templates/scipost/supporting_partners.html b/scipost/templates/scipost/supporting_partners.html
index 4c7ab5bf73a1735fbcf66cdf450bba5420d57ab9..f5ced193e5cf7364cf6501cbbdf892a32e365e58 100644
--- a/scipost/templates/scipost/supporting_partners.html
+++ b/scipost/templates/scipost/supporting_partners.html
@@ -4,22 +4,133 @@
{% load staticfiles %}
+{% load scipost_extras %}
+
{% block bodysup %}
<section>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h1>SciPost Supporting Partners</h1>
+ </div>
+ </div>
+
+ <div class="flex-container">
+ <div class="flex-whitebox">
+
+ <h3>Openness at strictly minimal cost: the role of professional academics</h3>
+ <p>A fundamental principle underlining all of SciPost’s activities is openness. This means in particular that SciPost guarantees free online access to all publications in all its Journals (free for readers; all articles are published under the terms of a Creative Commons license (most commonly CC-BY)), and does not charge any article processing fees for publishing (free for authors). All editorial activities are performed by professional academics as part of their normal professional duties: contributors to SciPost are demonstrably dedicated to serving their community, and to realizing the dream of true openness in scientific publishing. SciPost thus achieves the highest possible standards of academic quality and open accessibility while maintaining costs at the lowest achievable level.</p>
+
+ <h3>Financing and sustainability: the role of institutional backers</h3>
+ <p>Besides relying on the dedicated service of professional scientists for many of its day-to-day operations, SciPost must additionally rely on institutional backers for sustaining its professional-level publishing facilities and other activities. This backing is sought primarily from the organizations which are positively impacted by its activities, directly or indirectly: (inter)national funding agencies, universities, national/university/research libraries, academic consortia, governments and ministries, foundations, benefactors and further interested parties. This financial backing cannot take the form of article processing charges or journal subscriptions, due to SciPost’s operating principles: rather, Supporting Partners provide operating funds to SciPost, these funds being pooled in order to cover maintenance and operation of the web infrastructure at SciPost.org, administration of all site-related activities, production of publications in SciPost Journals and development of new publishing-related services for the international scientific community.</p>
+
+ </div>
+ </div>
+
+
+
<div class="flex-container">
<div class="flex-greybox">
<h1>Supporting Partners Board</h1>
</div>
</div>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+
+ <p>We hereby cordially invite interested parties who are supportive of SciPost's mission to join the SciPost Supporting Partners Board by signing a <a href="{% static 'scipost/SPB/SciPost_Supporting_Partner_Agreement.pdf' %}">Partner Agreement</a>.</p>
+
+ <p>Prospective partners can initiate the process leading to Membership by filling the <a href="{% url 'scipost:SPB_membership_request' %}">online request form</a>.</p>
+
+ <br/>
+ <p>The <a href="{% static 'scipost/SPB/SciPost_Supporting_Partner_Agreement.pdf' %}">Partner Agreement</a> itself contains a detailed presentation of the Foundation, its activities and financial aspects. What follows is a summary of the most important points.</p>
+
+ <br/>
<p>The set of all Supporting Partners forms the SciPost Supporting Partners Board (SPB). Acting as a representative body, the SPB’s purpose is to provide the main financial backing without which SciPost could not continue carrying out its mission, to counsel it in all its operations and to help determine the initiative’s development priorities.</p>
- <p>Interested parties can join the SciPost Supporting Partners Board by signing a <a href="{% static 'scipost/SPB/SciPost_Supporting_Partner_Agreement.pdf' %}">Partner Agreement</a>.</p>
+ <p>The SPB has a yearly virtual general meeting, organized and chaired by a representative of the SciPost Foundation. During this meeting, SPB-related topics are discussed, recommendations to the SciPost Foundation can be put forward and voted on by Partners, and general issues on any of SciPost’s activities can be discussed.</p>
+
+
+ <h3>Types of Partners</h3>
+ <p>Supporting Partners can for example be:
+ <ul>
+ <li>International/national funding agencies</li>
+ <li>National/university/research libraries</li>
+ <li>Consortia (of e.g. universities or libraries)</li>
+ <li>Government (through e.g. education/science ministries)</li>
+ <li>Foundations</li>
+ <li>Benefactors of any other type.</li>
+ </ul>
+ </p>
+
+ <h3>Partnership benefits</h3>
+ <p>All funds originating from Supporting Partners are used to provide services to the academic community as a whole: SciPost operates in a completely open fashion, and the fulfillment of the Foundation’s mission benefits academics worldwide, without any distinction.</p>
+ <p>Partnership nonetheless provides Partners with a number of additional benefits as compared to non-Partner parties. SciPost agrees to provide its Partners with:
+ <ol>
+ <li>A seat on the SciPost Supporting Partners Board, including access to yearly meetings, with voting rights proportional to financial contribution (up to a maximum of 20% of all votes for any individual Partner).</li>
+ <li>Inclusion in the online listing of Supporting Partners on the SciPost website.</li>
+ <li>Exclusive ability to feed the Partner’s institutional theses database to the SciPost Theses database, for inclusion in the Theses part of the portal.</li>
+ <li>Access to the SciPost metadata API (providing among others means to generate yearly metadata summaries relating to SciPost publications for each Contributor employed by the Partner).</li>
+ <li>Exclusive access to further online tools planned by SciPost during their development stage. The SPB as a whole can provide feedback and request specific features.</li>
+ </ol>
+ </p>
- <p>Membership can be requested by filling the <a href="{% url 'scipost:SPB_membership_request' %}">online request form</a>.</p>
+ <h3>Financial contribution</h3>
+ <p>For the financial year 2017, the contributions are set to yearly amounts of:
+ <table>
+ <tr>
+ <td>(Inter)national funding agency:</td><td> </td>
+ <td>size-dependent tailored agreement</td>
+ </tr>
+ <tr>
+ <td>University/library:</td><td> </td>
+ <td>€1000 (base; more is greatly appreciated)</td>
+ </tr>
+ <tr>
+ <td>National consortium of universities/libraries:</td><td> </td>
+ <td>10% bulk discount on the above<br/>(e.g. €3600 for 4 universities)</td>
+ </tr>
+ <tr>
+ <td>Foundations/benefactors:</td><td> </td>
+ <td>(Partner-set amount of at least €500)</td>
+ </tr>
+ </table>
+ <p>Note that if the consortium itself is not a legal entity, each individual member must sign a separate Agreement.</p>
+ <p>All amounts are exclusive of VAT, which will be payable by the Partner where applicable.</p>
+
+ <p><strong>Sustainability - </strong> This norm allows sustainable functioning of SciPost under the expectation that individual institutions be associated to between two and three full publications per year on average (computed using authorship fractions). A Partner who is associated to more authorships and/or who generally recognizes the value of SciPost’s activities, is of course welcome to contribute more.</p>
+ <p><strong>Donations - </strong>Contributions of less than €500 per year are treated as incidental donations and do not lead to the obtention of Partner benefits.</p>
+ <p>Note that SciPost has been designated as a Public Benefit Organisation (PBO; in Dutch: Algemeen Nut Beogende Instelling, ANBI) by the Dutch Tax Administration. Natural and legal persons making donations to a PBO may deduct their gifts from their Dutch income tax or corporate income tax (see the PBO page of the Dutch Tax Administration).</p>
+
+ <h3>Activation procedure</h3>
+ <p>In order to become a Supporting Partner, one must:
+ <ul>
+ <li>Fill in the online <a href="{% url 'scipost:SPB_membership_request' %}">membership request form</a> (the form must be filled in by a registered Contributor, employed by or associated to the prospective Partner and acting as an authorized agent for the latter; personal contact details of this person will be treated confidentially).</li>
+ <li>Wait for the email response from the SciPost administration, containing a Partnership Agreement offer including detailed terms (start date, duration, financial contribution).</li>
+ <li>Email a scan of the signed copy of the Partnership Agreement to SciPost.</li>
+ <li>Proceed with the payment of the financial contribution, following invoicing from the SciPost Foundation.</li>
+ </ul>
+ </p>
+
+ </div>
+ </div>
+</section>
+
+{% if request.user|is_in_group:'Editorial Administrators' %}
+<section>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h1>Prospective Partners</h1>
+ </div>
+ </div>
+ <ul>
+ {% for agreement in prospective_agreements %}
+ <li>{{ agreement }}</li>
+ {% endfor %}
+ </ul>
</section>
+{% endif %}
{% endblock bodysup %}
diff --git a/scipost/urls.py b/scipost/urls.py
index facaec8388b3c35a219c831f1d02871fb6cd4338..e3b8c573147bbafd6e2541cce29bbeee3d68279e 100644
--- a/scipost/urls.py
+++ b/scipost/urls.py
@@ -172,6 +172,28 @@ urlpatterns = [
views.Fellow_activity_overview,
name='Fellow_activity_overview'),
+ ############################
+ # Virtual General Meetings #
+ ############################
+ url(r'^VGMs$', views.VGMs, name='VGMs'),
+ url(r'^VGM/(?P<VGM_id>[0-9]+)/$', views.VGM_detail, name='VGM_detail'),
+ url(r'^feedback/(?P<VGM_id>[0-9]+)$',
+ views.feedback, name='feedback'),
+ url(r'^add_remark_on_feedback/(?P<VGM_id>[0-9]+)/(?P<feedback_id>[0-9]+)$',
+ views.add_remark_on_feedback, name='add_remark_on_feedback'),
+ url(r'^nominate_Fellow/(?P<VGM_id>[0-9]+)$',
+ views.nominate_Fellow, name='nominate_Fellow'),
+ url(r'^add_remark_on_nomination/(?P<VGM_id>[0-9]+)/(?P<nomination_id>[0-9]+)$',
+ views.add_remark_on_nomination, name='add_remark_on_nomination'),
+ url(r'^vote_on_nomination/(?P<nomination_id>[0-9]+)/(?P<vote>[AND])$',
+ views.vote_on_nomination, name='vote_on_nomination'),
+ url(r'^put_motion_forward/(?P<VGM_id>[0-9]+)$',
+ views.put_motion_forward, name='put_motion_forward'),
+ url(r'^add_remark_on_motion/(?P<motion_id>[0-9]+)$',
+ views.add_remark_on_motion, name='add_remark_on_motion'),
+ url(r'^vote_on_motion/(?P<motion_id>[0-9]+)/(?P<vote>[AND])$',
+ views.vote_on_motion, name='vote_on_motion'),
+
################
# Publications #
################
diff --git a/scipost/utils.py b/scipost/utils.py
index 0c7a0a6d25ecf1b8f805f2a85b08263306c7b779..bac564998baf16da8d187141d2d65d5c12214b30 100644
--- a/scipost/utils.py
+++ b/scipost/utils.py
@@ -4,11 +4,11 @@ import random
import string
from django.contrib.auth.models import User
-from django.core.mail import EmailMessage, EmailMultiAlternatives
+from django.core.mail import EmailMultiAlternatives
from django.template import Context, Template
from django.utils import timezone
-from .models import *
+from .models import Contributor, DraftInvitation, RegistrationInvitation, title_dict
SCIPOST_SUMMARY_FOOTER = (
@@ -74,8 +74,8 @@ EMAIL_UNSUBSCRIBE_LINK_HTML = (
'<a href="https://scipost.org/update_personal_data">updating your personal data</a>.</p>'
)
-class Utils(object):
+class Utils(object):
@classmethod
def load(cls, dict):
for var_name in dict:
@@ -118,25 +118,25 @@ class Utils(object):
@classmethod
def create_and_save_contributor(cls, invitation_key):
- user = User.objects.create_user (
- first_name = cls.form.cleaned_data['first_name'],
- last_name = cls.form.cleaned_data['last_name'],
- email = cls.form.cleaned_data['email'],
- username = cls.form.cleaned_data['username'],
- password = cls.form.cleaned_data['password']
+ user = User.objects.create_user(
+ first_name=cls.form.cleaned_data['first_name'],
+ last_name=cls.form.cleaned_data['last_name'],
+ email=cls.form.cleaned_data['email'],
+ username=cls.form.cleaned_data['username'],
+ password=cls.form.cleaned_data['password']
)
# Set to inactive until activation via email link
user.is_active = False
user.save()
- contributor = Contributor (
+ contributor = Contributor(
user=user,
invitation_key=invitation_key,
- title = cls.form.cleaned_data['title'],
- orcid_id = cls.form.cleaned_data['orcid_id'],
- country_of_employment = cls.form.cleaned_data['country_of_employment'],
- address = cls.form.cleaned_data['address'],
- affiliation = cls.form.cleaned_data['affiliation'],
- personalwebpage = cls.form.cleaned_data['personalwebpage'],
+ title=cls.form.cleaned_data['title'],
+ orcid_id=cls.form.cleaned_data['orcid_id'],
+ country_of_employment=cls.form.cleaned_data['country_of_employment'],
+ address=cls.form.cleaned_data['address'],
+ affiliation=cls.form.cleaned_data['affiliation'],
+ personalwebpage=cls.form.cleaned_data['personalwebpage'],
)
contributor.save()
Utils.load({'contributor': contributor})
@@ -179,7 +179,6 @@ class Utils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost registration request received', email_text,
'SciPost registration <registration@scipost.org>',
@@ -191,31 +190,31 @@ class Utils(object):
@classmethod
def create_draft_invitation(cls):
- invitation = DraftInvitation (
- title = cls.form.cleaned_data['title'],
- first_name = cls.form.cleaned_data['first_name'],
- last_name = cls.form.cleaned_data['last_name'],
- email = cls.form.cleaned_data['email'],
- invitation_type = cls.form.cleaned_data['invitation_type'],
- cited_in_submission = cls.form.cleaned_data['cited_in_submission'],
- cited_in_publication = cls.form.cleaned_data['cited_in_publication'],
- drafted_by = cls.contributor,
+ invitation = DraftInvitation(
+ title=cls.form.cleaned_data['title'],
+ first_name=cls.form.cleaned_data['first_name'],
+ last_name=cls.form.cleaned_data['last_name'],
+ email=cls.form.cleaned_data['email'],
+ invitation_type=cls.form.cleaned_data['invitation_type'],
+ cited_in_submission=cls.form.cleaned_data['cited_in_submission'],
+ cited_in_publication=cls.form.cleaned_data['cited_in_publication'],
+ drafted_by=cls.contributor,
)
invitation.save()
@classmethod
def create_invitation(cls):
- invitation = RegistrationInvitation (
- title = cls.form.cleaned_data['title'],
- first_name = cls.form.cleaned_data['first_name'],
- last_name = cls.form.cleaned_data['last_name'],
- email = cls.form.cleaned_data['email'],
- invitation_type = cls.form.cleaned_data['invitation_type'],
- cited_in_submission = cls.form.cleaned_data['cited_in_submission'],
- cited_in_publication = cls.form.cleaned_data['cited_in_publication'],
- invited_by = cls.contributor,
- message_style = cls.form.cleaned_data['message_style'],
- personal_message = cls.form.cleaned_data['personal_message'],
+ invitation = RegistrationInvitation(
+ title=cls.form.cleaned_data['title'],
+ first_name=cls.form.cleaned_data['first_name'],
+ last_name=cls.form.cleaned_data['last_name'],
+ email=cls.form.cleaned_data['email'],
+ invitation_type=cls.form.cleaned_data['invitation_type'],
+ cited_in_submission=cls.form.cleaned_data['cited_in_submission'],
+ cited_in_publication=cls.form.cleaned_data['cited_in_publication'],
+ invited_by=cls.contributor,
+ message_style=cls.form.cleaned_data['message_style'],
+ personal_message=cls.form.cleaned_data['personal_message'],
)
Utils.load({'invitation': invitation})
@@ -246,7 +245,7 @@ class Utils(object):
email_text += ('Reminder: Invitation to SciPost\n'
'-------------------------------\n\n')
email_text_html += ('<strong>Reminder: Invitation to SciPost</strong>'
- '<br/><hr/><br/>')
+ '<br/><hr/><br/>')
if cls.invitation.invitation_type == 'F':
email_text += 'RE: Invitation to join the Editorial College of SciPost\n\n'
email_text_html += ('<strong>RE: Invitation to join the Editorial College '
@@ -262,7 +261,7 @@ class Utils(object):
email_text += cls.invitation.first_name
email_text_html += '{{ first_name }}'
email_context['first_name'] = cls.invitation.first_name
- email_text += ',\n\n'
+ email_text += ',\n\n'
email_text_html += ',<br/>'
if len(cls.invitation.personal_message) > 3:
email_text += cls.invitation.personal_message + '\n\n'
@@ -296,11 +295,6 @@ class Utils(object):
'useful to your work as a professional scientist.'
'\n\nMany thanks in advance for taking a few minutes to look into it,'
'\n\nOn behalf of the SciPost Foundation,\n\n'
- #'Prof. dr Jean-Sébastien Caux\n---------------------------------------------'
- #'\nInstitute for Theoretical Physics\nUniversity of Amsterdam\nScience Park 904'
- #'\n1098 XH Amsterdam\nThe Netherlands\n'
- #'---------------------------------------------\ntel.: +31 (0)20 5255775'
- #'\nfax: +31 (0)20 5255778\n---------------------------------------------'
+ signature + '\n'
)
@@ -378,7 +372,6 @@ class Utils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: refereeing request (and registration invitation)', email_text,
'SciPost Registration <registration@scipost.org>',
@@ -417,10 +410,8 @@ class Utils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: invitation', email_text,
- #'J.-S. Caux <jscaux@scipost.org>',
'SciPost registration <registration@scipost.org>',
[cls.invitation.email],
cc=[cls.invitation.invited_by.user.email],
@@ -456,10 +447,8 @@ class Utils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: invitation', email_text,
- #'J.-S. Caux <jscaux@scipost.org>',
'SciPost registration <registration@scipost.org>',
[cls.invitation.email],
cc=[cls.invitation.invited_by.user.email],
@@ -479,10 +468,8 @@ class Utils(object):
email_text_html += summary_text_html + '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: invitation', email_text,
- #'J.-S. Caux <jscaux@scipost.org>',
'SciPost registration <registration@scipost.org>',
[cls.invitation.email],
cc=[cls.invitation.invited_by.user.email],
@@ -640,7 +627,6 @@ class Utils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost registration invitation', email_text,
'J-S Caux <jscaux@scipost.org>',
@@ -650,11 +636,9 @@ class Utils(object):
reply_to=['registration@scipost.org'])
emailmessage.attach_alternative(html_version, 'text/html')
-
# This function is now for all invitation types:
emailmessage.send(fail_silently=False)
-
@classmethod
def send_citation_notification_email(cls):
"""
@@ -666,7 +650,7 @@ class Utils(object):
email_text_html = 'Dear {{ title }} {{ last_name }}'
email_context['title'] = title_dict[cls.notification.contributor.title]
email_context['last_name'] = cls.notification.contributor.user.last_name
- email_text += ',\n\n'
+ email_text += ',\n\n'
email_text_html += ',<br/>'
if cls.notification.cited_in_publication:
email_text += (
diff --git a/scipost/views.py b/scipost/views.py
index c3029a670b2f78cd617e4f5e1b086f4b79e6213e..78635541dc0746e2cb539ba7308640f21686acfa 100644
--- a/scipost/views.py
+++ b/scipost/views.py
@@ -8,29 +8,41 @@ from django.utils import timezone
from django.shortcuts import get_object_or_404, render
from django.contrib.auth import authenticate, login, logout
from django.contrib.auth.decorators import login_required
-from django.contrib.auth.models import User, Group, Permission
+from django.contrib.auth.models import Group
from django.contrib.auth.views import password_reset, password_reset_confirm
from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist, PermissionDenied
from django.core import mail
from django.core.mail import EmailMessage, EmailMultiAlternatives
from django.core.paginator import Paginator, EmptyPage, PageNotAnInteger
from django.core.urlresolvers import reverse
-from django.http import HttpResponse, HttpResponseRedirect, JsonResponse
+from django.db.models import Q
+from django.http import HttpResponseRedirect, JsonResponse
from django.shortcuts import redirect
-from django.template import Context, RequestContext, Template
+from django.template import Context, Template
from django.utils.http import is_safe_url
-from django.views.decorators.csrf import csrf_protect
-from django.db.models import Avg
from guardian.decorators import permission_required
from guardian.decorators import permission_required_or_403
from guardian.shortcuts import assign_perm
-from .models import *
-from .forms import *
-
-from .global_methods import *
-from .utils import *
+from .constants import SCIPOST_SUBJECT_AREAS
+from .models import Contributor, CitationNotification, UnavailabilityPeriod,\
+ DraftInvitation, RegistrationInvitation, NewsItem,\
+ List, Team, Graph, Node, Arc,\
+ title_dict, SciPost_from_addresses_dict,\
+ AuthorshipClaim, SupportingPartner, SPBMembershipAgreement,\
+ VGM, Feedback, Nomination, Remark, Motion, motion_categories_dict
+from .forms import AuthenticationForm, DraftInvitationForm, UnavailabilityPeriodForm,\
+ RegistrationForm, RegistrationInvitationForm, AuthorshipClaimForm,\
+ ModifyPersonalMessageForm, SearchForm, VetRegistrationForm, reg_ref_dict,\
+ UpdatePersonalDataForm, UpdateUserDataForm, PasswordChangeForm,\
+ EmailGroupMembersForm, EmailParticularForm, SendPrecookedEmailForm,\
+ CreateListForm, CreateTeamForm,\
+ AddTeamMemberForm, CreateGraphForm,\
+ ManageTeamsForm, CreateNodeForm, CreateArcForm,\
+ SupportingPartnerForm, SPBMembershipForm,\
+ FeedbackForm, MotionForm, NominationForm, RemarkForm
+from .utils import Utils, EMAIL_FOOTER, SCIPOST_SUMMARY_FOOTER, SCIPOST_SUMMARY_FOOTER_HTML
from commentaries.models import Commentary
from commentaries.forms import CommentarySearchForm
@@ -51,12 +63,15 @@ from theses.forms import ThesisLinkSearchForm
def is_registered(user):
return user.groups.filter(name='Registered Contributors').exists()
+
def is_SP_Admin(user):
return user.groups.filter(name='SciPost Administrators').exists()
+
def is_MEC(user):
return user.groups.filter(name='Editorial College').exists()
+
def is_VE(user):
return user.groups.filter(name='Vetting Editors').exists()
@@ -69,6 +84,7 @@ def normalize_query(query_string,
""" Splits a query string in individual keywords, keeping quoted words together. """
return [normspace(' ', (t[0] or t[1]).strip()) for t in findterms(query_string)]
+
def get_query(query_string, search_fields):
""" Returns a query, namely a combination of Q objects. """
query = None
@@ -110,14 +126,12 @@ def documentsSearchResults(query):
publication_query,
).order_by('-publication_date')
commentary_search_queryset = Commentary.objects.filter(
- #commentary_search_list = Commentary.objects.filter(
commentary_query,
vetted=True,
).order_by('-pub_date')
submission_search_queryset = Submission.objects.filter(
- #submission_search_list = Submission.objects.filter(
submission_query,
- ).exclude(status__in=SUBMISSION_STATUS_PUBLICLY_UNLISTED
+ ).exclude(status__in=SUBMISSION_STATUS_PUBLICLY_UNLISTED,
).order_by('-submission_date')
thesislink_search_list = ThesisLink.objects.filter(
thesislink_query,
@@ -129,9 +143,7 @@ def documentsSearchResults(query):
).order_by('-date_submitted')
context = {'publication_search_queryset': publication_search_queryset,
'commentary_search_queryset': commentary_search_queryset,
- #'commentary_search_list': commentary_search_list,
'submission_search_queryset': submission_search_queryset,
- #'submission_search_list': submission_search_list,
'thesislink_search_list': thesislink_search_list,
'comment_search_list': comment_search_list}
return context
@@ -152,7 +164,7 @@ def search(request):
context = {}
if 'publication_search_queryset' in context:
- publication_search_list_paginator = Paginator (context['publication_search_queryset'], 10)
+ publication_search_list_paginator = Paginator(context['publication_search_queryset'], 10)
publication_search_list_page = request.GET.get('publication_search_list_page')
try:
publication_search_list = publication_search_list_paginator.page(
@@ -165,7 +177,7 @@ def search(request):
context['publication_search_list'] = publication_search_list
if 'commentary_search_queryset' in context:
- commentary_search_list_paginator = Paginator (context['commentary_search_queryset'], 10)
+ commentary_search_list_paginator = Paginator(context['commentary_search_queryset'], 10)
commentary_search_list_page = request.GET.get('commentary_search_list_page')
try:
commentary_search_list = commentary_search_list_paginator.page(
@@ -178,7 +190,7 @@ def search(request):
context['commentary_search_list'] = commentary_search_list
if 'submission_search_queryset' in context:
- submission_search_list_paginator = Paginator (context['submission_search_queryset'], 10)
+ submission_search_list_paginator = Paginator(context['submission_search_queryset'], 10)
submission_search_list_page = request.GET.get('submission_search_list_page')
try:
submission_search_list = submission_search_list_paginator.page(
@@ -210,6 +222,7 @@ def index(request):
}
return render(request, 'scipost/index.html', context)
+
###############
# Information
###############
@@ -218,11 +231,13 @@ def base(request):
""" Skeleton for pages, used in template inheritance """
return render(request, 'scipost/base.html')
+
def news(request):
newsitems = NewsItem.objects.all().order_by('-date')
context = {'newsitems': newsitems}
return render(request, 'scipost/news.html', context)
+
def feeds(request):
context = {'subject_areas_physics': SCIPOST_SUBJECT_AREAS[0][1]}
return render(request, 'scipost/feeds.html', context)
@@ -247,7 +262,8 @@ def register(request):
{'form': form, 'errormessage': 'This username is already in use'})
if Utils.email_already_taken():
return render(request, 'scipost/register.html',
- {'form': form, 'errormessage': 'This email address is already in use'})
+ {'form': form,
+ 'errormessage': 'This email address is already in use'})
Utils.create_and_save_contributor('')
Utils.send_registration_email()
# If this email was associated to an invitation, mark it as responded to
@@ -265,7 +281,8 @@ def register(request):
invitation_to_delete.delete()
context = {'ack_header': 'Thanks for registering to SciPost.',
'ack_message': ('You will receive an email with a link to verify '
- 'your email address. Please visit this link within 48 hours. '
+ 'your email address. '
+ 'Please visit this link within 48 hours. '
'Your credentials will thereafter be verified. '
'If your registration is vetted through by the '
'administrators, you will be enabled to contribute.'),
@@ -291,9 +308,9 @@ def invitation(request, key):
Utils.load({'form': form})
if form.is_valid():
if Utils.password_mismatch():
- return render(request, 'scipost/register.html',
- {'form': form, 'invited': True, 'key': key,
- 'errormessage': 'Your passwords must match'})
+ return render(request, 'scipost/register.html', {
+ 'form': form, 'invited': True, 'key': key,
+ 'errormessage': 'Your passwords must match'})
if Utils.username_already_taken():
return render(request, 'scipost/register.html',
{'form': form, 'invited': True, 'key': key,
@@ -308,7 +325,8 @@ def invitation(request, key):
Utils.send_registration_email()
context = {'ack_header': 'Thanks for registering to SciPost.',
'ack_message': ('You will receive an email with a link to verify '
- 'your email address. Please visit this link within 48 hours. '
+ 'your email address. '
+ 'Please visit this link within 48 hours. '
'Your credentials will thereafter be verified. '
'If your registration is vetted through by the '
'administrators, you will be enabled to contribute.'),
@@ -329,30 +347,27 @@ def invitation(request, key):
welcome_message = ('Welcome, ' + title_dict[invitation.title] + ' '
+ invitation.last_name + ', and thanks in advance for '
'registering (by completing this form)')
- return render(request, 'scipost/register.html',
- {'form': form, 'invited': True, 'key': key,
- 'errormessage': errormessage, 'welcome_message': welcome_message})
+ return render(request, 'scipost/register.html', {
+ 'form': form, 'invited': True, 'key': key,
+ 'errormessage': errormessage, 'welcome_message': welcome_message})
context = {'errormessage': errormessage}
return render(request, 'scipost/accept_invitation_error.html', context)
-
def activation(request, key):
"""
After registration, an email verification link is sent.
Once clicked, the account is activated.
"""
contributor = get_object_or_404(Contributor, activation_key=key)
- if contributor.user.is_active == False:
+ if not contributor.user.is_active:
if timezone.now() > contributor.key_expires:
- id_user = contributor.user.id
context = {'oldkey': key}
return render(request, 'scipost/request_new_activation_link.html', context)
else:
contributor.user.is_active = True
contributor.user.save()
- #return render(request, 'scipost/activation_ack.html')
context = {'ack_header': 'Your email address has been confirmed.',
'ack_message': ('Your SciPost account will soon be vetted. '
'You will soon receive an email from us.'),
@@ -368,7 +383,7 @@ def request_new_activation_link(request, oldkey):
salt = ""
for i in range(5):
salt = salt + random.choice(string.ascii_letters)
- #salt = hashlib.sha1(str(random.random()).encode('utf8')).hexdigest()[:5]
+
salt = salt.encode('utf8')
usernamesalt = contributor.user.username
usernamesalt = usernamesalt.encode('utf8')
@@ -389,11 +404,11 @@ def request_new_activation_link(request, oldkey):
[contributor.user.email, 'registration@scipost.org'],
reply_to=['registration@scipost.org'])
emailmessage.send(fail_silently=False)
- #return render (request, 'scipost/request_new_activation_link_ack.html')
- context = {'ack_header': 'We have emailed you a new activation link.',
- 'ack_message': ('Please acknowledge it within its 48 hours validity '
- 'window if you want us to proceed with vetting your registraion.'),
- }
+ context = {
+ 'ack_header': 'We have emailed you a new activation link.',
+ 'ack_message': ('Please acknowledge it within its 48 hours validity '
+ 'window if you want us to proceed with vetting your registraion.'),
+ }
return render(request, 'scipost/acknowledgement.html', context)
@@ -405,12 +420,13 @@ def unsubscribe(request, key):
want to receive any non-essential email notifications from SciPost.
"""
contributor = get_object_or_404(Contributor, activation_key=key)
- context = {'contributor': contributor,}
+ context = {'contributor': contributor, }
return render(request, 'scipost/unsubscribe.html', context)
+
def unsubscribe_confirm(request, key):
contributor = get_object_or_404(Contributor, activation_key=key)
- contributor.accepts_SciPost_emails=False
+ contributor.accepts_SciPost_emails = False
contributor.save()
context = {'ack_header': 'Unsubscribe',
'followup_message': ('We have recorded your preference: you will '
@@ -423,15 +439,14 @@ def unsubscribe_confirm(request, key):
@permission_required('scipost.can_vet_registration_requests', return_403=True)
def vet_registration_requests(request):
- contributor = Contributor.objects.get(user=request.user)
contributors_to_vet = (Contributor.objects
.filter(user__is_active=True, status=0)
.order_by('key_expires'))
- reg_cont_group = Group.objects.get(name='Registered Contributors') # TODO: remove this line?
form = VetRegistrationForm()
- context = {'contributors_to_vet': contributors_to_vet, 'form': form }
+ context = {'contributors_to_vet': contributors_to_vet, 'form': form}
return render(request, 'scipost/vet_registration_requests.html', context)
+
@permission_required('scipost.can_vet_registration_requests', return_403=True)
def vet_registration_request_ack(request, contributor_id):
# process the form
@@ -495,8 +510,6 @@ def vet_registration_request_ack(request, contributor_id):
contributor.status = form.cleaned_data['refusal_reason']
contributor.save()
- #context = {}
- #return render(request, 'scipost/vet_registration_request_ack.html', context)
context = {'ack_header': 'SciPost Registration request vetted.',
'followup_message': 'Back to ',
'followup_link': reverse('scipost:vet_registration_requests'),
@@ -577,30 +590,31 @@ def draft_registration_invitation(request):
'user__first_name', 'user__last_name')
existing_drafts = DraftInvitation.objects.filter(processed=False).order_by('last_name')
- context = {'draft_inv_form': draft_inv_form, 'errormessage': errormessage,
- 'sent_reg_inv_fellows': sent_reg_inv_fellows,
- 'nr_sent_reg_inv_fellows': nr_sent_reg_inv_fellows,
- 'sent_reg_inv_contrib': sent_reg_inv_contrib,
- 'nr_sent_reg_inv_contrib': nr_sent_reg_inv_contrib,
- 'sent_reg_inv_ref': sent_reg_inv_ref,
- 'nr_sent_reg_inv_ref': nr_sent_reg_inv_ref,
- 'sent_reg_inv_cited_sub': sent_reg_inv_cited_sub,
- 'nr_sent_reg_inv_cited_sub': nr_sent_reg_inv_cited_sub,
- 'sent_reg_inv_cited_pub': sent_reg_inv_cited_pub,
- 'nr_sent_reg_inv_cited_pub': nr_sent_reg_inv_cited_pub,
- 'resp_reg_inv_fellows': resp_reg_inv_fellows,
- 'nr_resp_reg_inv_fellows': nr_resp_reg_inv_fellows,
- 'resp_reg_inv_contrib': resp_reg_inv_contrib,
- 'nr_resp_reg_inv_contrib': nr_resp_reg_inv_contrib,
- 'resp_reg_inv_ref': resp_reg_inv_ref,
- 'nr_resp_reg_inv_ref': nr_resp_reg_inv_ref,
- 'resp_reg_inv_cited_sub': resp_reg_inv_cited_sub,
- 'nr_resp_reg_inv_cited_sub': nr_resp_reg_inv_cited_sub,
- 'resp_reg_inv_cited_pub': resp_reg_inv_cited_pub,
- 'nr_resp_reg_inv_cited_pub': nr_resp_reg_inv_cited_pub,
- 'decl_reg_inv': decl_reg_inv,
- 'names_reg_contributors': names_reg_contributors,
- 'existing_drafts': existing_drafts,
+ context = {
+ 'draft_inv_form': draft_inv_form, 'errormessage': errormessage,
+ 'sent_reg_inv_fellows': sent_reg_inv_fellows,
+ 'nr_sent_reg_inv_fellows': nr_sent_reg_inv_fellows,
+ 'sent_reg_inv_contrib': sent_reg_inv_contrib,
+ 'nr_sent_reg_inv_contrib': nr_sent_reg_inv_contrib,
+ 'sent_reg_inv_ref': sent_reg_inv_ref,
+ 'nr_sent_reg_inv_ref': nr_sent_reg_inv_ref,
+ 'sent_reg_inv_cited_sub': sent_reg_inv_cited_sub,
+ 'nr_sent_reg_inv_cited_sub': nr_sent_reg_inv_cited_sub,
+ 'sent_reg_inv_cited_pub': sent_reg_inv_cited_pub,
+ 'nr_sent_reg_inv_cited_pub': nr_sent_reg_inv_cited_pub,
+ 'resp_reg_inv_fellows': resp_reg_inv_fellows,
+ 'nr_resp_reg_inv_fellows': nr_resp_reg_inv_fellows,
+ 'resp_reg_inv_contrib': resp_reg_inv_contrib,
+ 'nr_resp_reg_inv_contrib': nr_resp_reg_inv_contrib,
+ 'resp_reg_inv_ref': resp_reg_inv_ref,
+ 'nr_resp_reg_inv_ref': nr_resp_reg_inv_ref,
+ 'resp_reg_inv_cited_sub': resp_reg_inv_cited_sub,
+ 'nr_resp_reg_inv_cited_sub': nr_resp_reg_inv_cited_sub,
+ 'resp_reg_inv_cited_pub': resp_reg_inv_cited_pub,
+ 'nr_resp_reg_inv_cited_pub': nr_resp_reg_inv_cited_pub,
+ 'decl_reg_inv': decl_reg_inv,
+ 'names_reg_contributors': names_reg_contributors,
+ 'existing_drafts': existing_drafts,
}
return render(request, 'scipost/draft_registration_invitation.html', context)
@@ -624,7 +638,7 @@ def edit_draft_reg_inv(request, draft_id):
draft_inv_form = DraftInvitationForm(instance=draft)
context = {'draft_inv_form': draft_inv_form,
'draft': draft,
- 'errormessage': errormessage,}
+ 'errormessage': errormessage, }
return render(request, 'scipost/edit_draft_reg_inv.html', context)
@@ -638,7 +652,6 @@ def map_draft_reg_inv_to_contributor(request, draft_id, contributor_id):
"""
draft = get_object_or_404(DraftInvitation, id=draft_id)
contributor = get_object_or_404(Contributor, id=contributor_id)
- errormessage = ''
draft.processed = True
draft.save()
citation = CitationNotification(
@@ -699,14 +712,15 @@ def registration_invitations(request, draft_id=None):
draft = get_object_or_404(DraftInvitation, id=draft_id)
associated_contributors = Contributor.objects.filter(
user__last_name__icontains=draft.last_name)
- initial = {'title': draft.title,
- 'first_name': draft.first_name,
- 'last_name': draft.last_name,
- 'email': draft.email,
- 'invitation_type': draft.invitation_type,
- 'cited_in_submission': draft.cited_in_submission,
- 'cited_in_publication': draft.cited_in_publication,
- }
+ initial = {
+ 'title': draft.title,
+ 'first_name': draft.first_name,
+ 'last_name': draft.last_name,
+ 'email': draft.email,
+ 'invitation_type': draft.invitation_type,
+ 'cited_in_submission': draft.cited_in_submission,
+ 'cited_in_publication': draft.cited_in_publication,
+ }
reg_inv_form = RegistrationInvitationForm(initial=initial)
sent_reg_inv = RegistrationInvitation.objects.filter(responded=False, declined=False)
@@ -740,31 +754,32 @@ def registration_invitations(request, draft_id=None):
'user__first_name', 'user__last_name')
existing_drafts = DraftInvitation.objects.filter(processed=False).order_by('last_name')
- context = {'reg_inv_form': reg_inv_form, 'errormessage': errormessage,
- 'sent_reg_inv_fellows': sent_reg_inv_fellows,
- 'nr_sent_reg_inv_fellows': nr_sent_reg_inv_fellows,
- 'sent_reg_inv_contrib': sent_reg_inv_contrib,
- 'nr_sent_reg_inv_contrib': nr_sent_reg_inv_contrib,
- 'sent_reg_inv_ref': sent_reg_inv_ref,
- 'nr_sent_reg_inv_ref': nr_sent_reg_inv_ref,
- 'sent_reg_inv_cited_sub': sent_reg_inv_cited_sub,
- 'nr_sent_reg_inv_cited_sub': nr_sent_reg_inv_cited_sub,
- 'sent_reg_inv_cited_pub': sent_reg_inv_cited_pub,
- 'nr_sent_reg_inv_cited_pub': nr_sent_reg_inv_cited_pub,
- 'resp_reg_inv_fellows': resp_reg_inv_fellows,
- 'nr_resp_reg_inv_fellows': nr_resp_reg_inv_fellows,
- 'resp_reg_inv_contrib': resp_reg_inv_contrib,
- 'nr_resp_reg_inv_contrib': nr_resp_reg_inv_contrib,
- 'resp_reg_inv_ref': resp_reg_inv_ref,
- 'nr_resp_reg_inv_ref': nr_resp_reg_inv_ref,
- 'resp_reg_inv_cited_sub': resp_reg_inv_cited_sub,
- 'nr_resp_reg_inv_cited_sub': nr_resp_reg_inv_cited_sub,
- 'resp_reg_inv_cited_pub': resp_reg_inv_cited_pub,
- 'nr_resp_reg_inv_cited_pub': nr_resp_reg_inv_cited_pub,
- 'decl_reg_inv': decl_reg_inv,
- 'names_reg_contributors': names_reg_contributors,
- 'existing_drafts': existing_drafts,
- 'associated_contributors': associated_contributors,
+ context = {
+ 'reg_inv_form': reg_inv_form, 'errormessage': errormessage,
+ 'sent_reg_inv_fellows': sent_reg_inv_fellows,
+ 'nr_sent_reg_inv_fellows': nr_sent_reg_inv_fellows,
+ 'sent_reg_inv_contrib': sent_reg_inv_contrib,
+ 'nr_sent_reg_inv_contrib': nr_sent_reg_inv_contrib,
+ 'sent_reg_inv_ref': sent_reg_inv_ref,
+ 'nr_sent_reg_inv_ref': nr_sent_reg_inv_ref,
+ 'sent_reg_inv_cited_sub': sent_reg_inv_cited_sub,
+ 'nr_sent_reg_inv_cited_sub': nr_sent_reg_inv_cited_sub,
+ 'sent_reg_inv_cited_pub': sent_reg_inv_cited_pub,
+ 'nr_sent_reg_inv_cited_pub': nr_sent_reg_inv_cited_pub,
+ 'resp_reg_inv_fellows': resp_reg_inv_fellows,
+ 'nr_resp_reg_inv_fellows': nr_resp_reg_inv_fellows,
+ 'resp_reg_inv_contrib': resp_reg_inv_contrib,
+ 'nr_resp_reg_inv_contrib': nr_resp_reg_inv_contrib,
+ 'resp_reg_inv_ref': resp_reg_inv_ref,
+ 'nr_resp_reg_inv_ref': nr_resp_reg_inv_ref,
+ 'resp_reg_inv_cited_sub': resp_reg_inv_cited_sub,
+ 'nr_resp_reg_inv_cited_sub': nr_resp_reg_inv_cited_sub,
+ 'resp_reg_inv_cited_pub': resp_reg_inv_cited_pub,
+ 'nr_resp_reg_inv_cited_pub': nr_resp_reg_inv_cited_pub,
+ 'decl_reg_inv': decl_reg_inv,
+ 'names_reg_contributors': names_reg_contributors,
+ 'existing_drafts': existing_drafts,
+ 'associated_contributors': associated_contributors,
}
return render(request, 'scipost/registration_invitations.html', context)
@@ -806,9 +821,9 @@ def edit_invitation_personal_message(request, invitation_id):
errormessage = 'The form was invalid.'
else:
form = ModifyPersonalMessageForm(
- initial={'personal_message': invitation.personal_message,})
+ initial={'personal_message': invitation.personal_message, })
context = {'invitation': invitation,
- 'form': form, 'errormessage': errormessage,}
+ 'form': form, 'errormessage': errormessage, }
return render(request, 'scipost/edit_invitation_personal_message.html', context)
@@ -819,8 +834,8 @@ def renew_registration_invitation(request, invitation_id):
"""
invitation = get_object_or_404(RegistrationInvitation, pk=invitation_id)
errormessage = None
- if (invitation.invitation_type == 'F'
- and not request.user.has_perm('scipost.can_invite_Fellows')):
+ if(invitation.invitation_type == 'F'
+ and not request.user.has_perm('scipost.can_invite_Fellows')):
errormessage = ('You do not have the authorization to send a Fellow-type '
'invitation. Consider Contributor, or cited (sub/pub). ')
elif invitation.invitation_type == 'R':
@@ -850,14 +865,14 @@ def mark_reg_inv_as_declined(request, invitation_id):
def citation_notifications(request):
unprocessed_notifications = CitationNotification.objects.filter(
processed=False).order_by('contributor__user__last_name')
- context = {'unprocessed_notifications': unprocessed_notifications,}
+ context = {'unprocessed_notifications': unprocessed_notifications, }
return render(request, 'scipost/citation_notifications.html', context)
@permission_required('scipost.can_manage_registration_invitations', return_403=True)
def process_citation_notification(request, cn_id):
notification = get_object_or_404(CitationNotification, id=cn_id)
- notification.processed=True
+ notification.processed = True
notification.save()
if notification.contributor.accepts_SciPost_emails:
Utils.load({'notification': notification})
@@ -886,8 +901,6 @@ def login_view(request):
if user is not None and is_registered(user):
if user.is_active:
login(request, user)
- contributor = Contributor.objects.get(user=request.user)
- context = {'contributor': contributor }
return redirect(redirect_to)
else:
return render(request, 'scipost/disabled_account.html')
@@ -914,7 +927,8 @@ def mark_unavailable_period(request):
elif unav_form.cleaned_data['end'] < now.date():
errormessage = 'You have entered an end date in the past.'
if errormessage is not None:
- return render(request, 'scipost/error.html', context={'errormessage': errormessage})
+ return render(request, 'scipost/error.html',
+ context={'errormessage': errormessage})
else:
unav = UnavailabilityPeriod(
contributor=request.user.contributor,
@@ -933,11 +947,13 @@ def personal_page(request):
"""
if request.user.is_authenticated():
contributor = Contributor.objects.get(user=request.user)
+
# Compile the unavailability periods:
now = timezone.now()
unavailabilities = UnavailabilityPeriod.objects.filter(
contributor=contributor).exclude(end__lt=now).order_by('start')
unavailability_form = UnavailabilityPeriodForm()
+
# if an editor, count the number of actions required:
nr_reg_to_vet = 0
nr_reg_awaiting_validation = 0
@@ -945,6 +961,7 @@ def personal_page(request):
nr_recommendations_to_prepare_for_voting = 0
if is_SP_Admin(request.user):
intwodays = now + timezone.timedelta(days=2)
+
# count the number of pending registration requests
nr_reg_to_vet = Contributor.objects.filter(user__is_active=True, status=0).count()
nr_reg_awaiting_validation = Contributor.objects.filter(
@@ -1005,10 +1022,10 @@ def personal_page(request):
.exclude(author_false_claims__in=[contributor])
.count())
own_comments = (Comment.objects
- .filter(author=contributor,is_author_reply=False)
+ .filter(author=contributor, is_author_reply=False)
.order_by('-date_submitted'))
own_authorreplies = (Comment.objects
- .filter(author=contributor,is_author_reply=True)
+ .filter(author=contributor, is_author_reply=True)
.order_by('-date_submitted'))
lists_owned = List.objects.filter(owner=contributor)
lists = List.objects.filter(teams_with_access__members__in=[contributor])
@@ -1018,37 +1035,38 @@ def personal_page(request):
graphs_private = Graph.objects.filter(Q(teams_with_access__leader=contributor)
| Q(teams_with_access__members__in=[contributor]))
appellation = title_dict[contributor.title] + ' ' + contributor.user.last_name
- context = {'contributor': contributor,
- 'appellation': appellation,
- 'unavailabilities': unavailabilities,
- 'unavailability_form': unavailability_form,
- 'nr_reg_to_vet': nr_reg_to_vet,
- 'nr_reg_awaiting_validation': nr_reg_awaiting_validation,
- 'nr_commentary_page_requests_to_vet': nr_commentary_page_requests_to_vet,
- 'nr_comments_to_vet': nr_comments_to_vet,
- 'nr_thesislink_requests_to_vet': nr_thesislink_requests_to_vet,
- 'nr_authorship_claims_to_vet': nr_authorship_claims_to_vet,
- 'nr_reports_to_vet': nr_reports_to_vet,
- 'nr_submissions_to_assign': nr_submissions_to_assign,
- 'nr_recommendations_to_prepare_for_voting': nr_recommendations_to_prepare_for_voting,
- 'nr_assignments_to_consider': nr_assignments_to_consider,
- 'active_assignments': active_assignments,
- 'nr_submission_authorships_to_claim': nr_submission_authorships_to_claim,
- 'nr_commentary_authorships_to_claim': nr_commentary_authorships_to_claim,
- 'nr_thesis_authorships_to_claim': nr_thesis_authorships_to_claim,
- 'nr_ref_inv_to_consider': nr_ref_inv_to_consider,
- 'pending_ref_tasks': pending_ref_tasks,
- 'own_submissions': own_submissions,
- 'own_commentaries': own_commentaries,
- 'own_thesislinks': own_thesislinks,
- 'own_comments': own_comments, 'own_authorreplies': own_authorreplies,
- 'lists_owned': lists_owned,
- 'lists': lists,
- 'teams_led': teams_led,
- 'teams': teams,
- 'graphs_owned': graphs_owned,
- 'graphs_private': graphs_private,
- }
+ context = {
+ 'contributor': contributor,
+ 'appellation': appellation,
+ 'unavailabilities': unavailabilities,
+ 'unavailability_form': unavailability_form,
+ 'nr_reg_to_vet': nr_reg_to_vet,
+ 'nr_reg_awaiting_validation': nr_reg_awaiting_validation,
+ 'nr_commentary_page_requests_to_vet': nr_commentary_page_requests_to_vet,
+ 'nr_comments_to_vet': nr_comments_to_vet,
+ 'nr_thesislink_requests_to_vet': nr_thesislink_requests_to_vet,
+ 'nr_authorship_claims_to_vet': nr_authorship_claims_to_vet,
+ 'nr_reports_to_vet': nr_reports_to_vet,
+ 'nr_submissions_to_assign': nr_submissions_to_assign,
+ 'nr_recommendations_to_prepare_for_voting': nr_recommendations_to_prepare_for_voting,
+ 'nr_assignments_to_consider': nr_assignments_to_consider,
+ 'active_assignments': active_assignments,
+ 'nr_submission_authorships_to_claim': nr_submission_authorships_to_claim,
+ 'nr_commentary_authorships_to_claim': nr_commentary_authorships_to_claim,
+ 'nr_thesis_authorships_to_claim': nr_thesis_authorships_to_claim,
+ 'nr_ref_inv_to_consider': nr_ref_inv_to_consider,
+ 'pending_ref_tasks': pending_ref_tasks,
+ 'own_submissions': own_submissions,
+ 'own_commentaries': own_commentaries,
+ 'own_thesislinks': own_thesislinks,
+ 'own_comments': own_comments, 'own_authorreplies': own_authorreplies,
+ 'lists_owned': lists_owned,
+ 'lists': lists,
+ 'teams_led': teams_led,
+ 'teams': teams,
+ 'graphs_owned': graphs_owned,
+ 'graphs_private': graphs_private,
+ }
return render(request, 'scipost/personal_page.html', context)
else:
form = AuthenticationForm()
@@ -1060,6 +1078,7 @@ def personal_page(request):
def change_password(request):
if request.method == 'POST':
form = PasswordChangeForm(request.POST)
+ ack = False
if form.is_valid():
if not request.user.check_password(form.cleaned_data['password_prev']):
return render(
@@ -1067,16 +1086,17 @@ def change_password(request):
{'form': form,
'errormessage': 'The currently existing password you entered is incorrect'})
if form.cleaned_data['password_new'] != form.cleaned_data['password_verif']:
- return render(request, 'scipost/change_password.html',
- {'form': form, 'errormessage': 'Your new password entries must match'})
+ return render(request, 'scipost/change_password.html', {
+ 'form': form,
+ 'errormessage': 'Your new password entries must match'})
request.user.set_password(form.cleaned_data['password_new'])
request.user.save()
ack = True
- context = {'ack': True, 'form': form}
+ context = {'ack': ack, 'form': form}
else:
form = PasswordChangeForm()
context = {'ack': False, 'form': form}
- return render (request, 'scipost/change_password.html', context)
+ return render(request, 'scipost/change_password.html', context)
def reset_password_confirm(request, uidb64=None, token=None):
@@ -1084,11 +1104,12 @@ def reset_password_confirm(request, uidb64=None, token=None):
uidb64=uidb64, token=token,
post_reset_redirect=reverse('scipost:login'))
+
def reset_password(request):
return password_reset(request, template_name='scipost/reset_password.html',
- email_template_name='scipost/reset_password_email.html',
- subject_template_name='scipost/reset_password_subject.txt',
- post_reset_redirect=reverse('scipost:login'))
+ email_template_name='scipost/reset_password_email.html',
+ subject_template_name='scipost/reset_password_subject.txt',
+ post_reset_redirect=reverse('scipost:login'))
@login_required
@@ -1112,7 +1133,6 @@ def update_personal_data(request):
request.user.contributor.accepts_SciPost_emails = cont_form.cleaned_data['accepts_SciPost_emails']
request.user.save()
request.user.contributor.save()
- #return render(request, 'scipost/update_personal_data_ack.html')
context = {'ack_header': 'Your personal data has been updated.',
'followup_message': 'Return to your ',
'followup_link': reverse('scipost:personal_page'),
@@ -1120,6 +1140,9 @@ def update_personal_data(request):
return render(request, 'scipost/acknowledgement.html', context)
else:
user_form = UpdateUserDataForm(instance=contributor.user)
+ # Prevent exploit of gaining view on self-authored submissions by changing surname.
+ user_form.fields['last_name'].widget.attrs['disabled'] = True
+ # Surname can only be changed through the admin.
cont_form = UpdatePersonalDataForm(instance=contributor)
return render(request, 'scipost/update_personal_data.html',
{'user_form': user_form, 'cont_form': cont_form})
@@ -1168,7 +1191,7 @@ def claim_authorships(request):
def claim_sub_authorship(request, submission_id, claim):
if request.method == 'POST':
contributor = Contributor.objects.get(user=request.user)
- submission = get_object_or_404(Submission,pk=submission_id)
+ submission = get_object_or_404(Submission, pk=submission_id)
if claim == '1':
submission.authors_claims.add(contributor)
newclaim = AuthorshipClaim(claimant=contributor, submission=submission)
@@ -1178,11 +1201,12 @@ def claim_sub_authorship(request, submission_id, claim):
submission.save()
return redirect('scipost:claim_authorships')
+
@login_required
def claim_com_authorship(request, commentary_id, claim):
if request.method == 'POST':
contributor = Contributor.objects.get(user=request.user)
- commentary = get_object_or_404(Commentary,pk=commentary_id)
+ commentary = get_object_or_404(Commentary, pk=commentary_id)
if claim == '1':
commentary.authors_claims.add(contributor)
newclaim = AuthorshipClaim(claimant=contributor, commentary=commentary)
@@ -1192,11 +1216,12 @@ def claim_com_authorship(request, commentary_id, claim):
commentary.save()
return redirect('scipost:claim_authorships')
+
@login_required
def claim_thesis_authorship(request, thesis_id, claim):
if request.method == 'POST':
contributor = Contributor.objects.get(user=request.user)
- thesislink = get_object_or_404(ThesisLink,pk=thesis_id)
+ thesislink = get_object_or_404(ThesisLink, pk=thesis_id)
if claim == '1':
thesislink.author_claims.add(contributor)
newclaim = AuthorshipClaim(claimant=contributor, thesislink=thesislink)
@@ -1213,6 +1238,7 @@ def vet_authorship_claims(request):
context = {'claims_to_vet': claims_to_vet}
return render(request, 'scipost/vet_authorship_claims.html', context)
+
@permission_required('scipost.can_vet_authorship_claims', return_403=True)
def vet_authorship_claim(request, claim_id, claim):
if request.method == 'POST':
@@ -1322,8 +1348,8 @@ def email_group_members(request):
email_text = ''
email_text_html = ''
if form.cleaned_data['personalize']:
- email_text = ('Dear ' + title_dict[member.contributor.title] + ' ' +
- member.last_name + ', \n\n')
+ email_text = ('Dear ' + title_dict[member.contributor.title]
+ + ' ' + member.last_name + ', \n\n')
email_text_html = 'Dear {{ title }} {{ last_name }},<br/>'
email_text += form.cleaned_data['email_text']
email_text_html += '{{ email_text|linebreaks }}'
@@ -1347,9 +1373,6 @@ def email_group_members(request):
})
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- # mail.EmailMessage(form.cleaned_data['email_subject'],
- # email_text, 'SciPost Admin <admin@scipost.org>',
- # [member.email], connection=connection).send()
message = EmailMultiAlternatives(
form.cleaned_data['email_subject'],
email_text, 'SciPost Admin <admin@scipost.org>',
@@ -1453,7 +1476,6 @@ def send_precooked_email(request):
# Editorial College #
#####################
-
def EdCol_bylaws(request):
return render(request, 'scipost/EdCol_by-laws.html')
@@ -1462,7 +1484,7 @@ def EdCol_bylaws(request):
def Fellow_activity_overview(request, Fellow_id=None):
Fellows = Contributor.objects.filter(
user__groups__name='Editorial College').order_by('user__last_name')
- context = {'Fellows': Fellows,}
+ context = {'Fellows': Fellows, }
if Fellow_id:
Fellow = get_object_or_404(Contributor, pk=Fellow_id)
context['Fellow'] = Fellow
@@ -1472,6 +1494,241 @@ def Fellow_activity_overview(request, Fellow_id=None):
return render(request, 'scipost/Fellow_activity_overview.html', context)
+@login_required
+@permission_required('scipost.can_attend_VGMs', return_403=True)
+def VGMs(request):
+ VGM_list = VGM.objects.all().order_by('start_date')
+ context = {'VGM_list': VGM_list}
+ return render(request, 'scipost/VGMs.html', context)
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', return_403=True)
+def VGM_detail(request, VGM_id):
+ VGM_instance = get_object_or_404(VGM, id=VGM_id)
+ VGM_information = Template(VGM_instance.information).render(Context({}))
+ feedback_received = Feedback.objects.filter(VGM=VGM_instance).order_by('date')
+ feedback_form = FeedbackForm()
+ current_Fellows = Contributor.objects.filter(
+ user__groups__name='Editorial College').order_by('user__last_name')
+ sent_inv_Fellows = RegistrationInvitation.objects.filter(
+ invitation_type='F', responded=False)
+ pending_inv_Fellows = sent_inv_Fellows.filter(declined=False).order_by('last_name')
+ declined_inv_Fellows = sent_inv_Fellows.filter(declined=True).order_by('last_name')
+ nomination_form = NominationForm()
+ nominations = Nomination.objects.filter(accepted=None).order_by('last_name')
+ motion_form = MotionForm()
+ remark_form = RemarkForm()
+ context = {
+ 'VGM': VGM_instance,
+ 'VGM_information': VGM_information,
+ 'feedback_received': feedback_received,
+ 'feedback_form': feedback_form,
+ 'current_Fellows': current_Fellows,
+ 'pending_inv_Fellows': pending_inv_Fellows,
+ 'declined_inv_Fellows': declined_inv_Fellows,
+ 'nominations': nominations,
+ 'nomination_form': nomination_form,
+ 'motion_categories_dict': motion_categories_dict,
+ 'motion_form': motion_form,
+ 'remark_form': remark_form,
+ }
+ return render(request, 'scipost/VGM_detail.html', context)
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', return_403=True)
+def feedback(request, VGM_id=None):
+ if request.method == 'POST':
+ feedback_form = FeedbackForm(request.POST)
+ if feedback_form.is_valid():
+ feedback = Feedback(by=request.user.contributor,
+ date=timezone.now().date(),
+ feedback=feedback_form.cleaned_data['feedback'],)
+ if VGM_id:
+ VGM_instance = get_object_or_404(VGM, id=VGM_id)
+ feedback.VGM = VGM_instance
+ feedback.save()
+ ack_message = 'Your feedback has been received.'
+ context = {'ack_message': ack_message}
+ if VGM_id:
+ context['followup_message'] = 'Return to the '
+ context['followup_link'] = reverse('scipost:VGM_detail',
+ kwargs={'VGM_id': VGM_id})
+ context['followup_link_label'] = 'VGM page'
+ return render(request, 'scipost/acknowledgement.html', context)
+ else:
+ errormessage = 'The form was not filled properly.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ else:
+ errormessage = 'This view can only be posted to.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', raise_exception=True)
+def add_remark_on_feedback(request, VGM_id, feedback_id):
+ # contributor = request.user.contributor
+ feedback = get_object_or_404(Feedback, pk=feedback_id)
+ if request.method == 'POST':
+ remark_form = RemarkForm(request.POST)
+ if remark_form.is_valid():
+ remark = Remark(contributor=request.user.contributor,
+ feedback=feedback,
+ date=timezone.now(),
+ remark=remark_form.cleaned_data['remark'])
+ remark.save()
+ return HttpResponseRedirect('/VGM/' + str(VGM_id) +
+ '/#feedback_id' + str(feedback.id))
+ else:
+ errormessage = 'The form was invalidly filled.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ else:
+ errormessage = 'This view can only be posted to.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', return_403=True)
+def nominate_Fellow(request, VGM_id):
+ VGM_instance = get_object_or_404(VGM, id=VGM_id)
+ if request.method == 'POST':
+ nomination_form = NominationForm(request.POST)
+ if nomination_form.is_valid():
+ nomination = Nomination(
+ VGM=VGM_instance,
+ by=request.user.contributor,
+ date=timezone.now().date(),
+ first_name=nomination_form.cleaned_data['first_name'],
+ last_name=nomination_form.cleaned_data['last_name'],
+ discipline=nomination_form.cleaned_data['discipline'],
+ expertises=nomination_form.cleaned_data['expertises'],
+ webpage=nomination_form.cleaned_data['webpage'],
+ voting_deadline=VGM_instance.end_date + datetime.timedelta(days=7),
+ )
+ nomination.save()
+ nomination.update_votes(request.user.contributor.id, 'A')
+ ack_message = 'The nomination has been registered.'
+ context = {'ack_message': ack_message,
+ 'followup_message': 'Return to the ',
+ 'followup_link': reverse('scipost:VGM_detail', kwargs={'VGM_id': VGM_id}),
+ 'followup_link_label': 'VGM page'}
+ return render(request, 'scipost/acknowledgement.html', context)
+ else:
+ errormessage = 'The form was not filled properly.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ else:
+ errormessage = 'This view can only be posted to.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', raise_exception=True)
+def add_remark_on_nomination(request, VGM_id, nomination_id):
+ # contributor = request.user.contributor
+ nomination = get_object_or_404(Nomination, pk=nomination_id)
+ if request.method == 'POST':
+ remark_form = RemarkForm(request.POST)
+ if remark_form.is_valid():
+ remark = Remark(contributor=request.user.contributor,
+ nomination=nomination,
+ date=timezone.now(),
+ remark=remark_form.cleaned_data['remark'])
+ remark.save()
+ return HttpResponseRedirect('/VGM/' + str(VGM_id) +
+ '/#nomination_id' + str(nomination.id))
+ else:
+ errormessage = 'The form was invalidly filled.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ else:
+ errormessage = 'This view can only be posted to.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', raise_exception=True)
+def vote_on_nomination(request, nomination_id, vote):
+ contributor = request.user.contributor
+ nomination = get_object_or_404(Nomination, pk=nomination_id)
+ if timezone.now() > nomination.voting_deadline:
+ errormessage = 'The voting deadline on this nomination has passed.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ nomination.update_votes(contributor.id, vote)
+ return HttpResponseRedirect('/VGM/' + str(nomination.VGM.id) +
+ '/#nomination_id' + str(nomination.id))
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', return_403=True)
+def put_motion_forward(request, VGM_id):
+ VGM_instance = get_object_or_404(VGM, id=VGM_id)
+ if timezone.now().date() > VGM_instance.end_date:
+ errormessage = 'This VGM has ended. No new motions can be put forward.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ if request.method == 'POST':
+ motion_form = MotionForm(request.POST)
+ if motion_form.is_valid():
+ motion = Motion(
+ category=motion_form.cleaned_data['category'],
+ VGM=VGM_instance,
+ background=motion_form.cleaned_data['background'],
+ motion=motion_form.cleaned_data['motion'],
+ put_forward_by=request.user.contributor,
+ date=timezone.now().date(),
+ voting_deadline=VGM_instance.end_date + datetime.timedelta(days=7),
+ )
+ motion.save()
+ motion.update_votes(request.user.contributor.id, 'A')
+ ack_message = 'Your motion has been registered.'
+ context = {'ack_message': ack_message,
+ 'followup_message': 'Return to the ',
+ 'followup_link': reverse('scipost:VGM_detail', kwargs={'VGM_id': VGM_id}),
+ 'followup_link_label': 'VGM page'}
+ return render(request, 'scipost/acknowledgement.html', context)
+ else:
+ errormessage = 'The form was not filled properly.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ else:
+ errormessage = 'This view can only be posted to.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', raise_exception=True)
+def add_remark_on_motion(request, motion_id):
+ # contributor = request.user.contributor
+ motion = get_object_or_404(Motion, pk=motion_id)
+ if request.method == 'POST':
+ remark_form = RemarkForm(request.POST)
+ if remark_form.is_valid():
+ remark = Remark(contributor=request.user.contributor,
+ motion=motion,
+ date=timezone.now(),
+ remark=remark_form.cleaned_data['remark'])
+ remark.save()
+ return HttpResponseRedirect('/VGM/' + str(motion.VGM.id) +
+ '/#motion_id' + str(motion.id))
+ else:
+ errormessage = 'The form was invalidly filled.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ else:
+ errormessage = 'This view can only be posted to.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+
+
+@login_required
+@permission_required('scipost.can_attend_VGMs', raise_exception=True)
+def vote_on_motion(request, motion_id, vote):
+ contributor = request.user.contributor
+ motion = get_object_or_404(Motion, pk=motion_id)
+ if timezone.now() > motion.voting_deadline:
+ errormessage = 'The voting deadline on this motion has passed.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ motion.update_votes(contributor.id, vote)
+ return HttpResponseRedirect('/VGM/' + str(motion.VGM.id) +
+ '/#motion_id' + str(motion.id))
+
+
#########
# Lists #
#########
@@ -1493,7 +1750,7 @@ def create_list(request):
assign_perm('scipost.change_list', request.user, newlist)
assign_perm('scipost.view_list', request.user, newlist)
assign_perm('scipost.delete_list', request.user, newlist)
- message = 'List ' + create_list_form.cleaned_data['title'] + ' was successfully created.'
+ message = 'List %s was successfully created.' % create_list_form.cleaned_data['title']
else:
create_list_form = CreateListForm()
context = {'create_list_form': create_list_form, 'listcreated': listcreated,
@@ -1575,6 +1832,7 @@ def create_team(request):
'add_team_member_form': add_team_member_form}
return render(request, 'scipost/create_team.html', context)
+
@permission_required_or_403('scipost.change_team', (Team, 'id', 'team_id'))
def add_team_member(request, team_id, contributor_id=None):
team = get_object_or_404(Team, pk=team_id)
@@ -1631,7 +1889,6 @@ def create_graph(request):
def graph(request, graph_id):
graph = get_object_or_404(Graph, pk=graph_id)
nodes = Node.objects.filter(graph=graph)
- arcs = Arc.objects.filter(graph=graph)
if request.method == "POST":
attach_teams_form = ManageTeamsForm(request.POST,
contributor=request.user.contributor,
@@ -1684,13 +1941,13 @@ def edit_graph_node(request, node_id):
elif request.method == "POST":
edit_node_form = CreateNodeForm(request.POST, instance=node)
if edit_node_form.is_valid():
- node.name=edit_node_form.cleaned_data['name']
- node.description=edit_node_form.cleaned_data['description']
+ node.name = edit_node_form.cleaned_data['name']
+ node.description = edit_node_form.cleaned_data['description']
node.save()
create_node_form = CreateNodeForm()
create_arc_form = CreateArcForm(graph=node.graph)
- context = {'create_node_form': create_node_form,
- 'create_arc_form': create_arc_form}
+ context = {'create_node_form': create_node_form,
+ 'create_arc_form': create_arc_form}
return redirect(reverse('scipost:graph', kwargs={'graph_id': node.graph.id}), context)
else:
edit_node_form = CreateNodeForm(instance=node)
@@ -1701,7 +1958,6 @@ def edit_graph_node(request, node_id):
def delete_graph_node(request, node_id):
node = get_object_or_404(Node, pk=node_id)
- errormessage = ''
if not request.user.has_perm('scipost.change_graph', node.graph):
raise PermissionDenied
else:
@@ -1721,11 +1977,10 @@ def api_graph(request, graph_id):
arcs = Arc.objects.filter(graph=graph)
nodesjson = []
arcsjson = []
+
for node in nodes:
nodesjson.append({'name': node.name, 'id': node.id})
-# for origin in node.arcs_in.all():
-# links.append({'source': origin.name, 'source_id': origin.id,
-# 'target': node.name, 'target_id': node.id})
+
for arc in arcs:
arcsjson.append({'id': arc.id,
'source': arc.source.name, 'source_id': arc.source.id,
@@ -1734,13 +1989,16 @@ def api_graph(request, graph_id):
return JsonResponse({'nodes': nodesjson, 'arcs': arcsjson}, safe=False)
-
#############################
# Supporting Partners Board #
#############################
def supporting_partners(request):
- return render(request, 'scipost/supporting_partners.html')
+ prospective_agreements = SPBMembershipAgreement.objects.filter(
+ status='Submitted').order_by('date_requested')
+ context = {'prospective_partners': prospective_agreements, }
+ return render(request, 'scipost/supporting_partners.html', context)
+
@login_required
def SPB_membership_request(request):
@@ -1770,7 +2028,7 @@ def SPB_membership_request(request):
ack_message = ('Thank you for your SPB Membership request. '
'We will get back to you in the very near future '
'with details of the proposed agreement.')
- context = {'ack_message': ack_message,}
+ context = {'ack_message': ack_message, }
return render(request, 'scipost/acknowledgement.html', context)
else:
errormessage = 'The form was not filled properly.'
@@ -1780,5 +2038,5 @@ def SPB_membership_request(request):
membership_form = SPBMembershipForm()
context = {'errormessage': errormessage,
'SP_form': SP_form,
- 'membership_form': membership_form,}
+ 'membership_form': membership_form, }
return render(request, 'scipost/SPB_membership_request.html', context)
diff --git a/static/scipost/SPB/SciPost_Supporting_Partner_Agreement.pdf b/static/scipost/SPB/SciPost_Supporting_Partner_Agreement.pdf
new file mode 100644
index 0000000000000000000000000000000000000000..042b661a679115369f9ee152cf626744eb8f3eea
Binary files /dev/null and b/static/scipost/SPB/SciPost_Supporting_Partner_Agreement.pdf differ
diff --git a/submissions/forms.py b/submissions/forms.py
index 43e02014b2217cacd32a5ff3c408a788c0dcd618..bcac8cac71b9590b2e4c30d78aecfb018a45e53e 100644
--- a/submissions/forms.py
+++ b/submissions/forms.py
@@ -1,13 +1,14 @@
from django import forms
from django.core.validators import RegexValidator
-# from django.contrib.auth.models import User, Group
-from .models import *
+from .models import ASSIGNMENT_BOOL, ASSIGNMENT_REFUSAL_REASONS,\
+ Submission, RefereeInvitation, Report, EICRecommendation
-from scipost.models import SCIPOST_SUBJECT_AREAS
+from scipost.constants import SCIPOST_SUBJECT_AREAS
+from scipost.models import Contributor
from crispy_forms.helper import FormHelper
-from crispy_forms.layout import Layout, Div, Field, Fieldset, HTML, Submit
+from crispy_forms.layout import Layout, Div, Field, HTML, Submit
class SubmissionSearchForm(forms.Form):
@@ -76,8 +77,6 @@ class SubmissionForm(forms.ModelForm):
'rows': 3})
-
-
######################
# Editorial workflow #
######################
@@ -154,6 +153,7 @@ class VotingEligibilityForm(forms.Form):
required=True, label='Eligible for voting',
)
+
############
# Reports:
############
diff --git a/submissions/models.py b/submissions/models.py
index b98ade4c96f582b19f060a43126bc62df7224430..39b0e37d1183c05d49e37484f2d0444a53b8065a 100644
--- a/submissions/models.py
+++ b/submissions/models.py
@@ -1,20 +1,15 @@
import datetime
from django.utils import timezone
-from django.utils.safestring import mark_safe
from django.db import models, transaction
-from django.contrib.auth.models import User
-from django.contrib.postgres.fields import ArrayField, JSONField
+from django.contrib.postgres.fields import JSONField
from django.template import Template, Context
-from .models import *
-
-from scipost.models import ChoiceArrayField, Contributor, title_dict, Remark
+from scipost.models import ChoiceArrayField, Contributor, title_dict
from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS, subject_areas_dict
from scipost.models import TITLE_CHOICES
from journals.models import SCIPOST_JOURNALS_SUBMIT, SCIPOST_JOURNALS_DOMAINS
-from journals.models import SCIPOST_JOURNALS_SPECIALIZATIONS
-from journals.models import journals_submit_dict, journals_domains_dict, journals_spec_dict
+from journals.models import journals_submit_dict, journals_domains_dict
from journals.models import Publication
@@ -50,6 +45,8 @@ SUBMISSION_STATUS_OUT_OF_POOL = [
'resubmitted',
'published',
'withdrawn',
+ 'rejected',
+ 'rejected_visible',
]
# Submissions which should not appear in search lists
@@ -70,7 +67,6 @@ SUBMISSION_STATUS_PUBLICLY_INVISIBLE = [
'assignment_failed',
'resubmitted_rejected',
'rejected',
- #'published',
'withdrawn',
]
@@ -84,7 +80,7 @@ SUBMISSION_STATUS_VOTING_DEPRECATED = [
# SUBMISSION_ACTION_REQUIRED = (
# ('assign_EIC', 'Editor-in-charge to be assigned'),
-# # ('Fellow_accepts_or_refuse_assignment', 'Fellow must accept or refuse assignment'),
+# ('Fellow_accepts_or_refuse_assignment', 'Fellow must accept or refuse assignment'),
# ('EIC_runs_refereeing_round', 'Editor-in-charge to run refereeing round (inviting referees)'),
# ('EIC_closes_refereeing_round', 'Editor-in-charge to close refereeing round'),
# ('EIC_invites_author_response', 'Editor-in-charge invites authors to complete their replies'),
@@ -253,26 +249,22 @@ class Submission(models.Model):
'<tr><td>Submitted by: </td><td> </td><td>{{ submitted_by }}</td></tr>'
'<tr><td>Submitted to: </td><td> </td><td>{{ to_journal }}</td></tr>'
'<tr><td>Domain(s): </td><td> </td><td>{{ domain }}</td></tr>'
-# '<tr><td>Specialization: </td><td> </td><td>{{ spec }}</td></tr>'
'<tr><td>Subject area: </td><td> </td><td>{{ subject_area }}</td></tr>'
'</table>')
template = Template(header)
- context = Context({'title': self.title, 'author_list': self.author_list,
- 'arxiv_link': self.arxiv_link, 'submission_date': self.submission_date,
- 'submitted_by': self.submitted_by,
- 'to_journal': journals_submit_dict[self.submitted_to_journal],
- 'domain': journals_domains_dict[self.domain],
-# 'spec': journals_spec_dict[self.specialization],
- 'subject_area': subject_areas_dict[self.subject_area],
- })
+ context = Context({
+ 'title': self.title, 'author_list': self.author_list,
+ 'arxiv_link': self.arxiv_link, 'submission_date': self.submission_date,
+ 'submitted_by': self.submitted_by,
+ 'to_journal': journals_submit_dict[self.submitted_to_journal],
+ 'domain': journals_domains_dict[self.domain],
+ 'subject_area': subject_areas_dict[self.subject_area],
+ })
return template.render(context)
-
- def header_as_li (self):
+ def header_as_li(self):
# for search lists
header = ('<li>'
- #'<div class="flex-container">'
- #'<div class="flex-whitebox0">'
'<p>'
'<a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">{{ title }}</a></p>'
@@ -284,7 +276,6 @@ class Submission(models.Model):
header += ' (deprecated version {{ arxiv_vn_nr }})'
header += ('</p><p> Submitted {{ submission_date }} to {{ to_journal }}'
' - latest activity: {{ latest_activity }}</p>'
- #'</div></div>'
'</li>')
context = Context({'arxiv_identifier_w_vn_nr': self.arxiv_identifier_w_vn_nr,
'arxiv_vn_nr': self.arxiv_vn_nr,
@@ -295,12 +286,9 @@ class Submission(models.Model):
template = Template(header)
return template.render(context)
-
- def header_as_li_for_authors (self):
+ def header_as_li_for_authors(self):
# includes status specification
header = ('<li>'
- #'<div class="flex-container">'
- #'<div class="flex-whitebox0">'
'<p><a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">{{ title }}</a></p>'
'<p>by {{ author_list }}</p>'
@@ -312,20 +300,20 @@ class Submission(models.Model):
header += ('</p><p>Submitted {{ submission_date }} to {{ to_journal }}'
' - latest activity: {{ latest_activity }}</p>'
'<p>Status: {{ status }}</p>'
- #'</div></div>'
'</li>')
- context = Context({'arxiv_identifier_w_vn_nr': self.arxiv_identifier_w_vn_nr,
- 'arxiv_vn_nr': self.arxiv_vn_nr,
- 'title': self.title, 'author_list': self.author_list,
- 'submission_date': self.submission_date,
- 'to_journal': journals_submit_dict[self.submitted_to_journal],
- 'latest_activity': self.latest_activity.strftime('%Y-%m-%d %H:%M'),
- 'status': submission_status_dict[self.status]})
+ context = Context({
+ 'arxiv_identifier_w_vn_nr': self.arxiv_identifier_w_vn_nr,
+ 'arxiv_vn_nr': self.arxiv_vn_nr,
+ 'title': self.title, 'author_list': self.author_list,
+ 'submission_date': self.submission_date,
+ 'to_journal': journals_submit_dict[self.submitted_to_journal],
+ 'latest_activity': self.latest_activity.strftime('%Y-%m-%d %H:%M'),
+ 'status': submission_status_dict[self.status]
+ })
template = Template(header)
return template.render(context)
-
- def refereeing_status_as_p (self):
+ def refereeing_status_as_p(self):
nr_ref_invited = RefereeInvitation.objects.filter(submission=self).count()
nr_ref_accepted = RefereeInvitation.objects.filter(submission=self, accepted=True).count()
nr_ref_declined = RefereeInvitation.objects.filter(submission=self, accepted=False).count()
@@ -349,12 +337,9 @@ class Submission(models.Model):
context = Context({})
return template.render(context)
-
- def header_as_li_for_Fellows (self):
+ def header_as_li_for_Fellows(self):
# for submissions pool
header = ('<li>'
- #'<div class="flex-container">'
- #'<div class="flex-whitebox0">'
'<p><a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">{{ title }}</a></p>'
'<p>by {{ author_list }}</p>'
@@ -364,7 +349,7 @@ class Submission(models.Model):
else:
header += ' (deprecated version {{ arxiv_vn_nr }})'
header += ('</p><p> Submitted {{ submission_date }} to {{ to_journal }}'
- ' - latest activity: {{ latest_activity }}</p>')
+ ' - latest activity: {{ latest_activity }}</p>')
if self.status == 'unassigned':
header += ('<p style="color: red">Status: {{ status }}.'
' You can volunteer to become Editor-in-charge by '
@@ -373,8 +358,7 @@ class Submission(models.Model):
else:
header += '<p>Editor-in-charge: {{ EIC }}</p><p>Status: {{ status }}</p>'
header += self.refereeing_status_as_p()
- header += (#'</div></div>'
- '</li>')
+ header += '</li>'
context = Context({'arxiv_identifier_w_vn_nr': self.arxiv_identifier_w_vn_nr,
'arxiv_vn_nr': self.arxiv_vn_nr,
'title': self.title, 'author_list': self.author_list,
@@ -386,12 +370,9 @@ class Submission(models.Model):
template = Template(header)
return template.render(context)
-
- def simple_header_as_li (self):
+ def simple_header_as_li(self):
# for Lists
header = ('<li>'
- #'<div class="flex-container">'
- #'<div class="flex-whitebox0">'
'<p>'
'<a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">{{ title }}</a></p>'
@@ -402,7 +383,6 @@ class Submission(models.Model):
else:
header += ' (deprecated version {{ arxiv_vn_nr }})'
header += ('</p>'
- #'</div></div>'
'</li>')
context = Context({'arxiv_identifier_w_vn_nr': self.arxiv_identifier_w_vn_nr,
'arxiv_vn_nr': self.arxiv_vn_nr,
@@ -410,11 +390,9 @@ class Submission(models.Model):
template = Template(header)
return template.render(context)
-
- def version_info_as_li (self):
+ def version_info_as_li(self):
# for listing all versions of a Submission
header = ('<li>'
- #'<div class="flex-whitebox0">'
'<p>'
'<a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">version {{ arxiv_vn_nr }}</a>')
@@ -423,17 +401,15 @@ class Submission(models.Model):
else:
header += ' (deprecated version {{ arxiv_vn_nr }})'
header += ('</p>'
- #'</div>'
'</li>')
context = Context({'arxiv_identifier_w_vn_nr': self.arxiv_identifier_w_vn_nr,
- 'arxiv_vn_nr': self.arxiv_vn_nr,})
+ 'arxiv_vn_nr': self.arxiv_vn_nr, })
template = Template(header)
return template.render(context)
-
- def status_info_as_table (self):
+ def status_info_as_table(self):
header = '<table><tr><td>Current status: </td><td> </td><td>{{ status }}'
- context = Context({'status': submission_status_dict[self.status],})
+ context = Context({'status': submission_status_dict[self.status], })
try:
context['citation'] = self.publication.citation_for_web_linked()
header += ' as {{ citation }}'
@@ -444,12 +420,10 @@ class Submission(models.Model):
return template.render(context)
-
######################
# Editorial workflow #
######################
-
ASSIGNMENT_BOOL = ((True, 'Accept'), (False, 'Decline'))
ASSIGNMENT_NULLBOOL = ((None, 'Response pending'), (True, 'Accept'), (False, 'Decline'))
@@ -464,6 +438,7 @@ ASSIGNMENT_REFUSAL_REASONS = (
)
assignment_refusal_reasons_dict = dict(ASSIGNMENT_REFUSAL_REASONS)
+
class EditorialAssignment(models.Model):
submission = models.ForeignKey(Submission, on_delete=models.CASCADE)
to = models.ForeignKey(Contributor, on_delete=models.CASCADE)
@@ -490,7 +465,7 @@ class EditorialAssignment(models.Model):
info += ' style="color: green"'
elif self.deprecated:
info += ' style="color: purple"'
- elif self.accepted == False:
+ elif not self.accepted:
if self.refusal_reason == 'NIE' or self.refusal_reason == 'DNP':
info += ' style="color: #CC0000"'
else:
@@ -511,8 +486,6 @@ class EditorialAssignment(models.Model):
def header_as_li_for_eic(self):
header = ('<li>'
- #'<div class="flex-container">'
- #'<div class="flex-whitebox0">'
'<p><a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">{{ title }}</a></p>'
'<p>by {{ author_list }}</p>'
@@ -521,7 +494,6 @@ class EditorialAssignment(models.Model):
'<a href="/submissions/editorial_page/{{ arxiv_identifier_w_vn_nr }}">'
'Editorial Page</a>.'
'</p>'
- #'</div></div>'
'</li>')
template = Template(header)
context = Context({'arxiv_identifier_w_vn_nr': self.submission.arxiv_identifier_w_vn_nr,
@@ -535,23 +507,20 @@ class EditorialAssignment(models.Model):
def header_as_li(self):
""" Same as above, but without link to Editorial Page. """
header = ('<li>'
- #'<div class="flex-container">'
- #'<div class="flex-whitebox0">'
'<p><a href="/submission/{{ arxiv_identifier_w_vn_nr }}" '
'class="pubtitleli">{{ title }}</a></p>'
'<p>by {{ author_list }}</p>'
'<p> (submitted {{ date }} to {{ to_journal }})</p>'
'<p>Status: {{ status }}</p>'
- #'</div></div>'
- '</li>'
- )
+ '</li>')
template = Template(header)
- context = Context({'arxiv_identifier_w_vn_nr': self.submission.arxiv_identifier_w_vn_nr,
- 'title': self.submission.title,
- 'author_list': self.submission.author_list,
- 'date': self.submission.submission_date,
- 'to_journal': journals_submit_dict[self.submission.submitted_to_journal],
- 'status': submission_status_dict[self.submission.status]})
+ context = Context({
+ 'arxiv_identifier_w_vn_nr': self.submission.arxiv_identifier_w_vn_nr,
+ 'title': self.submission.title,
+ 'author_list': self.submission.author_list,
+ 'date': self.submission.submission_date,
+ 'to_journal': journals_submit_dict[self.submission.submitted_to_journal],
+ 'status': submission_status_dict[self.submission.status]})
return template.render(context)
@@ -574,32 +543,14 @@ class RefereeInvitation(models.Model):
date_responded = models.DateTimeField(blank=True, null=True)
refusal_reason = models.CharField(max_length=3, choices=ASSIGNMENT_REFUSAL_REASONS,
blank=True, null=True)
- fulfilled = models.BooleanField(default=False) # True if a Report has been submitted
- cancelled = models.BooleanField(default=False) # True if EIC has deactivated invitation
+ fulfilled = models.BooleanField(default=False) # True if a Report has been submitted
+ cancelled = models.BooleanField(default=False) # True if EIC has deactivated invitation
def __str__(self):
return (self.first_name + ' ' + self.last_name + ' to referee ' +
self.submission.title[:30] + ' by ' + self.submission.author_list[:30] +
', invited on ' + self.date_invited.strftime('%Y-%m-%d'))
- # def summary_as_li(self):
- # context = Context({'first_name': self.first_name, 'last_name': self.last_name,
- # 'date_invited': self.date_invited.strftime('%Y-%m-%d %H:%M')})
- # output = '<li>{{ first_name }} {{ last_name }}, invited {{ date_invited }}, '
- # if self.accepted is not None:
- # if self.accepted:
- # output += '<strong style="color: green">task accepted</strong> '
- # else:
- # output += '<strong style="color: red">task declined</strong> '
- # output += '{{ date_responded }}'
- # context['date_responded'] = self.date_responded.strftime('%Y-%m-%d %H:%M')
- # else:
- # output += 'response pending'
- # if self.fulfilled:
- # output += '; Report has been delivered'
- # template = Template(output)
- # return template.render(context)
-
def summary_as_tds(self):
context = Context({'first_name': self.first_name, 'last_name': self.last_name,
'date_invited': self.date_invited.strftime('%Y-%m-%d %H:%M')})
@@ -649,7 +600,7 @@ quality_spec_dict = dict(QUALITY_SPEC)
RANKING_CHOICES = (
- (101, '-'), # Only values between 0 and 100 are kept, anything outside those limits is discarded.
+ (101, '-'), # Only values between 0 and 100 are kept, anything outside those limits is discarded.
(100, 'top'), (80, 'high'), (60, 'good'), (40, 'ok'), (20, 'low'), (0, 'poor')
)
ranking_choices_dict = dict(RANKING_CHOICES)
@@ -664,6 +615,7 @@ REPORT_REC = (
)
report_rec_dict = dict(REPORT_REC)
+
class Report(models.Model):
""" Both types of reports, invited or contributed. """
# status: see forms.py:REPORT_REFUSAL_CHOICES
@@ -706,7 +658,6 @@ class Report(models.Model):
verbose_name='optional remarks for the Editors only')
anonymous = models.BooleanField(default=True, verbose_name='Publish anonymously')
-
def __str__(self):
return (self.author.user.first_name + ' ' + self.author.user.last_name + ' on ' +
self.submission.title[:50] + ' by ' + self.submission.author_list[:50])
@@ -726,7 +677,6 @@ class Report(models.Model):
template = Template(output)
return template.render(context)
-
def print_contents(self):
context = Context({'strengths': self.strengths, 'weaknesses': self.weaknesses,
'report': self.report, 'requested_changes': self.requested_changes})
@@ -750,14 +700,14 @@ class Report(models.Model):
template = Template(output)
return template.render(context)
-
def print_contents_for_editors(self):
- context = Context({'id': self.id, 'author_id': self.author.id,
- 'author_first_name': self.author.user.first_name,
- 'author_last_name': self.author.user.last_name,
- 'date_submitted': self.date_submitted.strftime("%Y-%m-%d"),
- 'remarks_for_editors': self.remarks_for_editors,
- })
+ context = Context({
+ 'id': self.id, 'author_id': self.author.id,
+ 'author_first_name': self.author.user.first_name,
+ 'author_last_name': self.author.user.last_name,
+ 'date_submitted': self.date_submitted.strftime("%Y-%m-%d"),
+ 'remarks_for_editors': self.remarks_for_editors,
+ })
output = '<div class="reportid">\n'
output += '<h3><a id="report_id{{ id }}"></a>'
if self.anonymous:
@@ -789,6 +739,7 @@ ED_COMM_CHOICES = (
)
ed_comm_choices_dict = dict(ED_COMM_CHOICES)
+
class EditorialCommunication(models.Model):
"""
Each individual communication between Editor-in-charge
@@ -801,7 +752,7 @@ class EditorialCommunication(models.Model):
timestamp = models.DateTimeField(default=timezone.now)
text = models.TextField()
- def __str__ (self):
+ def __str__(self):
output = self.comtype
if self.referee is not None:
output += ' ' + self.referee.user.first_name + ' ' + self.referee.user.last_name
@@ -839,7 +790,6 @@ class EditorialCommunication(models.Model):
return template.render(context)
-
############################
# Editorial Recommendation #
############################
@@ -855,11 +805,11 @@ class EICRecommendation(models.Model):
verbose_name='optional remarks for the Editorial College')
recommendation = models.SmallIntegerField(choices=REPORT_REC)
# Editorial Fellows who have assessed this recommendation:
- eligible_to_vote = models.ManyToManyField (Contributor, blank=True,
- related_name='eligible_to_vote')
- voted_for = models.ManyToManyField (Contributor, blank=True, related_name='voted_for')
- voted_against = models.ManyToManyField (Contributor, blank=True, related_name='voted_against')
- voted_abstain = models.ManyToManyField (Contributor, blank=True, related_name='voted_abstain')
+ eligible_to_vote = models.ManyToManyField(Contributor, blank=True,
+ related_name='eligible_to_vote')
+ voted_for = models.ManyToManyField(Contributor, blank=True, related_name='voted_for')
+ voted_against = models.ManyToManyField(Contributor, blank=True, related_name='voted_against')
+ voted_abstain = models.ManyToManyField(Contributor, blank=True, related_name='voted_abstain')
voting_deadline = models.DateTimeField('date submitted', default=timezone.now)
def __str__(self):
@@ -881,22 +831,23 @@ class EICRecommendation(models.Model):
def print_for_authors(self):
output = ('<h3>Date: {{ date_submitted }}</h3>'
'<h3>Remarks for authors</h3>'
- '<p>{{ remarks_for_authors }}</p>'
+ '<p>{{ remarks_for_authors }}</p>'
'<h3>Requested changes</h3>'
'<p>{{ requested_changes }}</p>'
'<h3>Recommendation</h3>'
'<p>{{ recommendation }}</p>')
- context = Context({'date_submitted': self.date_submitted.strftime('%Y-%m-%d %H:%M'),
- 'remarks_for_authors': self.remarks_for_authors,
- 'requested_changes': self.requested_changes,
- 'recommendation': report_rec_dict[self.recommendation],})
+ context = Context({
+ 'date_submitted': self.date_submitted.strftime('%Y-%m-%d %H:%M'),
+ 'remarks_for_authors': self.remarks_for_authors,
+ 'requested_changes': self.requested_changes,
+ 'recommendation': report_rec_dict[self.recommendation], })
template = Template(output)
return template.render(context)
def print_for_Fellows(self):
output = ('<h3>By {{ Fellow }}, formulated on {{ date_submitted }}</h3>'
'<h3>Remarks for authors</h3>'
- '<p>{{ remarks_for_authors }}</p>'
+ '<p>{{ remarks_for_authors }}</p>'
'<h3>Requested changes</h3>'
'<p>{{ requested_changes }}</p>'
'<h3>Remarks for Editorial College</h3>'
@@ -911,6 +862,6 @@ class EICRecommendation(models.Model):
'remarks_for_authors': self.remarks_for_authors,
'requested_changes': self.requested_changes,
'remarks_for_editorial_college': self.remarks_for_editorial_college,
- 'recommendation': report_rec_dict[self.recommendation],})
+ 'recommendation': report_rec_dict[self.recommendation], })
template = Template(output)
return template.render(context)
diff --git a/submissions/templates/submissions/assignments.html b/submissions/templates/submissions/assignments.html
new file mode 100644
index 0000000000000000000000000000000000000000..9fa1e95e0cdad78833979b564e726cbe4311fa2b
--- /dev/null
+++ b/submissions/templates/submissions/assignments.html
@@ -0,0 +1,107 @@
+{% extends 'scipost/base.html' %}
+
+{% block pagetitle %}: Assignments{% endblock pagetitle %}
+
+{% block bodysup %}
+
+<script>
+$(document).ready(function(){
+
+ $('#ref_reason').hide();
+
+ $('#id_accept').on('change', function() {
+ if ($('#id_accept_1').is(':checked')) {
+ $('#ref_reason').show();
+ }
+ else {
+ $('#ref_reason').hide();
+ }
+ });
+
+ $(".submitRemarkForm").hide();
+
+ $(".submitRemarkButton").click( function() {
+ $(this).next("div").toggle();
+ });
+ });
+
+</script>
+
+{% load guardian_tags %}
+{% load scipost_extras %}
+{% load submissions_extras %}
+
+
+{% if assignments_to_consider %}
+<section>
+
+ {% for assignment_to_consider in assignments_to_consider %}
+
+ <div class="flex-greybox">
+ <h1>Assignment request: can you act as Editor-in-charge? (see below to accept/decline):</h1>
+ </div>
+ <br>
+ <hr>
+
+ {{ assignment_to_consider.submission.header_as_table }}
+ <br />
+ <h4>Abstract:</h4>
+ <p>{{ assignment_to_consider.submission.abstract }}</p>
+ <br/>
+
+ <hr>
+ <div class="flex-greybox">
+ <h1>Accept or Decline this Assignment</h1>
+ </div>
+ <h3>By accepting, you will be required to start a refereeing round on the next screen.</h3>
+ <form action="{% url 'submissions:accept_or_decline_assignment_ack' assignment_id=assignment_to_consider.id %}" method="post">
+ {% csrf_token %}
+ {{ consider_assignment_form.accept }}
+ <div id="ref_reason">
+ <p>Please select a reason for declining this assignment:</p>
+ {{ consider_assignment_form.refusal_reason }}
+ </div>
+ <input type="submit" value="Submit" />
+ </form>
+
+ <hr class="hr6"/>
+ {% endfor %}
+
+</section>
+<hr class="hr12"/>
+{% endif %}
+
+
+{% if current_assignments %}
+<section>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h1>Your current assignments:</h1>
+ </div>
+ </div>
+ <ul>
+ {% for assignment in current_assignments %}
+ {{ assignment.submission.header_as_li_for_Fellows }}
+ <div class="flex-container">
+ <div class-"flex-whitebox" style="background-color: #ffaaaa;">
+ <h3>Required actions:</h3>
+ <ul>
+ {% for todoitem in assignment.submission|required_actions %}
+ <li>{{ todoitem }}</li>
+ {% endfor %}
+ </ul>
+ </div>
+ </div>
+ <h4><a href="{% url 'submissions:editorial_page' arxiv_identifier_w_vn_nr=assignment.submission.arxiv_identifier_w_vn_nr %}">
+ Go to this Submission's Editorial Page</a></h4>
+ {% endfor %}
+ </ul>
+</section>
+{% else %}
+<section>
+ <p>You currently have no assignments to take care of.</p>
+</section>
+{% endif %}
+
+
+{% endblock bodysup %}
diff --git a/submissions/templates/submissions/editorial_page.html b/submissions/templates/submissions/editorial_page.html
index e903d01779e7ac2a4fc009ec46718cef76451fde..989af1cedd256f936cf5fc3059bba6ad5655488e 100644
--- a/submissions/templates/submissions/editorial_page.html
+++ b/submissions/templates/submissions/editorial_page.html
@@ -5,6 +5,7 @@
{% block headsup %}
{% load scipost_extras %}
+{% load submissions_extras %}
{% endblock headsup %}
@@ -81,7 +82,20 @@
</div>
<h3>Status:</h3>
{{ submission.status_info_as_table }}
+ {% if submission|required_actions %}
+ <div class="flex-container">
+ <div class-"flex-whitebox" style="background-color: #ffaaaa;">
+ <h3>Required actions:</h3>
+ <ul>
+ {% for todoitem in submission|required_actions %}
+ <li>{{ todoitem }}</li>
+ {% endfor %}
+ </ul>
+ </div>
+ </div>
+ {% endif %}
<hr/>
+
<h3>Refereeing status summary:</h3>
{{ submission.refereeing_status_as_p }}
diff --git a/submissions/templates/submissions/pool.html b/submissions/templates/submissions/pool.html
index d388a60efb4da5ba4ab747547bc9f106b30f0e62..6f7db2515e4d59490572adf53ae5429908a88898 100644
--- a/submissions/templates/submissions/pool.html
+++ b/submissions/templates/submissions/pool.html
@@ -34,6 +34,14 @@ $(document).ready(function(){
{% if request.user|is_in_group:'Editorial Administrators' and recommendations_undergoing_voting %}
<section>
+ <div class="flex-container">
+ <div class="flex-whitebox">
+ <h3>Administrative actions on recommendations undergoing voting:</h3>
+ <ul>
+ <li>To send an email reminder to each Fellow with at least one voting duty, <a href="{% url 'submissions:remind_Fellows_to_vote' %}">click here</a></li>
+ </ul>
+ </div>
+ </div>
<div class="flex-container">
<div class="flex-greybox">
<h1>Recommendations undergoing voting</h1>
@@ -220,6 +228,15 @@ $(document).ready(function(){
</div>
</div>
+ <h3>Submissions by status:</h3>
+ <ul>
+ {% for key, val in submission_status %}
+ <li><a href="{% url 'submissions:submissions_by_status' status=key %}">{{ val }}</a></li>
+ {% endfor %}
+ </ul>
+ <hr class="hr6"/>
+
+
<ul>
{% for sub in submissions_in_pool %}
{% if request.user|is_not_author_of_submission:sub.arxiv_identifier_w_vn_nr %}
@@ -243,6 +260,19 @@ $(document).ready(function(){
</div>
{% get_obj_perms request.user for sub as "sub_perms" %}
{% if "can_take_editorial_actions" in sub_perms or request.user|is_in_group:'Editorial Administrators' %}
+ <br/>
+ {% if sub|required_actions %}
+ <div class="flex-container">
+ <div class-"flex-whitebox" style="background-color: #ffaaaa;">
+ <h3>Required actions:</h3>
+ <ul>
+ {% for todoitem in sub|required_actions %}
+ <li>{{ todoitem }}</li>
+ {% endfor %}
+ </ul>
+ </div>
+ </div>
+ {% endif %}
<h4><a href="{% url 'submissions:editorial_page' arxiv_identifier_w_vn_nr=sub.arxiv_identifier_w_vn_nr %}">
Go to this Submission's Editorial Page</a></h4>
{% endif %}
diff --git a/submissions/templates/submissions/submissions_by_status.html b/submissions/templates/submissions/submissions_by_status.html
new file mode 100644
index 0000000000000000000000000000000000000000..82a4babfa350f766ac8af7373d850a4815e0b7b7
--- /dev/null
+++ b/submissions/templates/submissions/submissions_by_status.html
@@ -0,0 +1,98 @@
+{% extends 'scipost/base.html' %}
+
+{% block pagetitle %}: Submissions by status{% endblock pagetitle %}
+
+{% block bodysup %}
+
+<script>
+$(document).ready(function(){
+
+ $('#ref_reason').hide();
+
+ $('#id_accept').on('change', function() {
+ if ($('#id_accept_1').is(':checked')) {
+ $('#ref_reason').show();
+ }
+ else {
+ $('#ref_reason').hide();
+ }
+ });
+
+ $(".submitRemarkForm").hide();
+
+ $(".submitRemarkButton").click( function() {
+ $(this).next("div").toggle();
+ });
+ });
+
+</script>
+
+{% load guardian_tags %}
+{% load scipost_extras %}
+{% load submissions_extras %}
+
+
+<section>
+ <div class="flex-container">
+ <div class="flex-greybox">
+ <h1>SciPost Submissions with status {{ status }}</h1>
+ </div>
+ </div>
+
+ <ul>
+ {% for sub in submissions_of_status %}
+ {% if request.user|is_not_author_of_submission:sub.arxiv_identifier_w_vn_nr %}
+ <br/>
+ {{ sub.header_as_li_for_Fellows }}
+ {% if sub.remark_set.all %}
+ <h4>Remarks on this submission:</h4>
+ <ul>
+ {% for rem in sub.remark_set.all %}
+ {{ rem.as_li }}
+ {% endfor %}
+ </ul>
+ {% endif %}
+ <button class="submitRemarkButton" id="remarkButton{{ submission.id }}">Add a remark on this Submission</button>
+ <div class="submitRemarkForm" id="remarkForm{{ submission.id }}">
+ <form action="{% url 'submissions:add_remark' arxiv_identifier_w_vn_nr=sub.arxiv_identifier_w_vn_nr %}" method="post">
+ {% csrf_token %}
+ {{ remark_form.as_p }}
+ <input type="submit" value="Submit" />
+ </form>
+ </div>
+ {% get_obj_perms request.user for sub as "sub_perms" %}
+ {% if "can_take_editorial_actions" in sub_perms or request.user|is_in_group:'Editorial Administrators' %}
+ <h4><a href="{% url 'submissions:editorial_page' arxiv_identifier_w_vn_nr=sub.arxiv_identifier_w_vn_nr %}">
+ Go to this Submission's Editorial Page</a></h4>
+ {% endif %}
+ {% if perms.scipost.can_assign_submissions %}
+ {% if sub.editorialassignment_set.all %}
+ <h4>EIC Assignment requests:</h4>
+ <ul>
+ {% for assignment in sub.editorialassignment_set.all %}
+ {{ assignment.info_as_li }}
+ {% endfor %}
+ </ul>
+ {% endif %}
+ {% if sub.editor_in_charge == None %}
+ <h4>Actions:</h4>
+ <ul>
+ <li><a href="{% url 'submissions:assign_submission' arxiv_identifier_w_vn_nr=sub.arxiv_identifier_w_vn_nr %}">Send a new assignment request</a></li>
+ <li><a href="{% url 'submissions:assignment_failed' arxiv_identifier_w_vn_nr=sub.arxiv_identifier_w_vn_nr %}">Close pre-screening: failure to find EIC</a></li>
+ </ul>
+ {% endif %}
+ {% endif %}
+ {% if request.user|is_in_group:'Editorial Administrators' %}
+ <h4><a href="{% url 'submissions:communication' arxiv_identifier_w_vn_nr=sub.arxiv_identifier_w_vn_nr comtype='StoE' %}">Send a communication to the Editor-in-charge</a></h4>
+ {% if sub.status == 'accepted' %}
+ <h4>After proofs have been accepted, you can
+ <a href="{% url 'journals:initiate_publication' %}">initiate the publication process</a> (leads to the validation page)</h4>
+ {% endif %}
+ {% endif %}
+ {% endif %}
+ {% endfor %}
+ </ul>
+
+</section>
+
+{% endblock bodysup %}
diff --git a/submissions/templatetags/submissions_extras.py b/submissions/templatetags/submissions_extras.py
index 53fa07743aaf5d4cb3b08fa633fbf025d538611d..0ae2ea8d199f6414894e0256bc3a01955fba13eb 100644
--- a/submissions/templatetags/submissions_extras.py
+++ b/submissions/templatetags/submissions_extras.py
@@ -1,5 +1,10 @@
+import datetime
+
from django import template
+from django.utils import timezone
+from django.utils.timesince import timesince
+from submissions.models import SUBMISSION_STATUS_OUT_OF_POOL
from submissions.models import Submission
register = template.Library()
@@ -19,3 +24,57 @@ def is_viewable_by_authors(recommendation):
return recommendation.submission.status in ['revision_requested', 'resubmitted',
'accepted', 'rejected',
'published', 'withdrawn']
+
+@register.filter(name='required_actions')
+def required_actions(submission):
+ """
+ This method returns a list of required actions on a Submission.
+ Each list element is a textual statement.
+ """
+ if (submission.status in SUBMISSION_STATUS_OUT_OF_POOL
+ or submission.status == 'revision_requested'
+ or submission.eicrecommendation_set.exists()):
+ return []
+ todo = []
+ for comment in submission.comment_set.all():
+ if comment.status == 0:
+ todo.append('A Comment from %s has been delivered but is not yet vetted. '
+ 'Please vet it.' % comment.author)
+ nr_ref_inv = submission.refereeinvitation_set.count()
+ if (submission.is_resubmission and nr_ref_inv == 0
+ and not submission.eicrecommendation_set.exists()):
+ todo.append('This resubmission requires attention: either (re)invite referees '
+ 'or formulate an Editorial Recommendation.')
+ if nr_ref_inv == 0 and not submission.is_resubmission:
+ todo.append('No Referees have yet been invited. '
+ 'At least 3 should be.')
+ elif nr_ref_inv < 3 and not submission.is_resubmission:
+ todo.append('Only %s Referees have been invited. '
+ 'At least 3 should be.' % nr_ref_inv)
+ for ref_inv in submission.refereeinvitation_set.all():
+ refname = ref_inv.last_name + ', ' + ref_inv.first_name
+ if ref_inv.referee:
+ refname = str(ref_inv.referee)
+ timelapse = timezone.now() - ref_inv.date_invited
+ timeleft = submission.reporting_deadline - timezone.now()
+ if (ref_inv.accepted is None and not ref_inv.cancelled
+ and timelapse > datetime.timedelta(days=3)):
+ todo.append('Referee %s has not responded for %s days. '
+ 'Consider sending a reminder '
+ 'or cancelling the invitation.' % (refname, str(timelapse.days)))
+ if (ref_inv.accepted and not ref_inv.fulfilled and not ref_inv.cancelled
+ and timeleft < datetime.timedelta(days=7)):
+ todo.append('Referee %s has accepted to send a Report, '
+ 'but not yet delivered it (with %s days left). '
+ 'Consider sending a reminder or cancelling the invitation.'
+ % (refname, str(timeleft.days)))
+ if submission.reporting_deadline < timezone.now():
+ todo.append('The refereeing deadline has passed. Please either extend it, '
+ 'or formulate your Editorial Recommendation if at least '
+ 'one Report has been received.')
+ reports = submission.report_set.all()
+ for report in reports:
+ if report.status == 0:
+ todo.append('The Report from %s has been delivered but is not yet vetted. '
+ 'Please vet it.' % report.author)
+ return todo
diff --git a/submissions/urls.py b/submissions/urls.py
index 58b102c967d8b6ea6c1278c0b162fa48d9387500..1b3ee7bbc3fad480b1f0ac5698a521abfeae6603 100644
--- a/submissions/urls.py
+++ b/submissions/urls.py
@@ -25,6 +25,8 @@ urlpatterns = [
# url(r'^submit_manuscript$', views.submit_manuscript, name='submit_manuscript'),
url(r'^submit_manuscript$', views.SubmissionCreateView.as_view(), name='submit_manuscript'),
url(r'^pool$', views.pool, name='pool'),
+ url(r'^submissions_by_status/(?P<status>[a-zA-Z_]+)$',
+ views.submissions_by_status, name='submissions_by_status'),
url(r'^add_remark/(?P<arxiv_identifier_w_vn_nr>[0-9]{4,}.[0-9]{5,}v[0-9]{1,2})$',
views.add_remark, name='add_remark'),
# Assignment of Editor-in-charge
@@ -40,6 +42,7 @@ urlpatterns = [
views.assignment_failed, name='assignment_failed'),
# Editorial workflow and refereeing
url(r'^editorial_workflow$', views.editorial_workflow, name='editorial_workflow'),
+ url(r'^assignments$', views.assignments, name='assignments'),
url(r'^editorial_page/(?P<arxiv_identifier_w_vn_nr>[0-9]{4,}.[0-9]{5,}v[0-9]{1,2})$',
views.editorial_page, name='editorial_page'),
url(r'^select_referee/(?P<arxiv_identifier_w_vn_nr>[0-9]{4,}.[0-9]{5,}v[0-9]{1,2})$',
@@ -79,6 +82,8 @@ urlpatterns = [
# Voting
url(r'^prepare_for_voting/(?P<rec_id>[0-9]+)$', views.prepare_for_voting, name='prepare_for_voting'),
url(r'^vote_on_rec/(?P<rec_id>[0-9]+)$', views.vote_on_rec, name='vote_on_rec'),
+ url(r'^remind_Fellows_to_vote$', views.remind_Fellows_to_vote,
+ name='remind_Fellows_to_vote'),
# Editorial Administration
url(r'fix_College_decision/(?P<rec_id>[0-9]+)$', views.fix_College_decision,
name='fix_College_decision'),
diff --git a/submissions/utils.py b/submissions/utils.py
index 6d2e0c65d65a5cf5bf2b470d2210ecf6e9dc7492..20690867f50cfa64766cbb573b2ad2b38b591c59 100644
--- a/submissions/utils.py
+++ b/submissions/utils.py
@@ -19,7 +19,6 @@ class SubmissionUtils(object):
for var_name in dict:
setattr(cls, var_name, dict[var_name])
-
@classmethod
def deprecate_other_assignments(cls):
"""
@@ -44,7 +43,6 @@ class SubmissionUtils(object):
atd.deprecated = True
atd.save()
-
@classmethod
def send_authors_submission_ack_email(cls):
""" Requires loading 'submission' attribute. """
@@ -78,7 +76,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: Submission received', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -88,7 +85,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_authors_resubmission_ack_email(cls):
""" Requires loading 'submission' attribute. """
@@ -119,7 +115,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: Resubmission received', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -129,7 +124,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_assignment_request_email(cls):
""" Requires loading 'assignment' attribute. """
@@ -174,7 +168,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: potential Submission assignment', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -184,7 +177,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_EIC_appointment_email(cls):
""" Requires loading 'assignment' attribute. """
@@ -199,8 +191,8 @@ class SubmissionUtils(object):
+ cls.assignment.submission.arxiv_identifier_w_vn_nr
+ ' (also accessible from your personal page '
'https://scipost.org/personal_page under the Editorial Actions tab). '
- 'In particular, you should now invite at least 3 referees; you might want to '
- 'make sure you are aware of the '
+ 'In particular, you should now invite at least 3 referees; you might want to'
+ ' make sure you are aware of the '
'detailed procedure described in the Editorial College by-laws at '
'https://scipost.org/EdCol_by-laws.'
'\n\nMany thanks in advance for your collaboration,'
@@ -233,7 +225,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: assignment as EIC', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -243,7 +234,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_EIC_reappointment_email(cls):
""" Requires loading 'submission' attribute. """
@@ -306,7 +296,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_author_prescreening_passed_email(cls):
""" Requires loading 'assignment' attribute. """
@@ -376,7 +365,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: pre-screening passed', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -386,7 +374,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def assignment_failed_email_authors(cls):
""" Requires loading 'submission' attribute. """
@@ -401,8 +388,8 @@ class SubmissionUtils(object):
if len(cls.personal_message) > 3:
email_text += '\n\n' + cls.personal_message
email_text += ('\n\nWe nonetheless thank you very much for your contribution.'
- '\n\nSincerely,' +
- '\n\nThe SciPost Team.')
+ '\n\nSincerely,' +
+ '\n\nThe SciPost Team.')
email_text_html = (
'<p>Dear {{ title }} {{ last_name }},</p>'
'<p>Your recent Submission to SciPost,</p>'
@@ -428,7 +415,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: pre-screening not passed', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -438,7 +424,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_refereeing_invitation_email(cls):
"""
@@ -514,7 +499,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: refereeing request', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -525,7 +509,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_ref_reminder_email(cls):
"""
@@ -615,7 +598,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: reminder (refereeing request and registration invitation)', email_text,
'SciPost Submissions <submissions@scipost.org>',
@@ -626,7 +608,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_ref_cancellation_email(cls):
"""
@@ -685,7 +666,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: report no longer needed', email_text,
'SciPost Submissions <submissions@scipost.org>',
@@ -696,7 +676,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def email_referee_response_to_EIC(cls):
""" Requires loading 'invitation' attribute. """
@@ -712,7 +691,7 @@ class SubmissionUtils(object):
email_text += 'accepted '
email_text_html += 'accepted '
email_subject = 'SciPost: referee accepts to review'
- elif cls.invitation.accepted == False:
+ elif not cls.invitation.accepted:
email_text += ('declined (due to reason: '
+ assignment_refusal_reasons_dict[cls.invitation.refusal_reason] + ') ')
email_text_html += 'declined (due to reason: {{ reason }}) '
@@ -723,7 +702,7 @@ class SubmissionUtils(object):
email_text_html += (
'to referee Submission</p>'
'<p>{{ sub_title }}</p>\n<p>by {{ author_list }}.</p>')
- if cls.invitation.accepted == False:
+ if not cls.invitation.accepted:
email_text += ('\n\nPlease invite another referee from the Submission\'s editorial page '
'at https://scipost.org/submissions/editorial_page/'
+ cls.invitation.submission.arxiv_identifier_w_vn_nr + '.')
@@ -749,7 +728,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
email_subject, email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -759,7 +737,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def email_EIC_report_delivered(cls):
""" Requires loading 'report' attribute. """
@@ -795,7 +772,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: Report delivered', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -805,14 +781,13 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def acknowledge_report_email(cls):
""" Requires loading 'report' attribute. """
email_text = ('Dear ' + title_dict[cls.report.author.title] + ' ' +
cls.report.author.user.last_name + ','
'\n\nMany thanks for your Report on Submission\n\n' +
- cls.report.submission.title + ' by '
+ cls.report.submission.title + ' by '
+ cls.report.submission.author_list + '.')
email_text_html = (
'<p>Dear {{ ref_title }} {{ ref_last_name }},</p>'
@@ -878,7 +853,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: Report acknowledgement', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -889,7 +863,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_author_report_received_email(cls):
""" Requires loading 'report' attribute. """
@@ -933,7 +906,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: Report received on your Submission', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -943,7 +915,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_author_comment_received_email(cls):
""" Requires loading 'submission' attribute. """
@@ -977,7 +948,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: Comment received on your Submission', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -988,7 +958,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_communication_email(cls):
"""
@@ -1006,8 +975,6 @@ class SubmissionUtils(object):
cls.communication.submission.editor_in_charge.user.last_name)
further_action_page = ('https://scipost.org/submission/editorial_page/'
+ cls.communication.submission.arxiv_identifier_w_vn_nr)
- #if cls.communication.comtype == 'AtoE':
- # bcc_emails.append(cls.communication.submission.submitted_by.user.email) # BUG: must not happen!
if cls.communication.comtype == 'RtoE':
bcc_emails.append(cls.communication.referee.user.email)
bcc_emails.append('submissions@scipost.org')
@@ -1053,7 +1020,6 @@ class SubmissionUtils(object):
reply_to=['submissions@scipost.org'])
emailmessage.send(fail_silently=False)
-
@classmethod
def send_author_revision_requested_email(cls):
""" Requires loading 'submission' and 'recommendation' attributes. """
@@ -1074,8 +1040,8 @@ class SubmissionUtils(object):
email_text += 'major'
email_text_html += 'major'
email_text += (' revision.'
- '\n\nYou can view it at the Submission Page '
- 'https://scipost.org/submission/'
+ '\n\nYou can view it at the Submission Page '
+ 'https://scipost.org/submission/'
+ cls.submission.arxiv_identifier_w_vn_nr + '. '
'Note that the recommendation is viewable only by '
'the registered authors of the submission.'
@@ -1113,7 +1079,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: revision requested', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -1124,7 +1089,6 @@ class SubmissionUtils(object):
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
-
@classmethod
def send_author_College_decision_email(cls):
""" Requires loading 'submission' and 'recommendation' attributes. """
@@ -1147,7 +1111,7 @@ class SubmissionUtils(object):
email_text_html += (
'<p>We are pleased to inform you that your Submission '
'has been accepted for publication in <strong>{{ journal }}</strong>')
- if cls.recommendation.recommendation == 1 and False: # Temporary deactivation of Select
+ if cls.recommendation.recommendation == 1 and False: # Temporary deactivation of Select
email_text += (', with a promotion to Select. We warmly congratulate you '
'on this achievement, which is reserved to papers deemed in '
'the top ten percent of papers we publish.')
@@ -1162,8 +1126,8 @@ class SubmissionUtils(object):
'production team, who will soon send you proofs '
'to check before final publication.')
email_text_html += ('\n<p>Your manuscript will now be taken charge of by our '
- 'production team, who will soon send you proofs '
- 'to check before final publication.</p>')
+ 'production team, who will soon send you proofs '
+ 'to check before final publication.</p>')
elif cls.recommendation.recommendation == -3:
email_text += ('We are sorry to inform you that your Submission '
@@ -1173,12 +1137,9 @@ class SubmissionUtils(object):
+ cls.submission.arxiv_identifier_w_vn_nr + '. '
'Note that these details are viewable only by '
'the registered authors of the submission.'
- #'\n\nUnless you explicitly request otherwise, we will deactivate your '
- #'Submission\'s Page within one week and remove it from public view.'
'\n\nThis Submission Page has now been removed '
'from general public view; if you wish, you can email us and '
- 'request to make it publicly visible again.'
- )
+ 'request to make it publicly visible again.')
email_text_html += (
'<p>We are sorry to inform you that your Submission '
'has not been accepted for publication.</p>'
@@ -1187,8 +1148,6 @@ class SubmissionUtils(object):
'{{ arxiv_identifier_w_vn_nr }}">Submission\'s Page</a>. '
'Note that these details are viewable only by '
'the registered authors of the submission.</p>'
- #'<p>Unless you explicitly request otherwise, we will deactivate your '
- #'Submission\'s Page within one week and remove it from public view.</p>'
'<p>This Submission Page has now been removed '
'from general public view; if you wish, you can email us and '
'request to make it publicly visible again.</p>'
@@ -1210,7 +1169,6 @@ class SubmissionUtils(object):
email_text_html += '<br/>' + EMAIL_FOOTER
html_template = Template(email_text_html)
html_version = html_template.render(email_context)
- #emailmessage = EmailMessage(
emailmessage = EmailMultiAlternatives(
'SciPost: College decision', email_text,
'SciPost Editorial Admin <submissions@scipost.org>',
@@ -1220,3 +1178,39 @@ class SubmissionUtils(object):
reply_to=['submissions@scipost.org'])
emailmessage.attach_alternative(html_version, 'text/html')
emailmessage.send(fail_silently=False)
+
+ @classmethod
+ def send_Fellows_voting_reminder_email(cls):
+ """
+ Requires loading 'Fellow_emails' attribute, which is a list of email addresses.
+ """
+ email_text = ('Dear Fellow,'
+ '\n\nYou have pending voting duties in the SciPost '
+ 'submissions pool at https://scipost.org/submissions/pool'
+ ' (also accessible from your personal page '
+ 'https://scipost.org/personal_page under the Editorial Actions tab). '
+ 'Could you please have a quick look within the next couple of days, '
+ 'so we can finish processing these submissions?'
+ '\n\nMany thanks in advance,'
+ '\n\nThe SciPost Team.')
+ email_text_html = (
+ '<p>Dear Fellow,</p>'
+ '<p>You have pending voting duties in the SciPost '
+ 'submissions pool https://scipost.org/submissions/pool'
+ ' (also accessible from your personal page '
+ 'https://scipost.org/personal_page under the Editorial Actions tab).</p>'
+ '<p>Could you please have a quick look within the next couple of days, '
+ 'so we can finish processing these submissions?</p>'
+ '<p>Many thanks in advance,</p>'
+ '<p>The SciPost Team.</p><br/>' + EMAIL_FOOTER)
+ email_context = Context({})
+ html_template = Template(email_text_html)
+ html_version = html_template.render(email_context)
+ emailmessage = EmailMultiAlternatives(
+ 'SciPost: voting duties', email_text,
+ 'SciPost Editorial Admin <admin@scipost.org>',
+ to=['admin@scipost.org'],
+ bcc=cls.Fellow_emails,
+ reply_to=['admin@scipost.org'])
+ emailmessage.attach_alternative(html_version, 'text/html')
+ emailmessage.send(fail_silently=False)
diff --git a/submissions/views.py b/submissions/views.py
index 9895f12dd320b32beae03e0848976623603f316e..e36b8a53524b143369d24b5717aa3691cf51d58e 100644
--- a/submissions/views.py
+++ b/submissions/views.py
@@ -1,29 +1,31 @@
import datetime
import feedparser
-import re
-import requests
-import sys
-from django.contrib.auth import authenticate, login, logout
from django.contrib.auth.decorators import login_required, permission_required
-from django.contrib.auth.models import User, Group, Permission
+from django.contrib.auth.models import Group
from django.core.exceptions import PermissionDenied
-from django.core.mail import EmailMessage
from django.core.urlresolvers import reverse
from django.db import transaction
-from django.db.models import Avg
-from django.http import HttpResponse, HttpResponseRedirect
+from django.http import HttpResponseRedirect
from django.shortcuts import get_object_or_404, render, redirect
+from django.template import Template, Context
from django.utils import timezone
-from django.utils.safestring import mark_safe
-from django.views.decorators.csrf import csrf_protect
from guardian.decorators import permission_required_or_403
from guardian.shortcuts import assign_perm
-from django.utils.decorators import method_decorator
-from .models import *
-from .forms import *
+# from .models import *
+# from .forms import *
+from .models import Submission, EICRecommendation, EditorialAssignment,\
+ RefereeInvitation, Report, EditorialCommunication,\
+ SUBMISSION_STATUS_PUBLICLY_UNLISTED, SUBMISSION_STATUS_VOTING_DEPRECATED,\
+ SUBMISSION_STATUS_PUBLICLY_INVISIBLE, SUBMISSION_STATUS_OUT_OF_POOL,\
+ SUBMISSION_STATUS, submission_status_dict, ed_comm_choices_dict
+from .forms import SubmissionIdentifierForm, SubmissionForm, SubmissionSearchForm,\
+ RecommendationVoteForm, ConsiderAssignmentForm, AssignSubmissionForm,\
+ SetRefereeingDeadlineForm, RefereeSelectForm, RefereeRecruitmentForm,\
+ ConsiderRefereeInvitationForm, EditorialCommunicationForm,\
+ EICRecommendationForm, ReportForm, VetReportForm, VotingEligibilityForm
from .utils import SubmissionUtils
from comments.models import Comment
@@ -37,7 +39,7 @@ from comments.forms import CommentForm
from .services import ArxivCaller
-from django.views.generic.edit import UpdateView, CreateView, FormView
+from django.views.generic.edit import CreateView, FormView
###############
@@ -226,8 +228,8 @@ class PrefillUsingIdentifierView(FormView):
return render(request, 'submissions/prefill_using_identifier.html',
{'form': identifierform})
-class SubmissionCreateView(CreateView):
+class SubmissionCreateView(CreateView):
model = Submission
fields = [
'is_resubmission',
@@ -275,6 +277,16 @@ class SubmissionCreateView(CreateView):
ed_admins = Group.objects.get(name='Editorial Administrators')
assign_perm('can_take_editorial_actions', ed_admins, submission)
+ # Assign editor
+ assignment = EditorialAssignment(
+ submission=submission,
+ to=submission.editor_in_charge,
+ accepted=True,
+ date_created=timezone.now(),
+ date_answered=timezone.now(),
+ )
+ assignment.save()
+
# Send emails
SubmissionUtils.load({'submission': submission})
SubmissionUtils.send_authors_resubmission_ack_email()
@@ -304,8 +316,6 @@ class SubmissionCreateView(CreateView):
)
-
-
# @login_required
# @permission_required('scipost.can_submit_manuscript', raise_exception=True)
# @transaction.atomic
@@ -315,13 +325,13 @@ class SubmissionCreateView(CreateView):
# if form.is_valid():
# submitted_by = Contributor.objects.get(user=request.user)
# # Verify if submitter is among the authors
- # if submitted_by.user.last_name not in form.cleaned_data['author_list']:
- # errormessage = ('Your name does not match that of any of the authors. '
- # 'You are not authorized to submit this preprint.')
- # identifierform = SubmissionIdentifierForm()
- # return render(request, 'submissions/submit_manuscript.html',
- # {'identifierform': identifierform, 'form': form,
- # 'errormessage': errormessage})
+# if submitted_by.user.last_name not in form.cleaned_data['author_list']:
+# errormessage = ('Your name does not match that of any of the authors. '
+# 'You are not authorized to submit this preprint.')
+# identifierform = SubmissionIdentifierForm()
+# return render(request, 'submissions/submit_manuscript.html',
+# {'identifierform': identifierform, 'form': form,
+# 'errormessage': errormessage})
# submission = Submission(
# is_current=True,
# is_resubmission=form.cleaned_data['is_resubmission'],
@@ -488,8 +498,7 @@ def submission_detail(request, arxiv_identifier_w_vn_nr):
and not request.user.groups.filter(name='SciPost Administrators').exists()
and not request.user.groups.filter(name='Editorial Administrators').exists()
and not request.user.groups.filter(name='Editorial College').exists()
- and not is_author
- ):
+ and not is_author):
raise PermissionDenied
other_versions = Submission.objects.filter(
arxiv_identifier_wo_vn_nr=submission.arxiv_identifier_wo_vn_nr
@@ -607,16 +616,30 @@ def pool(request):
rec_vote_form = RecommendationVoteForm()
remark_form = RemarkForm()
context = {'submissions_in_pool': submissions_in_pool,
+ 'submission_status': SUBMISSION_STATUS,
'recommendations_undergoing_voting': recommendations_undergoing_voting,
'recommendations_to_prepare_for_voting': recommendations_to_prepare_for_voting,
'assignments_to_consider': assignments_to_consider,
'consider_assignment_form': consider_assignment_form,
'recs_to_vote_on': recs_to_vote_on,
'rec_vote_form': rec_vote_form,
- 'remark_form': remark_form,}
+ 'remark_form': remark_form, }
return render(request, 'submissions/pool.html', context)
+@login_required
+@permission_required('scipost.can_view_pool', raise_exception=True)
+def submissions_by_status(request, status):
+ if status not in submission_status_dict.keys():
+ errormessage = 'Unknown status.'
+ return render(request, 'scipost/error.html', {'errormessage': errormessage})
+ submissions_of_status = Submission.objects.filter(
+ status=status).order_by('-submission_date')
+ context = {'status': submission_status_dict[status],
+ 'submissions_of_status': submissions_of_status, }
+ return render(request, 'submissions/submissions_by_status.html', context)
+
+
@login_required
@permission_required('scipost.can_view_pool', raise_exception=True)
def add_remark(request, arxiv_identifier_w_vn_nr):
@@ -643,7 +666,6 @@ def add_remark(request, arxiv_identifier_w_vn_nr):
return render(request, 'scipost/error.html', {'errormessage': errormessage})
-
@login_required
@permission_required('scipost.can_assign_submissions', raise_exception=True)
def assign_submission(request, arxiv_identifier_w_vn_nr):
@@ -819,6 +841,29 @@ def assignment_failed(request, arxiv_identifier_w_vn_nr):
return render(request, 'submissions/assignment_failed.html', context)
+@login_required
+@permission_required('scipost.can_take_charge_of_submissions', raise_exception=True)
+def assignments(request):
+ """
+ This page provides a Fellow with an explicit task list
+ of editorial actions which should be undertaken.
+ """
+ assignments = EditorialAssignment.objects.filter(
+ to=request.user.contributor).order_by('-date_created')
+ assignments_to_consider = assignments.filter(accepted=None,
+ deprecated=False)
+ current_assignments = assignments.filter(accepted=True,
+ deprecated=False,
+ completed=False)
+ consider_assignment_form = ConsiderAssignmentForm()
+ context = {
+ 'assignments_to_consider': assignments_to_consider,
+ 'consider_assignment_form': consider_assignment_form,
+ 'current_assignments': current_assignments,
+ }
+ return render(request, 'submissions/assignments.html', context)
+
+
@login_required
@permission_required_or_403('can_take_editorial_actions',
(Submission, 'arxiv_identifier_w_vn_nr', 'arxiv_identifier_w_vn_nr'))
@@ -1005,7 +1050,6 @@ def accept_or_decline_ref_invitations(request):
@login_required
@permission_required('scipost.can_referee', raise_exception=True)
def accept_or_decline_ref_invitation_ack(request, invitation_id):
- contributor = Contributor.objects.get(user=request.user)
invitation = get_object_or_404(RefereeInvitation, pk=invitation_id)
if request.method == 'POST':
form = ConsiderRefereeInvitationForm(request.POST)
@@ -1424,6 +1468,37 @@ def vote_on_rec(request, rec_id):
return redirect(reverse('submissions:pool'))
+@permission_required('scipost.can_prepare_recommendations_for_voting', raise_exception=True)
+def remind_Fellows_to_vote(request):
+ """
+ This method sends an email to all Fellow with pending voting duties.
+ It must be called by and Editorial Administrator.
+ """
+ recommendations_undergoing_voting = (EICRecommendation.objects.filter(
+ submission__status__in=['put_to_EC_voting']))
+ Fellow_emails = []
+ Fellow_names = []
+ for rec in recommendations_undergoing_voting:
+ for Fellow in rec.eligible_to_vote.all():
+ if (Fellow not in rec.voted_for.all()
+ and Fellow not in rec.voted_against.all()
+ and Fellow not in rec.voted_abstain.all()
+ and Fellow.user.email not in Fellow_emails):
+ Fellow_emails.append(Fellow.user.email)
+ Fellow_names.append(str(Fellow))
+ SubmissionUtils.load({'Fellow_emails': Fellow_emails})
+ SubmissionUtils.send_Fellows_voting_reminder_email()
+ ack_message = 'Email reminders have been sent to: <ul>'
+ for name in sorted(Fellow_names):
+ ack_message += '<li>' + name + '</li>'
+ ack_message += '</ul>'
+ context = {'ack_message': Template(ack_message).render(Context({})),
+ 'followup_message': 'Return to the ',
+ 'followup_link': reverse('submissions:pool'),
+ 'followup_link_label': 'Submissions pool'}
+ return render(request, 'scipost/acknowledgement.html', context)
+
+
@permission_required('scipost.can_fix_College_decision', raise_exception=True)
@transaction.atomic
def fix_College_decision(request, rec_id):
diff --git a/theses/forms.py b/theses/forms.py
index 260bba700c3c70425069cfbdde3be4454063918c..a98241a7e6eb8ae0d02840dbe091782cfc642e33 100644
--- a/theses/forms.py
+++ b/theses/forms.py
@@ -6,6 +6,8 @@ from scipost.models import Contributor, title_dict
from .models import ThesisLink
from .helpers import past_years
+from scipost.models import Contributor, title_dict
+
class RequestThesisLinkForm(forms.ModelForm):
class Meta:
@@ -65,8 +67,8 @@ class VetThesisLinkForm(RequestThesisLinkForm):
email_text = ('Dear ' + title_dict[thesislink.requested_by.title] + ' '
+ thesislink.requested_by.user.last_name
- + ', \n\nThe Thesis Link you have requested, concerning thesis with title '
- + thesislink.title + ' by ' + thesislink.author
+ + ', \n\nThe Thesis Link you have requested, concerning thesis with'
+ + ' title ' + thesislink.title + ' by ' + thesislink.author
+ ', has been activated at https://scipost.org/thesis/'
+ str(thesislink.id) + '.'
+ '\n\nThank you for your contribution, \nThe SciPost Team.')
@@ -79,8 +81,8 @@ class VetThesisLinkForm(RequestThesisLinkForm):
elif int(self.cleaned_data['action_option']) == VetThesisLinkForm.REFUSE:
email_text = ('Dear ' + title_dict[thesislink.requested_by.title] + ' '
+ thesislink.requested_by.user.last_name
- + ', \n\nThe Thesis Link you have requested, concerning thesis with title '
- + thesislink.title + ' by ' + thesislink.author
+ + ', \n\nThe Thesis Link you have requested, concerning thesis with'
+ + ' title ' + thesislink.title + ' by ' + thesislink.author
+ ', has not been activated for the following reason: '
+ self.cleaned_data['refusal_reason']
+ '.\n\nThank you for your interest, \nThe SciPost Team.')
@@ -101,8 +103,8 @@ class VetThesisLinkForm(RequestThesisLinkForm):
thesislink.save()
email_text = ('Dear ' + title_dict[thesislink.requested_by.title] + ' '
+ thesislink.requested_by.user.last_name
- + ', \n\nThe Thesis Link you have requested, concerning thesis with title '
- + thesislink.title + ' by ' + thesislink.author
+ + ', \n\nThe Thesis Link you have requested, concerning thesis with'
+ + ' title ' + thesislink.title + ' by ' + thesislink.author
+ ', has been activated '
'(with slight modifications to your submitted details) at '
'https://scipost.org/thesis/' + str(thesislink.id) + '.'
diff --git a/theses/models.py b/theses/models.py
index fbd5f370d030f2fe3c7e163082cefa39a258efe8..a804930e1eac31b2255ce455bcd65586fa8a55ff 100644
--- a/theses/models.py
+++ b/theses/models.py
@@ -1,13 +1,11 @@
from django.utils import timezone
from django.db import models
-from django.contrib.auth.models import User
from django.template import Template, Context
-from .models import *
-
-from journals.models import *
-from scipost.constants import SCIPOST_DISCIPLINES, subject_areas_dict, disciplines_dict
-from scipost.models import *
+from journals.models import SCIPOST_JOURNALS_DOMAINS, journals_domains_dict
+from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS,\
+ subject_areas_dict, disciplines_dict
+from scipost.models import Contributor
class ThesisLink(models.Model):
@@ -75,8 +73,7 @@ class ThesisLink(models.Model):
'pub_link': self.pub_link, 'institution': self.institution,
'supervisor': self.supervisor, 'defense_date': self.defense_date,
'latest_activity': self.latest_activity.strftime('%Y-%m-%d %H:%M')})
- print(subject_areas_dict)
- print(self.subject_area in subject_areas_dict)
+
header = (
'<li><div class="flex-container">'
'<div class="flex-whitebox0"><p><a href="/thesis/{{ id }}" '
diff --git a/theses/views.py b/theses/views.py
index 5f3d11bcb7a92095d5cae8143962e478bbb76e3e..da81c1b473672d8ff1e23d764e721dbfe460bb56 100644
--- a/theses/views.py
+++ b/theses/views.py
@@ -2,34 +2,30 @@ import datetime
from django.utils import timezone
from django.shortcuts import get_object_or_404, render
-from django.contrib.auth import authenticate, login, logout
-from django.contrib.auth.decorators import login_required, permission_required
-from django.contrib.auth.models import User
+from django.contrib.auth.decorators import permission_required
from django.contrib import messages
-from django.core.mail import EmailMessage
from django.core.urlresolvers import reverse, reverse_lazy
-from django.http import HttpResponse, HttpResponseRedirect
-from django.views.decorators.csrf import csrf_protect
-from django.db.models import Avg
-from django.views.generic.edit import CreateView, FormView, UpdateView
+from django.http import HttpResponseRedirect
+from django.views.generic.edit import CreateView, UpdateView
from django.views.generic.list import ListView
from django.utils.decorators import method_decorator
-from .models import *
-from .forms import *
+from .models import ThesisLink
+from .forms import RequestThesisLinkForm, ThesisLinkSearchForm, VetThesisLinkForm
from comments.models import Comment
from comments.forms import CommentForm
-from scipost.forms import TITLE_CHOICES, AuthenticationForm
+from scipost.forms import TITLE_CHOICES
+from scipost.models import Contributor
import strings
title_dict = dict(TITLE_CHOICES) # Convert titles for use in emails
+
################
# Theses
################
-
@method_decorator(permission_required(
'scipost.can_request_thesislinks', raise_exception=True), name='dispatch')
class RequestThesisLink(CreateView):
@@ -68,9 +64,9 @@ class VetThesisLink(UpdateView):
def form_valid(self, form):
# I totally override the form_valid method. I do not call super.
# This is because, by default, an UpdateView saves the object as instance,
- # which it builds from the form data. So, the changes (by whom the thesis link was vetted, etc.)
- # would be lost. Instead, we need the form to save with commit=False, then modify
- # the vetting fields, and then save.
+ # which it builds from the form data. So, the changes (by whom the thesis link was
+ # vetted, etc.) would be lost. Instead, we need the form to save with commit=False,
+ # then modify the vetting fields, and then save.
# Builds model that reflects changes made during update. Does not yet save.
self.object = form.save(commit=False)
@@ -111,7 +107,8 @@ def theses(request):
thesislink_recent_list = (ThesisLink.objects
.filter(vetted=True,
- latest_activity__gte=timezone.now() + datetime.timedelta(days=-7)))
+ latest_activity__gte=timezone.now() + datetime.timedelta(
+ days=-7)))
context = {'form': form, 'thesislink_search_list': thesislink_search_list,
'thesislink_recent_list': thesislink_recent_list}
return render(request, 'theses/theses.html', context)