From 0c40602a1666dd4f1db5c755122c326c5002ba41 Mon Sep 17 00:00:00 2001
From: Jorran de Wit <jorrandewit@outlook.com>
Date: Wed, 1 Feb 2017 12:40:54 +0100
Subject: [PATCH] Fix password change bug
If a user wants to change its password, but does not
submit a valid form it still gets a 'Succesfully changed password'
message.
---
scipost/views.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scipost/views.py b/scipost/views.py
index f60e5b518..a157b97ed 100644
--- a/scipost/views.py
+++ b/scipost/views.py
@@ -1076,6 +1076,7 @@ def personal_page(request):
def change_password(request):
if request.method == 'POST':
form = PasswordChangeForm(request.POST)
+ ack = False
if form.is_valid():
if not request.user.check_password(form.cleaned_data['password_prev']):
return render(
@@ -1089,7 +1090,7 @@ def change_password(request):
request.user.set_password(form.cleaned_data['password_new'])
request.user.save()
ack = True
- context = {'ack': True, 'form': form}
+ context = {'ack': ack, 'form': form}
else:
form = PasswordChangeForm()
context = {'ack': False, 'form': form}
--
GitLab