From 0c8a94530d8ed140913b52c59f413bb4e3ad3f84 Mon Sep 17 00:00:00 2001
From: George Katsikas <giorgakis.katsikas@gmail.com>
Date: Tue, 9 May 2023 15:20:47 +0200
Subject: [PATCH] add missing imports breaking populate_faker_data
---
scipost_django/submissions/factories/assignment.py | 4 ++--
scipost_django/submissions/factories/referee_invitation.py | 2 ++
scipost_django/submissions/factories/submission.py | 6 ++++++
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/scipost_django/submissions/factories/assignment.py b/scipost_django/submissions/factories/assignment.py
index d0d0fca6a..5bc513f62 100644
--- a/scipost_django/submissions/factories/assignment.py
+++ b/scipost_django/submissions/factories/assignment.py
@@ -5,7 +5,7 @@ __license__ = "AGPL v3"
import factory
from scipost.models import Contributor
-from submissions.constants import ASSIGNMENT_STATUSES
+from submissions.models.submission import Submission
from submissions.models import EditorialAssignment
@@ -18,7 +18,7 @@ class EditorialAssignmentFactory(factory.django.DjangoModelFactory):
submission = None
to = factory.Iterator(Contributor.objects.all())
- status = factory.Iterator(ASSIGNMENT_STATUSES, getter=lambda c: c[0])
+ status = factory.Iterator(Submission.SUBMISSION_STATUSES, getter=lambda c: c[0])
date_created = factory.lazy_attribute(lambda o: o.submission.latest_activity)
date_answered = factory.lazy_attribute(lambda o: o.submission.latest_activity)
diff --git a/scipost_django/submissions/factories/referee_invitation.py b/scipost_django/submissions/factories/referee_invitation.py
index 565387f40..3f303de01 100644
--- a/scipost_django/submissions/factories/referee_invitation.py
+++ b/scipost_django/submissions/factories/referee_invitation.py
@@ -4,6 +4,7 @@ __license__ = "AGPL v3"
import factory
import pytz
+import random
from faker import Faker
@@ -46,6 +47,7 @@ class AcceptedRefereeInvitationFactory(RefereeInvitationFactory):
@factory.post_generation
def report(self, create, extracted, **kwargs):
if create:
+ from submissions.factories import VettedReportFactory
VettedReportFactory(submission=self.submission, author=self.referee)
diff --git a/scipost_django/submissions/factories/submission.py b/scipost_django/submissions/factories/submission.py
index 954fd9195..a8af6df0b 100644
--- a/scipost_django/submissions/factories/submission.py
+++ b/scipost_django/submissions/factories/submission.py
@@ -4,6 +4,7 @@ __license__ = "AGPL v3"
import factory
import pytz
+import random
from faker import Faker
@@ -308,6 +309,11 @@ class PublishedSubmissionFactory(InRefereeingSubmissionFactory):
@factory.post_generation
def referee_invites(self, create, extracted, **kwargs):
+ from submissions.factories import (
+ FulfilledRefereeInvitationFactory,
+ CancelledRefereeInvitationFactory
+ )
+
for i in range(random.randint(2, 4)):
FulfilledRefereeInvitationFactory(submission=self)
for i in range(random.randint(0, 2)):
--
GitLab