From 1221006222f6b0de7010483d7e38b84f353ccd8b Mon Sep 17 00:00:00 2001
From: Jorran de Wit <jorrandewit@outlook.com>
Date: Thu, 15 Nov 2018 18:36:25 +0100
Subject: [PATCH] Prevent unwanted status updates on invitations.
---
submissions/models.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/submissions/models.py b/submissions/models.py
index 40e541a3f..58acca549 100644
--- a/submissions/models.py
+++ b/submissions/models.py
@@ -440,12 +440,13 @@ class EditorialAssignment(SubmissionRelatedObjectMixin, models.Model):
# Only send if status is appropriate to prevent double sending
return False
- EditorialAssignment.objects.filter(
- id=self.id).update(date_invited=timezone.now(), status=STATUS_INVITED)
-
# Send mail
mail_sender = DirectMailUtil(mail_code='eic/assignment_request', instance=self)
mail_sender.send()
+
+ EditorialAssignment.objects.filter(
+ id=self.id).update(date_invited=timezone.now(), status=STATUS_INVITED)
+
return True
--
GitLab