From 15cb983106548288783b52b65d51ab295966385d Mon Sep 17 00:00:00 2001
From: Jorran de Wit <jorrandewit@outlook.com>
Date: Sun, 1 Apr 2018 22:26:26 +0200
Subject: [PATCH] Fix report_nr counting foolproof
---
submissions/models.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/submissions/models.py b/submissions/models.py
index 001ad68f2..5936bd4ca 100644
--- a/submissions/models.py
+++ b/submissions/models.py
@@ -501,7 +501,8 @@ class Report(SubmissionRelatedObjectMixin, models.Model):
def save(self, *args, **kwargs):
"""Update report number before saving on creation."""
if not self.report_nr:
- self.report_nr = self.submission.reports.count() + 1
+ self.report_nr = self.submission.reports.aggregate(
+ models.Max('report_nr')).get('report_nr__max', 0) + 1
return super().save(*args, **kwargs)
def get_absolute_url(self):
--
GitLab