From 23f92088632b8ddd797df802954e095875231524 Mon Sep 17 00:00:00 2001 From: Jorran de Wit <jorrandewit@outlook.com> Date: Mon, 21 May 2018 13:08:23 +0200 Subject: [PATCH] Fix vet bug --- scipost/views.py | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/scipost/views.py b/scipost/views.py index b58d42b0c..68344390f 100644 --- a/scipost/views.py +++ b/scipost/views.py @@ -268,15 +268,18 @@ def vet_registration_request_ack(request, contributor_id): contributor.save() group = Group.objects.get(name='Registered Contributors') contributor.user.groups.add(group) + # Verify if there is a pending refereeing invitation - pending_ref_inv_exists = True - try: - pending_ref_inv = RefereeInvitation.objects.get( - invitation_key=contributor.invitation_key, cancelled=False) - pending_ref_inv.referee = contributor - pending_ref_inv.save() - except RefereeInvitation.DoesNotExist: - pending_ref_inv_exists = False + pending_ref_inv_exists = False + if contributor.invitation_key: + try: + pending_ref_inv = RefereeInvitation.objects.get( + invitation_key=contributor.invitation_key, cancelled=False) + pending_ref_inv.referee = contributor + pending_ref_inv.save() + pending_ref_inv_exists = True + except RefereeInvitation.DoesNotExist: + pending_ref_inv_exists = False email_text = ( 'Dear ' + contributor.get_title_display() + ' ' + contributor.user.last_name + -- GitLab