From 25f39962f74faa1799772af2c16d46457f2d9430 Mon Sep 17 00:00:00 2001
From: Jorran de Wit <jorrandewit@outlook.com>
Date: Mon, 29 Jan 2018 20:05:47 +0100
Subject: [PATCH] Fix fatal no return in recommendation form
---
.../scipost/contributors_filter.html | 39 +++++++++++++++++++
submissions/forms.py | 1 +
2 files changed, 40 insertions(+)
create mode 100644 scipost/templates/scipost/contributors_filter.html
diff --git a/scipost/templates/scipost/contributors_filter.html b/scipost/templates/scipost/contributors_filter.html
new file mode 100644
index 000000000..782d7a5ef
--- /dev/null
+++ b/scipost/templates/scipost/contributors_filter.html
@@ -0,0 +1,39 @@
+{% extends 'scipost/_personal_page_base.html' %}
+
+{% load bootstrap %}
+
+{% block pagetitle %}: contributors filter{% endblock pagetitle %}
+
+{% block breadcrumb_items %}
+ {{block.super}}
+ <span class="breadcrumb-item">Pool</span>
+{% endblock %}
+
+{% block content %}
+
+<div class="row">
+ <div class="col-12">
+ <h1 class="highlight">Contributors filter</h1>
+ </div>
+</div>
+
+<div class="row">
+ <div class="col-12">
+ <form method="post">
+ {% csrf_token %}
+ {{ form|bootstrap }}
+ <input type="submit" class="btn btn-primary" value="Filter"/>
+ </form>
+ </div>
+</div>
+
+{% if form.is_bound %}
+ {% if names_not_found %}
+ <pre><code>{% for contributor in names_not_found %}{{ contributor }}{% endfor %}</code></pre>
+ {% endif %}
+ {% if names_found %}
+ <pre><code>{% for contributor in names_found %}{{ contributor }}{% endfor %}</code></pre>
+ {% endif %}
+{% endif %}
+
+{% endblock %}
diff --git a/submissions/forms.py b/submissions/forms.py
index a25a3b502..378403164 100644
--- a/submissions/forms.py
+++ b/submissions/forms.py
@@ -779,6 +779,7 @@ class EICRecommendationForm(forms.ModelForm):
# The EIC has fulfilled this editorial assignment.
self.assignment.completed = True
self.assignment.save()
+ return recommendation
def revision_requested(self):
return self.instance.recommendation in [-1, -2]
--
GitLab