From 3f34109db5896dc82db1c05cb361ef3ca2aa660f Mon Sep 17 00:00:00 2001 From: George Katsikas <giorgakis.katsikas@gmail.com> Date: Mon, 9 Oct 2023 15:55:26 +0200 Subject: [PATCH] fix typo in nomination form --- scipost_django/colleges/forms.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scipost_django/colleges/forms.py b/scipost_django/colleges/forms.py index 02c5cc85a..e3e85aa3b 100644 --- a/scipost_django/colleges/forms.py +++ b/scipost_django/colleges/forms.py @@ -455,7 +455,7 @@ class FellowshipNominationForm(forms.ModelForm): self.profile ) if failed_eligibility_criteria: - for critetion in failed_eligibility_criteria: + for criterion in failed_eligibility_criteria: self.add_error(None, criterion) if data["college"].acad_field != self.profile.acad_field: self.add_error( @@ -791,6 +791,10 @@ class FellowshipNominationDecisionForm(forms.ModelForm): self.fields["voting_round"].initial = voting_round self.fields["outcome"].initial = voting_round.vote_outcome + if nomination := getattr(self.instance, "nomination", None): + if voting_outcome := nomination.latest_voting_round.outcome: + self.fields["outcome"].initial = voting_outcome + ################# # Voting Rounds # -- GitLab