From 3fab062207016789585fa7d975f905ac0e6935b9 Mon Sep 17 00:00:00 2001
From: Jorran de Wit <jorrandewit@outlook.com>
Date: Sat, 13 May 2017 20:49:21 +0200
Subject: [PATCH] Extend submission listview tests
---
submissions/factories.py | 2 +-
submissions/test_views.py | 11 +++++++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/submissions/factories.py b/submissions/factories.py
index 9eb4eb4f2..39aab654c 100644
--- a/submissions/factories.py
+++ b/submissions/factories.py
@@ -38,7 +38,7 @@ class SubmissionFactory(factory.django.DjangoModelFactory):
'''Fill empty arxiv fields.'''
self.arxiv_link = 'https://arxiv.org/abs/%s' % self.arxiv_identifier_wo_vn_nr
self.arxiv_identifier_w_vn_nr = '%sv1' % self.arxiv_identifier_wo_vn_nr
- self.arxiv_vn_nr = 1
+ self.arxiv_vn_nr = kwargs.get('arxiv_vn_nr', 1)
@factory.post_generation
def contributors(self, create, extracted, **kwargs):
diff --git a/submissions/test_views.py b/submissions/test_views.py
index 2d05701eb..11e9c210a 100644
--- a/submissions/test_views.py
+++ b/submissions/test_views.py
@@ -223,6 +223,17 @@ class SubmissionListTest(BaseContributorTestCase):
visible_submission_ids.append(EICassignedSubmissionFactory.create().id)
visible_submission_ids.append(PublishedSubmissionFactory.create().id)
+ # Extra submission with multiple versions where the newest is publicly visible
+ # again. Earlier versions should therefore be invisible!
+ arxiv_id_resubmission = random_arxiv_identifier_without_version_number()
+ ResubmittedSubmissionFactory.create(arxiv_identifier_wo_vn_nr=arxiv_id_resubmission)
+ visible_submission_ids.append(
+ EICassignedSubmissionFactory.create(
+ arxiv_identifier_wo_vn_nr=arxiv_id_resubmission,
+ fill_arxiv_fields__arxiv_vn_nr=2
+ ).id
+ )
+
# Check with hardcoded URL as this url shouldn't change!
client = Client()
response = client.get('/submissions/')
--
GitLab