From 498e1189298e38a4e240ad4a4f8e9f9b248f31df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jean-S=C3=A9bastien=20Caux?= <git@jscaux.org>
Date: Wed, 7 Dec 2022 09:37:38 +0100
Subject: [PATCH] Rename pool submission list item details template
---
.../admin/_hx_submission_update_preprint_file.html | 2 +-
.../admin/_hx_submission_update_target_journal.html | 2 +-
.../_hx_submission_update_target_proceedings.html | 2 +-
.../templates/submissions/pool/_hx_submission_li.html | 2 +-
...ion_details.html => _hx_submission_li_details.html} | 0
scipost_django/submissions/urls.py | 4 ++--
scipost_django/submissions/views.py | 10 +++++-----
7 files changed, 11 insertions(+), 11 deletions(-)
rename scipost_django/submissions/templates/submissions/pool/{_hx_submission_details.html => _hx_submission_li_details.html} (100%)
diff --git a/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_preprint_file.html b/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_preprint_file.html
index 2da657092..823548d30 100644
--- a/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_preprint_file.html
+++ b/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_preprint_file.html
@@ -3,7 +3,7 @@
<p><strong>Update the preprint pdf</strong>
<button
type="button" class="ms-2 px-1 py-0 btn btn-sm btn-outline-danger"
- hx-get="{% url 'submissions:pool_hx_submission_details' submission.preprint.identifier_w_vn_nr %}"
+ hx-get="{% url 'submissions:pool_hx_submission_li_details' submission.preprint.identifier_w_vn_nr %}"
hx-target="#details_{{ submission.id }}"
>
cancel
diff --git a/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_journal.html b/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_journal.html
index d3a3d4b0d..2ff290779 100644
--- a/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_journal.html
+++ b/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_journal.html
@@ -3,7 +3,7 @@
<p><strong>Update the target Journal</strong>
<button
type="button" class="ms-2 px-1 py-0 btn btn-sm btn-outline-danger"
- hx-get="{% url 'submissions:pool_hx_submission_details' form.instance.preprint.identifier_w_vn_nr %}"
+ hx-get="{% url 'submissions:pool_hx_submission_li_details' form.instance.preprint.identifier_w_vn_nr %}"
hx-target="#details_{{ form.instance.id }}"
>
cancel
diff --git a/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_proceedings.html b/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_proceedings.html
index 959334888..8659ab8b4 100644
--- a/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_proceedings.html
+++ b/scipost_django/submissions/templates/submissions/admin/_hx_submission_update_target_proceedings.html
@@ -3,7 +3,7 @@
<p><strong>Update the target Proceedings</strong>
<button
type="button" class="ms-2 px-1 py-0 btn btn-sm btn-outline-danger"
- hx-get="{% url 'submissions:pool_hx_submission_details' form.instance.preprint.identifier_w_vn_nr %}"
+ hx-get="{% url 'submissions:pool_hx_submission_li_details' form.instance.preprint.identifier_w_vn_nr %}"
hx-target="#details_{{ form.instance.id }}"
>
cancel
diff --git a/scipost_django/submissions/templates/submissions/pool/_hx_submission_li.html b/scipost_django/submissions/templates/submissions/pool/_hx_submission_li.html
index b572b3ae8..6b99a2c79 100644
--- a/scipost_django/submissions/templates/submissions/pool/_hx_submission_li.html
+++ b/scipost_django/submissions/templates/submissions/pool/_hx_submission_li.html
@@ -114,7 +114,7 @@
<div id="details_{{ submission.id }}" class="mt-2">
<button type="button" class="btn btn-primary p-1 mx-auto"
- hx-get="{% url 'submissions:pool_hx_submission_details' submission.preprint.identifier_w_vn_nr %}"
+ hx-get="{% url 'submissions:pool_hx_submission_li_details' submission.preprint.identifier_w_vn_nr %}"
hx-target="#details_{{ submission.id }}"
hx-indicator="#indicator-details-{{ submission.id }}"
>
diff --git a/scipost_django/submissions/templates/submissions/pool/_hx_submission_details.html b/scipost_django/submissions/templates/submissions/pool/_hx_submission_li_details.html
similarity index 100%
rename from scipost_django/submissions/templates/submissions/pool/_hx_submission_details.html
rename to scipost_django/submissions/templates/submissions/pool/_hx_submission_li_details.html
diff --git a/scipost_django/submissions/urls.py b/scipost_django/submissions/urls.py
index f946a8a71..6d8f93e6a 100644
--- a/scipost_django/submissions/urls.py
+++ b/scipost_django/submissions/urls.py
@@ -253,8 +253,8 @@ urlpatterns = [
),
path(
"pool/submissions/<identifier:identifier_w_vn_nr>",
- views.pool_hx_submission_details,
- name="pool_hx_submission_details",
+ views.pool_hx_submission_li_details,
+ name="pool_hx_submission_li_details",
),
path(
"add_remark/<identifier:identifier_w_vn_nr>",
diff --git a/scipost_django/submissions/views.py b/scipost_django/submissions/views.py
index 2a61f63d4..96b90a230 100644
--- a/scipost_django/submissions/views.py
+++ b/scipost_django/submissions/views.py
@@ -898,13 +898,13 @@ def pool_hx_submissions_list(request):
@login_required
@fellowship_or_admin_required()
-def pool_hx_submission_details(request, identifier_w_vn_nr):
+def pool_hx_submission_li_details(request, identifier_w_vn_nr):
submission = get_object_or_404(
Submission.objects.in_pool(request.user, historical=True),
preprint__identifier_w_vn_nr=identifier_w_vn_nr,
)
context = {"remark_form": RemarkForm(), "submission": submission}
- return render(request, "submissions/pool/_hx_submission_details.html", context)
+ return render(request, "submissions/pool/_hx_submission_li_details.html", context)
@login_required
@@ -2564,7 +2564,7 @@ def _hx_submission_update_target_journal(request, identifier_w_vn_nr):
)
return redirect(
reverse(
- "submissions:pool_hx_submission_details",
+ "submissions:pool_hx_submission_li_details",
args=(submission.preprint.identifier_w_vn_nr,),
)
)
@@ -2590,7 +2590,7 @@ def _hx_submission_update_target_proceedings(request, identifier_w_vn_nr):
)
return redirect(
reverse(
- "submissions:pool_hx_submission_details",
+ "submissions:pool_hx_submission_li_details",
args=(submission.preprint.identifier_w_vn_nr,),
)
)
@@ -2624,7 +2624,7 @@ def _hx_submission_update_preprint_file(request, identifier_w_vn_nr):
)
return redirect(
reverse(
- "submissions:pool_hx_submission_details",
+ "submissions:pool_hx_submission_li_details",
args=(preprint.identifier_w_vn_nr,),
)
)
--
GitLab