From 5167435e9adb0f3593cf07f3cb0c56f0827576fa Mon Sep 17 00:00:00 2001
From: George Katsikas <giorgakis.katsikas@gmail.com>
Date: Wed, 6 Sep 2023 11:58:11 +0200
Subject: [PATCH] mark streams as "completed" upon publication
This is a QoL feature, valid while invitation officers are unused
---
scipost_django/journals/forms.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/scipost_django/journals/forms.py b/scipost_django/journals/forms.py
index 1163c95ad..da5ce8ebc 100644
--- a/scipost_django/journals/forms.py
+++ b/scipost_django/journals/forms.py
@@ -46,7 +46,7 @@ from journals.models import Journal
from mails.utils import DirectMailUtil
from organizations.models import Organization
from proceedings.models import Proceedings
-from production.constants import PROOFS_PUBLISHED
+from production.constants import PRODUCTION_STREAM_COMPLETED
from production.models import ProductionEvent
from scipost.forms import RequestFormMixin
from scipost.services import DOICaller
@@ -800,7 +800,10 @@ class PublicationPublishForm(RequestFormMixin, forms.ModelForm):
submission = self.instance.accepted_submission
if hasattr(submission, "production_stream"):
stream = submission.production_stream
- stream.status = PROOFS_PUBLISHED
+ # WARNING: We don't need the "published" stream status
+ # so long as we don't use invitation officers.
+ # If we reinstate this, we need to revert the status to published.
+ stream.status = PRODUCTION_STREAM_COMPLETED
stream.save()
if self.request.user.production_user:
prodevent = ProductionEvent(
--
GitLab