From 553652617e027a8b601b8fb71233c39c45d224b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jean-S=C3=A9bastien=20Caux?= <git@jscaux.org>
Date: Wed, 20 Mar 2024 10:38:07 +0100
Subject: [PATCH] Enable communications from E to [A,R,S] for non-latest
Submissions
---
scipost_django/submissions/managers/submission.py | 4 ++--
scipost_django/submissions/views/__init__.py | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/scipost_django/submissions/managers/submission.py b/scipost_django/submissions/managers/submission.py
index baa1c6120..395b9bdf3 100644
--- a/scipost_django/submissions/managers/submission.py
+++ b/scipost_django/submissions/managers/submission.py
@@ -215,12 +215,12 @@ class SubmissionQuerySet(models.QuerySet):
)
return qs.remove_COI(user)
- def in_pool_filter_for_eic(self, user, historical: bool = False):
+ def in_pool_filter_for_eic(self, user, latest: bool = True, historical: bool = False):
"""Return the set of Submissions the user is Editor-in-charge for.
If user is an Editorial Administrator: keep any EiC.
"""
- qs = self.in_pool(user, historical)
+ qs = self.in_pool(user, latest=latest, historical=historical)
if user.is_authenticated and not user.contributor.is_ed_admin:
qs = qs.filter(editor_in_charge__user=user)
return qs
diff --git a/scipost_django/submissions/views/__init__.py b/scipost_django/submissions/views/__init__.py
index 509206b25..37d4f1064 100644
--- a/scipost_django/submissions/views/__init__.py
+++ b/scipost_django/submissions/views/__init__.py
@@ -2006,6 +2006,7 @@ def communication(request, identifier_w_vn_nr, comtype, referee_id=None):
# Editor to {Author, Referee, Editorial Administration}
submissions_qs = Submission.objects.in_pool_filter_for_eic(
request.user,
+ latest=False,
historical=True,
)
elif comtype == "AtoE":
--
GitLab