From 73be7a4788804d841fafbac9878eb8a95056103f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jean-S=C3=A9bastien=20Caux?= <git@jscaux.org>
Date: Fri, 16 Dec 2022 16:19:20 +0100
Subject: [PATCH] Tweak method name
---
scipost_django/submissions/models/submission.py | 2 +-
.../pool/_submission_details_summary_contents.html | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/scipost_django/submissions/models/submission.py b/scipost_django/submissions/models/submission.py
index 5d9f218fb..13cd9f55d 100644
--- a/scipost_django/submissions/models/submission.py
+++ b/scipost_django/submissions/models/submission.py
@@ -757,7 +757,7 @@ class Submission(models.Model):
return self.editorial_assignments.preassigned().exists()
- def has_inadequate_fellowship_composition(self):
+ def eic_not_in_fellowship(self):
"""
Check whether the EIC is actually in the fellowship of the Submission.
"""
diff --git a/scipost_django/submissions/templates/submissions/pool/_submission_details_summary_contents.html b/scipost_django/submissions/templates/submissions/pool/_submission_details_summary_contents.html
index 4fdaca9a3..2dd00d188 100644
--- a/scipost_django/submissions/templates/submissions/pool/_submission_details_summary_contents.html
+++ b/scipost_django/submissions/templates/submissions/pool/_submission_details_summary_contents.html
@@ -117,17 +117,17 @@
</div>
</div>
-{% if request.user.contributor.is_ed_admin and submission.has_inadequate_fellowship_composition %}
+{% if request.user.contributor.is_ed_admin and submission.eic_not_in_fellowship %}
<div class="border border-danger text-danger mt-1 py-1 px-2">
<strong>
{% include 'bi/exclamation-triangle-fill.html' %}
- Notice to admin: The current editor is not assigned to the pool. Therefore, the editor will not be able to reach the editorial page.
+ Notice to admin: The current editor is not assigned to this Submission's fellowship and will not be able to reach the editorial page.
</strong>
</div>
{% endif %}
-{% if submission.status == 'seeking_assignment' %}
+{% if submission.in_stage_assignment %}
{% get_editor_invitations submission request.user as invitations %}
{% if invitations %}
<div class="border border-warning mt-1 py-1 px-2">
--
GitLab