diff --git a/commentaries/factories.py b/commentaries/factories.py
new file mode 100644
index 0000000000000000000000000000000000000000..805b0019dca52b6255a364891dfd4b8df680df17
--- /dev/null
+++ b/commentaries/factories.py
@@ -0,0 +1,38 @@
+import factory
+
+from .models import Commentary, COMMENTARY_TYPES
+
+from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS
+from scipost.factories import ContributorFactory
+from journals.models import SCIPOST_JOURNALS_DOMAINS
+
+
+class CommentaryFactory(factory.django.DjangoModelFactory):
+ class Meta:
+ model = Commentary
+ abstract = True
+
+ requested_by = factory.SubFactory(ContributorFactory)
+ vetted_by = factory.SubFactory(ContributorFactory)
+ type = COMMENTARY_TYPES[0][0]
+ discipline = SCIPOST_DISCIPLINES[0][0]
+ domain = SCIPOST_JOURNALS_DOMAINS[0][0]
+ subject_area = SCIPOST_SUBJECT_AREAS[0][1][0][0]
+ pub_title = factory.Sequence(lambda n: "Commentary %d" % n)
+ pub_DOI = '10.1103/PhysRevB.92.214427'
+ arxiv_identifier = '1610.06911v1'
+ author_list = factory.Faker('name')
+ pub_abstract = factory.Faker('text')
+
+
+class EmptyCommentaryFactory(CommentaryFactory):
+ pub_DOI = None
+ arxiv_identifier = None
+
+
+class VettedCommentaryFactory(CommentaryFactory):
+ vetted = True
+
+
+class UnVettedCommentaryFactory(CommentaryFactory):
+ vetted = False
diff --git a/commentaries/forms.py b/commentaries/forms.py
index 14cd5852633ca67586f10bb5cf3e39f7fcefd1ea..22632aafe7c5a939b6704e2c6fb51af4cbac3e6a 100644
--- a/commentaries/forms.py
+++ b/commentaries/forms.py
@@ -1,26 +1,16 @@
from django import forms
+from django.shortcuts import get_object_or_404
from .models import Commentary
+from scipost.models import Contributor
-COMMENTARY_ACTION_CHOICES = (
- (0, 'modify'),
- (1, 'accept'),
- (2, 'refuse (give reason below)'),
- )
-
-COMMENTARY_REFUSAL_CHOICES = (
- (0, '-'),
- (-1, 'a commentary on this paper already exists'),
- (-2, 'this paper cannot be traced'),
- (-3, 'there exists a more revent version of this arXiv preprint'),
- )
-commentary_refusal_dict = dict(COMMENTARY_REFUSAL_CHOICES)
class DOIToQueryForm(forms.Form):
doi = forms.CharField(widget=forms.TextInput(
{'label': 'DOI', 'placeholder': 'ex.: 10.21468/00.000.000000'}))
+
class IdentifierToQueryForm(forms.Form):
identifier = forms.CharField(widget=forms.TextInput(
{'label': 'arXiv identifier',
@@ -28,6 +18,9 @@ class IdentifierToQueryForm(forms.Form):
class RequestCommentaryForm(forms.ModelForm):
+ """Create new valid Commetary by user request"""
+ existing_commentary = None
+
class Meta:
model = Commentary
fields = ['type', 'discipline', 'domain', 'subject_area',
@@ -38,6 +31,7 @@ class RequestCommentaryForm(forms.ModelForm):
'pub_DOI', 'pub_abstract']
def __init__(self, *args, **kwargs):
+ self.user = kwargs.pop('user', None)
super(RequestCommentaryForm, self).__init__(*args, **kwargs)
self.fields['metadata'].widget = forms.HiddenInput()
self.fields['pub_date'].widget.attrs.update({'placeholder': 'Format: YYYY-MM-DD'})
@@ -46,7 +40,78 @@ class RequestCommentaryForm(forms.ModelForm):
self.fields['pub_DOI'].widget.attrs.update({'placeholder': 'ex.: 10.21468/00.000.000000'})
self.fields['pub_abstract'].widget.attrs.update({'cols': 100})
+ def clean(self, *args, **kwargs):
+ """Check if form is valid and contains an unique identifier"""
+ cleaned_data = super(RequestCommentaryForm, self).clean(*args, **kwargs)
+
+ # Either Arxiv-ID or DOI is given
+ if not cleaned_data['arxiv_identifier'] and not cleaned_data['pub_DOI']:
+ msg = ('You must provide either a DOI (for a published paper) '
+ 'or an arXiv identifier (for a preprint).')
+ self.add_error('arxiv_identifier', msg)
+ self.add_error('pub_DOI', msg)
+ elif (cleaned_data['arxiv_identifier'] and
+ (Commentary.objects
+ .filter(arxiv_identifier=cleaned_data['arxiv_identifier']).exists())):
+ msg = 'There already exists a Commentary Page on this preprint, see'
+ self.existing_commentary = get_object_or_404(
+ Commentary,
+ arxiv_identifier=cleaned_data['arxiv_identifier'])
+ self.add_error('arxiv_identifier', msg)
+ elif (cleaned_data['pub_DOI'] and
+ Commentary.objects.filter(pub_DOI=cleaned_data['pub_DOI']).exists()):
+ msg = 'There already exists a Commentary Page on this publication, see'
+ self.existing_commentary = get_object_or_404(Commentary, pub_DOI=cleaned_data['pub_DOI'])
+ self.add_error('pub_DOI', msg)
+
+ # Current user is not known
+ if not self.user or not Contributor.objects.filter(user=self.user).exists():
+ self.add_error(None, 'Sorry, current user is not known to SciPost.')
+
+
+ def save(self, *args, **kwargs):
+ """Prefill instance before save"""
+ self.requested_by = Contributor.objects.get(user=self.user)
+ return super(RequestCommentaryForm, self).save(*args, **kwargs)
+
+ def get_existing_commentary(self):
+ """Get Commentary if found after validation"""
+ return self.existing_commentary
+
+
class VetCommentaryForm(forms.Form):
+ """Process an unvetted Commentary request.
+
+ This form will provide fields to let the user
+ process a Commentary that is unvetted. On success,
+ the Commentary is either accepted or deleted from
+ the database.
+
+ Keyword arguments:
+ commentary_id -- the Commentary.id to process (required)
+ user -- User instance of the vetting user (required)
+
+ """
+ ACTION_MODIFY = 0
+ ACTION_ACCEPT = 1
+ ACTION_REFUSE = 2
+ COMMENTARY_ACTION_CHOICES = (
+ (ACTION_MODIFY, 'modify'),
+ (ACTION_ACCEPT, 'accept'),
+ (ACTION_REFUSE, 'refuse (give reason below)'),
+ )
+ REFUSAL_EMPTY = 0
+ REFUSAL_PAPER_EXISTS = -1
+ REFUSAL_UNTRACEBLE = -2
+ REFUSAL_ARXIV_EXISTS = -3
+ COMMENTARY_REFUSAL_CHOICES = (
+ (REFUSAL_EMPTY, '-'),
+ (REFUSAL_PAPER_EXISTS, 'a commentary on this paper already exists'),
+ (REFUSAL_UNTRACEBLE, 'this paper cannot be traced'),
+ (REFUSAL_ARXIV_EXISTS, 'there exists a more revent version of this arXiv preprint'),
+ )
+ COMMENTARY_REFUSAL_DICT = dict(COMMENTARY_REFUSAL_CHOICES)
+
action_option = forms.ChoiceField(widget=forms.RadioSelect,
choices=COMMENTARY_ACTION_CHOICES,
required=True, label='Action')
@@ -54,7 +119,81 @@ class VetCommentaryForm(forms.Form):
email_response_field = forms.CharField(widget=forms.Textarea(
attrs={'rows': 5, 'cols': 40}), label='Justification (optional)', required=False)
+ def __init__(self, *args, **kwargs):
+ """Pop and save keyword arguments if set, return form instance"""
+ self.commentary_id = kwargs.pop('commentary_id', None)
+ self.user = kwargs.pop('user', None)
+ self.is_cleaned = False
+ return super(VetCommentaryForm, self).__init__(*args, **kwargs)
+
+ def clean(self, *args, **kwargs):
+ """Check valid form and keyword arguments given"""
+ cleaned_data = super(VetCommentaryForm, self).clean(*args, **kwargs)
+
+ # Check valid `commentary_id`
+ if not self.commentary_id:
+ self.add_error(None, 'No `commentary_id` provided')
+ return cleaned_data
+ else:
+ self.commentary = Commentary.objects.select_related('requested_by__user').get(pk=self.commentary_id)
+
+ # Check valid `user`
+ if not self.user:
+ self.add_error(None, 'No `user` provided')
+ return cleaned_data
+
+ self.is_cleaned = True
+ return cleaned_data
+
+ def _form_is_cleaned(self):
+ """Raise ValueError if form isn't validated"""
+ if not self.is_cleaned:
+ raise ValueError(('VetCommentaryForm could not be processed '
+ 'because the data didn\'t validate'))
+
+ def get_commentary(self):
+ """Return Commentary if available"""
+ self._form_is_cleaned()
+ return self.commentary
+
+ def get_refusal_reason(self):
+ """Return refusal reason"""
+ if self.commentary_is_refused():
+ return self.COMMENTARY_REFUSAL_DICT[int(self.cleaned_data['refusal_reason'])]
+
+ def commentary_is_accepted(self):
+ self._form_is_cleaned()
+ return int(self.cleaned_data['action_option']) == self.ACTION_ACCEPT
+
+ def commentary_is_modified(self):
+ self._form_is_cleaned()
+ return int(self.cleaned_data['action_option']) == self.ACTION_MODIFY
+
+ def commentary_is_refused(self):
+ self._form_is_cleaned()
+ return int(self.cleaned_data['action_option']) == self.ACTION_REFUSE
+
+ def process_commentary(self):
+ """Vet the commentary or delete it from the database"""
+ if self.commentary_is_accepted():
+ self.commentary.vetted = True
+ self.commentary.vetted_by = Contributor.objects.get(user=self.user)
+ self.commentary.save()
+ return self.commentary
+ elif self.commentary_is_modified() or self.commentary_is_refused():
+ self.commentary.delete()
+ return None
+
+
class CommentarySearchForm(forms.Form):
+ """Search for Commentary specified by user"""
pub_author = forms.CharField(max_length=100, required=False, label="Author(s)")
- pub_title_keyword = forms.CharField(max_length=100, label="Title", required=False)
+ pub_title_keyword = forms.CharField(max_length=100, required=False, label="Title")
pub_abstract_keyword = forms.CharField(max_length=1000, required=False, label="Abstract")
+
+ def search_results(self):
+ """Return all Commentary objects according to search"""
+ return Commentary.objects.vetted(
+ pub_title__icontains=self.cleaned_data['pub_title_keyword'],
+ pub_abstract__icontains=self.cleaned_data['pub_abstract_keyword'],
+ author_list__icontains=self.cleaned_data['pub_author']).order_by('-pub_date')
diff --git a/commentaries/migrations/0013_auto_20161213_2328.py b/commentaries/migrations/0013_auto_20161213_2328.py
new file mode 100644
index 0000000000000000000000000000000000000000..ec27da0367e4f87026cfc64b8131232f62bfb3cc
--- /dev/null
+++ b/commentaries/migrations/0013_auto_20161213_2328.py
@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2016-12-13 22:28
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.utils.timezone
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('commentaries', '0012_remove_commentary_specialization'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='commentary',
+ name='created',
+ field=models.DateTimeField(auto_now_add=True, default=django.utils.timezone.now),
+ preserve_default=False,
+ ),
+ migrations.AlterField(
+ model_name='commentary',
+ name='latest_activity',
+ field=models.DateTimeField(auto_now=True),
+ ),
+ ]
diff --git a/commentaries/models.py b/commentaries/models.py
index c216ce3599e806f4ec35c2925dcb8d49c7b3caf2..903ed64694b73410a780c92581ba4df1243e8d2c 100644
--- a/commentaries/models.py
+++ b/commentaries/models.py
@@ -1,70 +1,85 @@
from django.utils import timezone
from django.db import models
-from django.contrib.auth.models import User
from django.contrib.postgres.fields import JSONField
from django.template import Template, Context
from journals.models import SCIPOST_JOURNALS_DOMAINS, SCIPOST_JOURNALS_SPECIALIZATIONS
-from scipost.models import Contributor
-from scipost.models import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS
-
-
+from scipost.models import TimeStampedModel, Contributor
+from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS
COMMENTARY_TYPES = (
('published', 'published paper'),
('preprint', 'arXiv preprint'),
)
-class Commentary(models.Model):
+
+class CommentaryManager(models.Manager):
+ def vetted(self, **kwargs):
+ return self.filter(vetted=True, **kwargs)
+
+ def awaiting_vetting(self, **kwargs):
+ return self.filter(vetted=False, **kwargs)
+
+class Commentary(TimeStampedModel):
"""
A Commentary contains all the contents of a SciPost Commentary page for a given publication.
"""
- requested_by = models.ForeignKey (Contributor, blank=True, null=True,
- on_delete=models.CASCADE, related_name='requested_by')
+ requested_by = models.ForeignKey(
+ Contributor, blank=True, null=True,
+ on_delete=models.CASCADE, related_name='requested_by')
vetted = models.BooleanField(default=False)
- vetted_by = models.ForeignKey (Contributor, blank=True, null=True, on_delete=models.CASCADE)
- type = models.CharField(max_length=9, choices=COMMENTARY_TYPES) # published paper or arxiv preprint
+ vetted_by = models.ForeignKey(Contributor, blank=True, null=True, on_delete=models.CASCADE)
+ type = models.CharField(max_length=9, choices=COMMENTARY_TYPES)
discipline = models.CharField(max_length=20, choices=SCIPOST_DISCIPLINES, default='physics')
domain = models.CharField(max_length=3, choices=SCIPOST_JOURNALS_DOMAINS)
-# specialization = models.CharField(max_length=1, choices=SCIPOST_JOURNALS_SPECIALIZATIONS)
- subject_area = models.CharField(max_length=10, choices=SCIPOST_SUBJECT_AREAS, default='Phys:QP')
+ subject_area = models.CharField(
+ max_length=10, choices=SCIPOST_SUBJECT_AREAS,
+ default='Phys:QP')
open_for_commenting = models.BooleanField(default=True)
pub_title = models.CharField(max_length=300, verbose_name='title')
- arxiv_identifier = models.CharField(max_length=100,
- verbose_name="arXiv identifier (including version nr)",
- blank=True, null=True)
+ arxiv_identifier = models.CharField(
+ max_length=100, verbose_name="arXiv identifier (including version nr)",
+ blank=True, null=True)
arxiv_link = models.URLField(verbose_name='arXiv link (including version nr)', blank=True)
- pub_DOI = models.CharField(max_length=200, verbose_name='DOI of the original publication',
- blank=True, null=True)
- pub_DOI_link = models.URLField(verbose_name='DOI link to the original publication', blank=True)
+ pub_DOI = models.CharField(
+ max_length=200, verbose_name='DOI of the original publication',
+ blank=True, null=True)
+ pub_DOI_link = models.URLField(
+ verbose_name='DOI link to the original publication',
+ blank=True)
metadata = JSONField(default={}, blank=True, null=True)
arxiv_or_DOI_string = models.CharField(
max_length=100,
verbose_name='string form of arxiv nr or DOI for commentary url',
default='')
author_list = models.CharField(max_length=1000)
+
# Authors which have been mapped to contributors:
- authors = models.ManyToManyField (Contributor, blank=True,
- related_name='authors_com')
- authors_claims = models.ManyToManyField (Contributor, blank=True,
- related_name='authors_com_claims')
- authors_false_claims = models.ManyToManyField (Contributor, blank=True,
- related_name='authors_com_false_claims')
+ authors = models.ManyToManyField(
+ Contributor, blank=True,
+ related_name='authors_com')
+ authors_claims = models.ManyToManyField(
+ Contributor, blank=True,
+ related_name='authors_com_claims')
+ authors_false_claims = models.ManyToManyField(
+ Contributor, blank=True,
+ related_name='authors_com_false_claims')
journal = models.CharField(max_length=300, blank=True, null=True)
volume = models.CharField(max_length=50, blank=True, null=True)
pages = models.CharField(max_length=50, blank=True, null=True)
- pub_date = models.DateField(verbose_name='date of original publication', blank=True, null=True)
+ pub_date = models.DateField(
+ verbose_name='date of original publication',
+ blank=True, null=True)
pub_abstract = models.TextField(verbose_name='abstract')
- latest_activity = models.DateTimeField(default=timezone.now)
+
+ objects = CommentaryManager()
class Meta:
verbose_name_plural = 'Commentaries'
-
def __str__(self):
return self.pub_title
-
def header_as_table(self):
# for display in Commentary page itself
header = ('<table>'
@@ -93,8 +108,8 @@ class Commentary(models.Model):
header += '</table>'
template = Template(header)
context = Context({
- 'pub_title': self.pub_title, 'author_list': self.author_list,
- })
+ 'pub_title': self.pub_title, 'author_list': self.author_list,
+ })
if self.type == 'published':
context['journal'] = self.journal
context['volume'] = self.volume
@@ -105,7 +120,6 @@ class Commentary(models.Model):
context['arxiv_link'] = self.arxiv_link
return template.render(context)
-
def header_as_li(self):
# for display in search lists
context = Context({'scipost_url': self.scipost_url(), 'pub_title': self.pub_title,
@@ -136,7 +150,6 @@ class Commentary(models.Model):
return template.render(context)
-
def simple_header_as_li(self):
# for display in Lists
context = Context({'scipost_url': self.scipost_url(), 'pub_title': self.pub_title,
@@ -158,7 +171,6 @@ class Commentary(models.Model):
template = Template(header)
return template.render(context)
-
def parse_links_into_urls(self):
""" Takes the arXiv nr or DOI and turns it into the urls """
if self.pub_DOI:
diff --git a/commentaries/templates/commentaries/vet_commentary_email_accepted.html b/commentaries/templates/commentaries/vet_commentary_email_accepted.html
new file mode 100644
index 0000000000000000000000000000000000000000..69ba77f82041bc55e7d95c3dc5b34f4e486de797
--- /dev/null
+++ b/commentaries/templates/commentaries/vet_commentary_email_accepted.html
@@ -0,0 +1,7 @@
+Dear {{commentary.requested_by.get_title}} {{commentary.requested_by.user.last_name}},
+
+The Commentary Page you have requested, concerning publication with title {{commentary.pub_title}} by {{commentary.author_list}}, has been activated at https://scipost.org/commentary/'{{commentary.arxiv_or_DOI_string}}.
+You are now welcome to submit your comments.
+
+Thank you for your contribution,
+The SciPost Team.
diff --git a/commentaries/templates/commentaries/vet_commentary_email_modified.html b/commentaries/templates/commentaries/vet_commentary_email_modified.html
new file mode 100644
index 0000000000000000000000000000000000000000..f3ad85365c4ab2f4398dc9b9e644aeece54b7559
--- /dev/null
+++ b/commentaries/templates/commentaries/vet_commentary_email_modified.html
@@ -0,0 +1,7 @@
+Dear {{commentary.requested_by.get_title}} {{commentary.requested_by.user.last_name}},
+
+The Commentary Page you have requested, concerning publication with title {{commentary.pub_title}} by {{commentary.author_list}}, has been activated (with slight modifications to your submitted details).
+You are now welcome to submit your comments.
+
+Thank you for your contribution,
+The SciPost Team.
diff --git a/commentaries/templates/commentaries/vet_commentary_email_rejected.html b/commentaries/templates/commentaries/vet_commentary_email_rejected.html
new file mode 100644
index 0000000000000000000000000000000000000000..b9d99fade03b2a34cfcb59728285f97b7e677c61
--- /dev/null
+++ b/commentaries/templates/commentaries/vet_commentary_email_rejected.html
@@ -0,0 +1,11 @@
+Dear {{commentary.requested_by.get_title}} {{commentary.requested_by.user.last_name}},
+
+The Commentary Page you have requested, concerning publication with title {{commentary.pub_title}} by {{commentary.author_list}}, has not been activated for the following reason: {{refusal_reason}}.
+
+{% if further_explanation %}
+Further explanations:
+{{further_explanation}}
+{% endif %}
+
+Thank you for your interest,
+The SciPost Team.
diff --git a/commentaries/test_forms.py b/commentaries/test_forms.py
new file mode 100644
index 0000000000000000000000000000000000000000..bd41e58a1a4105431445cd280f0ddb6fbb3589f0
--- /dev/null
+++ b/commentaries/test_forms.py
@@ -0,0 +1,137 @@
+from django.test import TestCase
+
+from scipost.factories import UserFactory
+
+from .models import Commentary
+from .factories import VettedCommentaryFactory, UnVettedCommentaryFactory
+from .forms import RequestCommentaryForm, VetCommentaryForm
+from common.helpers import model_form_data
+
+
+class TestVetCommentaryForm(TestCase):
+ fixtures = ['permissions', 'groups']
+
+ def setUp(self):
+ self.commentary = UnVettedCommentaryFactory.create()
+ self.user = UserFactory()
+ self.form_data = {
+ 'action_option': VetCommentaryForm.ACTION_ACCEPT,
+ 'refusal_reason': VetCommentaryForm.REFUSAL_EMPTY,
+ 'email_response_field': 'Lorem Ipsum'
+ }
+
+ def test_valid_accepted_form(self):
+ """Test valid form data and return Commentary"""
+ form = VetCommentaryForm(self.form_data, commentary_id=self.commentary.id, user=self.user)
+ self.assertTrue(form.is_valid())
+ self.assertFalse(Commentary.objects.vetted().exists())
+ self.assertTrue(Commentary.objects.awaiting_vetting().exists())
+
+ # Accept Commentary in database
+ form.process_commentary()
+ self.assertTrue(Commentary.objects.vetted().exists())
+ self.assertFalse(Commentary.objects.awaiting_vetting().exists())
+
+ def test_valid_modified_form(self):
+ """Test valid form data and delete Commentary"""
+ self.form_data['action_option'] = VetCommentaryForm.ACTION_MODIFY
+ form = VetCommentaryForm(self.form_data, commentary_id=self.commentary.id, user=self.user)
+ self.assertTrue(form.is_valid())
+ self.assertFalse(Commentary.objects.vetted().exists())
+ self.assertTrue(Commentary.objects.awaiting_vetting().exists())
+
+ # Delete the Commentary
+ form.process_commentary()
+ self.assertTrue(form.commentary_is_modified())
+ self.assertFalse(Commentary.objects.awaiting_vetting().exists())
+
+ def test_valid_rejected_form(self):
+ """Test valid form data and delete Commentary"""
+ self.form_data['action_option'] = VetCommentaryForm.ACTION_REFUSE
+ self.form_data['refusal_reason'] = VetCommentaryForm.REFUSAL_UNTRACEBLE
+ form = VetCommentaryForm(self.form_data, commentary_id=self.commentary.id, user=self.user)
+ self.assertTrue(form.is_valid())
+ self.assertFalse(Commentary.objects.vetted().exists())
+ self.assertTrue(Commentary.objects.awaiting_vetting().exists())
+
+ # Delete the Commentary
+ form.process_commentary()
+ self.assertTrue(form.commentary_is_refused())
+ self.assertFalse(Commentary.objects.awaiting_vetting().exists())
+
+ # Refusal choice is ok
+ refusal_reason_inserted = VetCommentaryForm.COMMENTARY_REFUSAL_DICT[\
+ VetCommentaryForm.REFUSAL_UNTRACEBLE]
+ self.assertEqual(form.get_refusal_reason(), refusal_reason_inserted)
+
+ def test_process_before_validation(self):
+ """Test response of form on processing before validation"""
+ form = VetCommentaryForm(self.form_data, commentary_id=self.commentary.id, user=self.user)
+ self.assertRaises(ValueError, form.process_commentary)
+
+
+class TestRequestCommentaryForm(TestCase):
+ fixtures = ['permissions', 'groups']
+
+ def setUp(self):
+ factory_instance = VettedCommentaryFactory.build()
+ self.user = UserFactory()
+ self.valid_form_data = model_form_data(factory_instance, RequestCommentaryForm)
+
+ def empty_and_return_form_data(self, key):
+ """Empty specific valid_form_data field and return"""
+ self.valid_form_data[key] = None
+ return self.valid_form_data
+
+ def test_valid_data_is_valid_for_arxiv(self):
+ """Test valid form for Arxiv identifier"""
+ form_data = self.valid_form_data
+ form_data['pub_DOI'] = ''
+ form = RequestCommentaryForm(form_data, user=self.user)
+ self.assertTrue(form.is_valid())
+
+ def test_valid_data_is_valid_for_DOI(self):
+ """Test valid form for DOI"""
+ form_data = self.valid_form_data
+ form_data['arxiv_identifier'] = ''
+ form = RequestCommentaryForm(form_data, user=self.user)
+ self.assertTrue(form.is_valid())
+
+ def test_form_has_no_identifiers(self):
+ """Test invalid form has no DOI nor Arxiv ID"""
+ form_data = self.valid_form_data
+ form_data['pub_DOI'] = ''
+ form_data['arxiv_identifier'] = ''
+ form = RequestCommentaryForm(form_data, user=self.user)
+ self.assertFalse(form.is_valid())
+ self.assertTrue('arxiv_identifier' in form.errors)
+ self.assertTrue('pub_DOI' in form.errors)
+
+ def test_form_with_duplicate_DOI(self):
+ """Test form response with already existing DOI"""
+ # Create a factory instance containing Arxiv ID and DOI
+ VettedCommentaryFactory.create()
+
+ # Test duplicate DOI entry
+ form_data = self.empty_and_return_form_data('arxiv_identifier')
+ form = RequestCommentaryForm(form_data, user=self.user)
+ self.assertTrue('pub_DOI' in form.errors)
+ self.assertFalse(form.is_valid())
+
+ # Check is existing commentary is valid
+ existing_commentary = form.get_existing_commentary()
+ self.assertEqual(existing_commentary.pub_DOI, form_data['pub_DOI'])
+
+ def test_form_with_duplicate_arxiv_id(self):
+ """Test form response with already existing Arxiv ID"""
+ VettedCommentaryFactory.create()
+
+ # Test duplicate Arxiv entry
+ form_data = self.empty_and_return_form_data('pub_DOI')
+ form = RequestCommentaryForm(form_data, user=self.user)
+ self.assertTrue('arxiv_identifier' in form.errors)
+ self.assertFalse(form.is_valid())
+
+ # Check is existing commentary is valid
+ existing_commentary = form.get_existing_commentary()
+ self.assertEqual(existing_commentary.arxiv_identifier, form_data['arxiv_identifier'])
diff --git a/commentaries/test_models.py b/commentaries/test_models.py
new file mode 100644
index 0000000000000000000000000000000000000000..2e9cb5f6ba351402af656aec1be5d9ac257bc5c0
--- /dev/null
+++ b/commentaries/test_models.py
@@ -0,0 +1 @@
+from django.test import TestCase
diff --git a/commentaries/test_views.py b/commentaries/test_views.py
new file mode 100644
index 0000000000000000000000000000000000000000..682a28b4b229b6ac21ae42325e0619f65f303f57
--- /dev/null
+++ b/commentaries/test_views.py
@@ -0,0 +1,29 @@
+from django.core.urlresolvers import reverse
+from django.test import TestCase
+
+
+class RequestCommentaryTest(TestCase):
+ """Test cases for `request_commentary` view method"""
+ fixtures = ['permissions', 'groups', 'contributors']
+
+ def setUp(self):
+ self.view_url = reverse('commentaries:request_commentary')
+ self.login_url = reverse('scipost:login')
+ self.redirected_login_url = '%s?next=%s' % (self.login_url, self.view_url)
+
+ def test_get_requests(self):
+ """Test different GET requests on view"""
+ # Anoymous user should redirect to login page
+ request = self.client.get(self.view_url)
+ self.assertRedirects(request, self.redirected_login_url)
+
+ # Registered Contributor should get 200
+ self.client.login(username="Test", password="testpw")
+ request = self.client.get(self.view_url)
+ self.assertEquals(request.status_code, 200)
+
+ def test_post_invalid_forms(self):
+ """Test different kind of invalid RequestCommentaryForm submits"""
+ self.client.login(username="Test", password="testpw")
+ request = self.client.post(self.view_url)
+ self.assertEquals(request.status_code, 200)
diff --git a/commentaries/views.py b/commentaries/views.py
index 88f4d7c69b97e0c58870415078bd703ea2afa578..aa653f178663c94fbdecb8bca2d708691b73bfe3 100644
--- a/commentaries/views.py
+++ b/commentaries/views.py
@@ -6,19 +6,17 @@ import requests
from django.db.models import Q
from django.utils import timezone
from django.shortcuts import get_object_or_404, render
-from django.contrib.auth import authenticate, login, logout
+from django.contrib.auth import login, logout
from django.contrib.auth.decorators import login_required, permission_required
-from django.contrib.auth.models import User
from django.core.mail import EmailMessage
from django.core.urlresolvers import reverse
-from django.http import HttpResponse, HttpResponseRedirect
+from django.http import HttpResponse
from django.shortcuts import redirect
-from django.views.decorators.csrf import csrf_protect
-from django.db.models import Avg
+from django.template.loader import render_to_string
from .models import Commentary
from .forms import RequestCommentaryForm, DOIToQueryForm, IdentifierToQueryForm
-from .forms import VetCommentaryForm, CommentarySearchForm, commentary_refusal_dict
+from .forms import VetCommentaryForm, CommentarySearchForm
from comments.models import Comment
from comments.forms import CommentForm
@@ -35,64 +33,29 @@ from scipost.forms import AuthenticationForm
@login_required
@permission_required('scipost.can_request_commentary_pages', raise_exception=True)
def request_commentary(request):
+ form = RequestCommentaryForm(request.POST or None, user=request.user)
if request.method == 'POST':
- form = RequestCommentaryForm(request.POST)
if form.is_valid():
- errormessage = ''
- existing_commentary = None
- if not form.cleaned_data['arxiv_identifier'] and not form.cleaned_data['pub_DOI']:
- errormessage = ('You must provide either a DOI (for a published paper) '
- 'or an arXiv identifier (for a preprint).')
- elif (form.cleaned_data['arxiv_identifier'] and
- (Commentary.objects
- .filter(arxiv_identifier=form.cleaned_data['arxiv_identifier']).exists())):
- errormessage = 'There already exists a Commentary Page on this preprint, see'
- existing_commentary = get_object_or_404(
- Commentary,
- arxiv_identifier=form.cleaned_data['arxiv_identifier'])
- elif (form.cleaned_data['pub_DOI'] and
- Commentary.objects.filter(pub_DOI=form.cleaned_data['pub_DOI']).exists()):
- errormessage = 'There already exists a Commentary Page on this publication, see'
- existing_commentary = get_object_or_404(Commentary, pub_DOI=form.cleaned_data['pub_DOI'])
- if errormessage:
- doiform = DOIToQueryForm()
- identifierform = IdentifierToQueryForm()
- context = {'form': form, 'doiform': doiform, 'identifierform': identifierform,
- 'errormessage': errormessage,
- 'existing_commentary': existing_commentary}
- return render(request, 'commentaries/request_commentary.html', context)
-
- # Otherwise we can create the Commentary
- contributor = Contributor.objects.get(user=request.user)
- commentary = Commentary (
- requested_by = contributor,
- type = form.cleaned_data['type'],
- discipline = form.cleaned_data['discipline'],
- domain = form.cleaned_data['domain'],
- subject_area = form.cleaned_data['subject_area'],
- pub_title = form.cleaned_data['pub_title'],
- arxiv_identifier = form.cleaned_data['arxiv_identifier'],
- pub_DOI = form.cleaned_data['pub_DOI'],
- metadata = form.cleaned_data['metadata'],
- author_list = form.cleaned_data['author_list'],
- journal = form.cleaned_data['journal'],
- volume = form.cleaned_data['volume'],
- pages = form.cleaned_data['pages'],
- pub_date = form.cleaned_data['pub_date'],
- pub_abstract = form.cleaned_data['pub_abstract'],
- latest_activity = timezone.now(),
- )
+ commentary = form.save(commit=False)
commentary.parse_links_into_urls()
commentary.save()
-
+
context = {'ack_header': 'Thank you for your request for a Commentary Page',
'ack_message': 'Your request will soon be handled by an Editor. ',
'followup_message': 'Return to your ',
'followup_link': reverse('scipost:personal_page'),
'followup_link_label': 'personal page'}
return render(request, 'scipost/acknowledgement.html', context)
- else:
- form = RequestCommentaryForm()
+
+ else:
+ doiform = DOIToQueryForm()
+ existing_commentary = form.get_existing_commentary()
+ identifierform = IdentifierToQueryForm()
+ context = {'form': form, 'doiform': doiform, 'identifierform': identifierform,
+ 'errormessage': form.errors,
+ 'existing_commentary': existing_commentary}
+ return render(request, 'commentaries/request_commentary.html', context)
+
doiform = DOIToQueryForm()
identifierform = IdentifierToQueryForm()
context = {'form': form, 'doiform': doiform, 'identifierform': identifierform}
@@ -120,7 +83,7 @@ def prefill_using_DOI(request):
'errormessage': errormessage,
'existing_commentary': existing_commentary}
return render(request, 'commentaries/request_commentary.html', context)
-
+
# Otherwise we query Crossref for the information:
try:
queryurl = 'http://api.crossref.org/works/%s' % doiform.cleaned_data['doi']
@@ -133,12 +96,12 @@ def prefill_using_DOI(request):
for author in doiqueryJSON['message']['author'][1:]:
authorlist += ', ' + author['given'] + ' ' + author['family']
journal = doiqueryJSON['message']['container-title'][0]
-
+
try:
volume = doiqueryJSON['message']['volume']
except KeyError:
volume = ''
-
+
pages = ''
try:
pages = doiqueryJSON['message']['article-number'] # for Phys Rev
@@ -148,7 +111,7 @@ def prefill_using_DOI(request):
pages = doiqueryJSON['message']['page']
except KeyError:
pass
-
+
pub_date = ''
try:
pub_date = (str(doiqueryJSON['message']['issued']['date-parts'][0][0]) + '-' +
@@ -178,7 +141,7 @@ def prefill_using_DOI(request):
@permission_required('scipost.can_request_commentary_pages', raise_exception=True)
def prefill_using_identifier(request):
- """ Probes arXiv with the identifier, to pre-fill the form. """
+ """Probes arXiv with the identifier, to pre-fill the form"""
if request.method == "POST":
identifierform = IdentifierToQueryForm(request.POST)
if identifierform.is_valid():
@@ -209,7 +172,7 @@ def prefill_using_identifier(request):
queryurl = ('http://export.arxiv.org/api/query?id_list=%s'
% identifierform.cleaned_data['identifier'])
arxivquery = feedparser.parse(queryurl)
-
+
# If paper has been published, should comment on published version
try:
arxiv_journal_ref = arxivquery['entries'][0]['arxiv_journal_ref']
@@ -223,7 +186,7 @@ def prefill_using_identifier(request):
+ '. Please comment on the published version.')
except (IndexError, KeyError):
pass
-
+
if errormessage:
form = RequestCommentaryForm()
doiform = DOIToQueryForm()
@@ -231,7 +194,7 @@ def prefill_using_identifier(request):
'errormessage': errormessage,
'existing_commentary': existing_commentary}
return render(request, 'commentaries/request_commentary.html', context)
-
+
# otherwise prefill the form:
metadata = arxivquery
pub_title = arxivquery['entries'][0]['title']
@@ -264,8 +227,9 @@ def prefill_using_identifier(request):
@permission_required('scipost.can_vet_commentary_requests', raise_exception=True)
def vet_commentary_requests(request):
+ """Show the first commentary thats awaiting vetting"""
contributor = Contributor.objects.get(user=request.user)
- commentary_to_vet = Commentary.objects.filter(vetted=False).first() # only handle one at a time
+ commentary_to_vet = Commentary.objects.awaiting_vetting().first() # only handle one at a time
form = VetCommentaryForm()
context = {'contributor': contributor, 'commentary_to_vet': commentary_to_vet, 'form': form }
return render(request, 'commentaries/vet_commentary_requests.html', context)
@@ -273,74 +237,49 @@ def vet_commentary_requests(request):
@permission_required('scipost.can_vet_commentary_requests', raise_exception=True)
def vet_commentary_request_ack(request, commentary_id):
if request.method == 'POST':
- form = VetCommentaryForm(request.POST)
- commentary = Commentary.objects.get(pk=commentary_id)
+ form = VetCommentaryForm(request.POST, user=request.user, commentary_id=commentary_id)
if form.is_valid():
- if form.cleaned_data['action_option'] == '1':
- # accept the commentary as is
- commentary.vetted = True
- commentary.vetted_by = Contributor.objects.get(user=request.user)
- commentary.latest_activity = timezone.now()
- commentary.save()
- email_text = ('Dear ' + title_dict[commentary.requested_by.title] + ' '
- + commentary.requested_by.user.last_name
- + ', \n\nThe Commentary Page you have requested, '
- 'concerning publication with title '
- + commentary.pub_title + ' by ' + commentary.author_list
- + ', has been activated at https://scipost.org/commentary/'
- + str(commentary.arxiv_or_DOI_string)
- + '. You are now welcome to submit your comments.'
- '\n\nThank you for your contribution, \nThe SciPost Team.')
- emailmessage = EmailMessage('SciPost Commentary Page activated', email_text,
- 'SciPost commentaries <commentaries@scipost.org>',
- [commentary.requested_by.user.email],
- ['commentaries@scipost.org'],
- reply_to=['commentaries@scipost.org'])
- emailmessage.send(fail_silently=False)
- elif form.cleaned_data['action_option'] == '0':
- # re-edit the form starting from the data provided
- form2 = RequestCommentaryForm(initial={'pub_title': commentary.pub_title,
- 'arxiv_link': commentary.arxiv_link,
- 'pub_DOI_link': commentary.pub_DOI_link,
- 'author_list': commentary.author_list,
- 'pub_date': commentary.pub_date,
- 'pub_abstract': commentary.pub_abstract})
- commentary.delete()
- email_text = ('Dear ' + title_dict[commentary.requested_by.title] + ' '
- + commentary.requested_by.user.last_name
- + ', \n\nThe Commentary Page you have requested, '
- 'concerning publication with title ' + commentary.pub_title
- + ' by ' + commentary.author_list
- + ', has been activated (with slight modifications to your submitted details).'
- ' You are now welcome to submit your comments.'
- '\n\nThank you for your contribution, \nThe SciPost Team.')
- emailmessage = EmailMessage('SciPost Commentary Page activated', email_text,
- 'SciPost commentaries <commentaries@scipost.org>',
- [commentary.requested_by.user.email],
- ['commentaries@scipost.org'],
- reply_to=['commentaries@scipost.org'])
- emailmessage.send(fail_silently=False)
- context = {'form': form2 }
+ # Get commentary
+ commentary = form.get_commentary()
+ email_context = {
+ 'commentary': commentary
+ }
+
+ # Retrieve email_template for action
+ if form.commentary_is_accepted():
+ email_template = 'commentaries/vet_commentary_email_accepted.html'
+ elif form.commentary_is_modified():
+ email_template = 'commentaries/vet_commentary_email_modified.html'
+
+ request_commentary_form = RequestCommentaryForm(initial={
+ 'pub_title': commentary.pub_title,
+ 'arxiv_link': commentary.arxiv_link,
+ 'pub_DOI_link': commentary.pub_DOI_link,
+ 'author_list': commentary.author_list,
+ 'pub_date': commentary.pub_date,
+ 'pub_abstract': commentary.pub_abstract
+ })
+ elif form.commentary_is_refused():
+ email_template = 'commentaries/vet_commentary_email_rejected.html'
+ email_context['refusal_reason'] = form.get_refusal_reason()
+ email_context['further_explanation'] = form.cleaned_data['email_response_field']
+
+ # Send email and process form
+ email_text = render_to_string(email_template, email_context)
+ email_args = (
+ 'SciPost Commentary Page activated',
+ email_text,
+ [commentary.requested_by.user.email],
+ ['commentaries@scipost.org']
+ )
+ emailmessage = EmailMessage(*email_args, reply_to=['commentaries@scipost.org'])
+ emailmessage.send(fail_silently=False)
+ commentary = form.process_commentary()
+
+ # For a modified commentary, redirect to request_commentary_form
+ if form.commentary_is_modified():
+ context = {'form': request_commentary_form}
return render(request, 'commentaries/request_commentary.html', context)
- elif form.cleaned_data['action_option'] == '2':
- # the commentary request is simply rejected
- email_text = ('Dear ' + title_dict[commentary.requested_by.title] + ' '
- + commentary.requested_by.user.last_name
- + ', \n\nThe Commentary Page you have requested, '
- 'concerning publication with title '
- + commentary.pub_title + ' by ' + commentary.author_list
- + ', has not been activated for the following reason: '
- + commentary_refusal_dict[int(form.cleaned_data['refusal_reason'])]
- + '.\n\nThank you for your interest, \nThe SciPost Team.')
- if form.cleaned_data['email_response_field']:
- email_text += '\n\nFurther explanations: ' + form.cleaned_data['email_response_field']
- emailmessage = EmailMessage('SciPost Commentary Page activated', email_text,
- 'SciPost commentaries <commentaries@scipost.org>',
- [commentary.requested_by.user.email],
- ['commentaries@scipost.org'],
- reply_to=['comentaries@scipost.org'])
- emailmessage.send(fail_silently=False)
- commentary.delete()
context = {'ack_header': 'SciPost Commentary request vetted.',
'followup_message': 'Return to the ',
@@ -348,62 +287,33 @@ def vet_commentary_request_ack(request, commentary_id):
'followup_link_label': 'Commentary requests page'}
return render(request, 'scipost/acknowledgement.html', context)
-
def commentaries(request):
- if request.method == 'POST':
- form = CommentarySearchForm(request.POST)
- if form.is_valid() and form.has_changed():
- commentary_search_list = Commentary.objects.filter(
- pub_title__icontains=form.cleaned_data['pub_title_keyword'],
- author_list__icontains=form.cleaned_data['pub_author'],
- pub_abstract__icontains=form.cleaned_data['pub_abstract_keyword'],
- vetted=True,
- )
- commentary_search_list.order_by('-pub_date')
- else:
- commentary_search_list = []
-
+ """List and search all commentaries"""
+ form = CommentarySearchForm(request.POST or None)
+ if form.is_valid() and form.has_changed():
+ commentary_search_list = form.search_results()
else:
- form = CommentarySearchForm()
commentary_search_list = []
- comment_recent_list = (Comment.objects.filter(status='1')
- .order_by('-date_submitted')[:10])
-
- commentary_recent_list = (Commentary.objects.filter(vetted=True)
- .order_by('-latest_activity')[:10])
- context = {'form': form, 'commentary_search_list': commentary_search_list,
- 'comment_recent_list': comment_recent_list,
- 'commentary_recent_list': commentary_recent_list }
+ comment_recent_list = Comment.objects.filter(status='1').order_by('-date_submitted')[:10]
+ commentary_recent_list = Commentary.objects.vetted().order_by('-latest_activity')[:10]
+ context = {
+ 'form': form, 'commentary_search_list': commentary_search_list,
+ 'comment_recent_list': comment_recent_list,
+ 'commentary_recent_list': commentary_recent_list}
return render(request, 'commentaries/commentaries.html', context)
-
def browse(request, discipline, nrweeksback):
- if request.method == 'POST':
- form = CommentarySearchForm(request.POST)
- if form.is_valid() and form.has_changed():
- commentary_search_list = Commentary.objects.filter(
- pub_title__icontains=form.cleaned_data['pub_title_keyword'],
- author_list__icontains=form.cleaned_data['pub_author'],
- pub_abstract__icontains=form.cleaned_data['pub_abstract_keyword'],
- vetted=True,
- )
- commentary_search_list.order_by('-pub_date')
- else:
- commentary_search_list = []
- context = {'form': form, 'commentary_search_list': commentary_search_list}
- return HttpResponseRedirect(request, 'commentaries/commentaries.html', context)
- else:
- form = CommentarySearchForm()
- commentary_browse_list = Commentary.objects.filter(
- vetted=True, discipline=discipline,
- latest_activity__gte=timezone.now() + datetime.timedelta(weeks=-int(nrweeksback))
- )
- context = {'form': form, 'discipline': discipline, 'nrweeksback': nrweeksback,
- 'commentary_browse_list': commentary_browse_list }
+ """List all commentaries for discipline and period"""
+ commentary_browse_list = Commentary.objects.vetted(
+ discipline=discipline,
+ latest_activity__gte=timezone.now() + datetime.timedelta(weeks=-int(nrweeksback)))
+ context = {
+ 'form': CommentarySearchForm(),
+ 'discipline': discipline, 'nrweeksback': nrweeksback,
+ 'commentary_browse_list': commentary_browse_list}
return render(request, 'commentaries/commentaries.html', context)
-
def commentary_detail(request, arxiv_or_DOI_string):
commentary = get_object_or_404(Commentary, arxiv_or_DOI_string=arxiv_or_DOI_string)
comments = commentary.comment_set.all()
diff --git a/journals/models.py b/journals/models.py
index 4e3af2ad28c050da662e6ba7dcdddbf3ef57a851..f5b65028034176f1c7e97d1ee01d00958df8defc 100644
--- a/journals/models.py
+++ b/journals/models.py
@@ -3,8 +3,8 @@ from django.db import models
from django.template import Template, Context
from django.utils import timezone
-from scipost.models import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS, subject_areas_dict, TITLE_CHOICES
-from scipost.models import ChoiceArrayField, Contributor
+from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS, subject_areas_dict
+from scipost.models import ChoiceArrayField, Contributor, TITLE_CHOICES
class UnregisteredAuthor(models.Model):
diff --git a/scipost/constants.py b/scipost/constants.py
new file mode 100644
index 0000000000000000000000000000000000000000..7c7933e18e787769f830f999423730a6af836d82
--- /dev/null
+++ b/scipost/constants.py
@@ -0,0 +1,120 @@
+SCIPOST_DISCIPLINES = (
+ ('physics', 'Physics'),
+ ('astrophysics', 'Astrophysics'),
+ ('mathematics', 'Mathematics'),
+ ('computerscience', 'Computer Science'),
+ )
+disciplines_dict = dict(SCIPOST_DISCIPLINES)
+
+SCIPOST_SUBJECT_AREAS = (
+ ('Physics', (
+ ('Phys:AE', 'Atomic, Molecular and Optical Physics - Experiment'),
+ ('Phys:AT', 'Atomic, Molecular and Optical Physics - Theory'),
+ ('Phys:BI', 'Biophysics'),
+ ('Phys:CE', 'Condensed Matter Physics - Experiment'),
+ ('Phys:CT', 'Condensed Matter Physics - Theory'),
+ ('Phys:FD', 'Fluid Dynamics'),
+ ('Phys:GR', 'Gravitation, Cosmology and Astroparticle Physics'),
+ ('Phys:HE', 'High-Energy Physics - Experiment'),
+ ('Phys:HT', 'High-Energy Physics- Theory'),
+ ('Phys:HP', 'High-Energy Physics - Phenomenology'),
+ ('Phys:MP', 'Mathematical Physics'),
+ ('Phys:NE', 'Nuclear Physics - Experiment'),
+ ('Phys:NT', 'Nuclear Physics - Theory'),
+ ('Phys:QP', 'Quantum Physics'),
+ ('Phys:SM', 'Statistical and Soft Matter Physics'),
+ )
+ ),
+ ('Astrophysics', (
+ ('Astro:GA', 'Astrophysics of Galaxies'),
+ ('Astro:CO', 'Cosmology and Nongalactic Astrophysics'),
+ ('Astro:EP', 'Earth and Planetary Astrophysics'),
+ ('Astro:HE', 'High Energy Astrophysical Phenomena'),
+ ('Astro:IM', 'Instrumentation and Methods for Astrophysics'),
+ ('Astro:SR', 'Solar and Stellar Astrophysics'),
+ )
+ ),
+ ('Mathematics', (
+ ('Math:AG', 'Algebraic Geometry'),
+ ('Math:AT', 'Algebraic Topology'),
+ ('Math:AP', 'Analysis of PDEs'),
+ ('Math:CT', 'Category Theory'),
+ ('Math:CA', 'Classical Analysis and ODEs'),
+ ('Math:CO', 'Combinatorics'),
+ ('Math:AC', 'Commutative Algebra'),
+ ('Math:CV', 'Complex Variables'),
+ ('Math:DG', 'Differential Geometry'),
+ ('Math:DS', 'Dynamical Systems'),
+ ('Math:FA', 'Functional Analysis'),
+ ('Math:GM', 'General Mathematics'),
+ ('Math:GN', 'General Topology'),
+ ('Math:GT', 'Geometric Topology'),
+ ('Math:GR', 'Group Theory'),
+ ('Math:HO', 'History and Overview'),
+ ('Math:IT', 'Information Theory'),
+ ('Math:KT', 'K-Theory and Homology'),
+ ('Math:LO', 'Logic'),
+ ('Math:MP', 'Mathematical Physics'),
+ ('Math:MG', 'Metric Geometry'),
+ ('Math:NT', 'Number Theory'),
+ ('Math:NA', 'Numerical Analysis'),
+ ('Math:OA', 'Operator Algebras'),
+ ('Math:OC', 'Optimization and Control'),
+ ('Math:PR', 'Probability'),
+ ('Math:QA', 'Quantum Algebra'),
+ ('Math:RT', 'Representation Theory'),
+ ('Math:RA', 'Rings and Algebras'),
+ ('Math:SP', 'Spectral Theory'),
+ ('Math:ST', 'Statistics Theory'),
+ ('Math:SG', 'Symplectic Geometry'),
+ )
+ ),
+ ('Computer Science', (
+ ('Comp:AI', 'Artificial Intelligence'),
+ ('Comp:CC', 'Computational Complexity'),
+ ('Comp:CE', 'Computational Engineering, Finance, and Science'),
+ ('Comp:CG', 'Computational Geometry'),
+ ('Comp:GT', 'Computer Science and Game Theory'),
+ ('Comp:CV', 'Computer Vision and Pattern Recognition'),
+ ('Comp:CY', 'Computers and Society'),
+ ('Comp:CR', 'Cryptography and Security'),
+ ('Comp:DS', 'Data Structures and Algorithms'),
+ ('Comp:DB', 'Databases'),
+ ('Comp:DL', 'Digital Libraries'),
+ ('Comp:DM', 'Discrete Mathematics'),
+ ('Comp:DC', 'Distributed, Parallel, and Cluster Computing'),
+ ('Comp:ET', 'Emerging Technologies'),
+ ('Comp:FL', 'Formal Languages and Automata Theory'),
+ ('Comp:GL', 'General Literature'),
+ ('Comp:GR', 'Graphics'),
+ ('Comp:AR', 'Hardware Architecture'),
+ ('Comp:HC', 'Human-Computer Interaction'),
+ ('Comp:IR', 'Information Retrieval'),
+ ('Comp:IT', 'Information Theory'),
+ ('Comp:LG', 'Learning'),
+ ('Comp:LO', 'Logic in Computer Science'),
+ ('Comp:MS', 'Mathematical Software'),
+ ('Comp:MA', 'Multiagent Systems'),
+ ('Comp:MM', 'Multimedia'),
+ ('Comp:NI', 'Networking and Internet Architecture'),
+ ('Comp:NE', 'Neural and Evolutionary Computing'),
+ ('Comp:NA', 'Numerical Analysis'),
+ ('Comp:OS', 'Operating Systems'),
+ ('Comp:OH', 'Other Computer Science'),
+ ('Comp:PF', 'Performance'),
+ ('Comp:PL', 'Programming Languages'),
+ ('Comp:RO', 'Robotics'),
+ ('Comp:SI', 'Social and Information Networks'),
+ ('Comp:SE', 'Software Engineering'),
+ ('Comp:SD', 'Sound'),
+ ('Comp:SC', 'Symbolic Computation'),
+ ('Comp:SY', 'Systems and Control'),
+ )
+ ),
+)
+subject_areas_raw_dict = dict(SCIPOST_SUBJECT_AREAS)
+
+# Make dict of the form {'Phys:AT': 'Atomic...', ...}
+subject_areas_dict = {}
+for k in subject_areas_raw_dict.keys():
+ subject_areas_dict.update(dict(subject_areas_raw_dict[k]))
diff --git a/scipost/forms.py b/scipost/forms.py
index 3716ad8d83f4800b3c1e0eed0756279746f16bda..f8d0629bd7684d0ae9d2ee559d420167aadaf496 100644
--- a/scipost/forms.py
+++ b/scipost/forms.py
@@ -11,6 +11,7 @@ from crispy_forms.helper import FormHelper
from crispy_forms.layout import Layout, Div, Field, Fieldset, HTML, Submit
from .models import *
+from .constants import SCIPOST_DISCIPLINES
from journals.models import Publication
from submissions.models import SUBMISSION_STATUS_PUBLICLY_UNLISTED
diff --git a/scipost/models.py b/scipost/models.py
index 31e27a84a3986d012b3c6836443ac290619f855b..9fc4c36328d65f7573f4beec500951e27c832cbd 100644
--- a/scipost/models.py
+++ b/scipost/models.py
@@ -10,129 +10,10 @@ from django.utils.safestring import mark_safe
from django_countries.fields import CountryField
-from scipost.models import *
-
+from .constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS,\
+ disciplines_dict, subject_areas_dict
-SCIPOST_DISCIPLINES = (
- ('physics', 'Physics'),
- ('astrophysics', 'Astrophysics'),
- ('mathematics', 'Mathematics'),
- ('computerscience', 'Computer Science'),
- )
-disciplines_dict = dict(SCIPOST_DISCIPLINES)
-
-SCIPOST_SUBJECT_AREAS = (
- ('Physics', (
- ('Phys:AE', 'Atomic, Molecular and Optical Physics - Experiment'),
- ('Phys:AT', 'Atomic, Molecular and Optical Physics - Theory'),
- ('Phys:BI', 'Biophysics'),
- ('Phys:CE', 'Condensed Matter Physics - Experiment'),
- ('Phys:CT', 'Condensed Matter Physics - Theory'),
- ('Phys:FD', 'Fluid Dynamics'),
- ('Phys:GR', 'Gravitation, Cosmology and Astroparticle Physics'),
- ('Phys:HE', 'High-Energy Physics - Experiment'),
- ('Phys:HT', 'High-Energy Physics- Theory'),
- ('Phys:HP', 'High-Energy Physics - Phenomenology'),
- ('Phys:MP', 'Mathematical Physics'),
- ('Phys:NE', 'Nuclear Physics - Experiment'),
- ('Phys:NT', 'Nuclear Physics - Theory'),
- ('Phys:QP', 'Quantum Physics'),
- ('Phys:SM', 'Statistical and Soft Matter Physics'),
- )
- ),
- ('Astrophysics', (
- ('Astro:GA', 'Astrophysics of Galaxies'),
- ('Astro:CO', 'Cosmology and Nongalactic Astrophysics'),
- ('Astro:EP', 'Earth and Planetary Astrophysics'),
- ('Astro:HE', 'High Energy Astrophysical Phenomena'),
- ('Astro:IM', 'Instrumentation and Methods for Astrophysics'),
- ('Astro:SR', 'Solar and Stellar Astrophysics'),
- )
- ),
- ('Mathematics', (
- ('Math:AG', 'Algebraic Geometry'),
- ('Math:AT', 'Algebraic Topology'),
- ('Math:AP', 'Analysis of PDEs'),
- ('Math:CT', 'Category Theory'),
- ('Math:CA', 'Classical Analysis and ODEs'),
- ('Math:CO', 'Combinatorics'),
- ('Math:AC', 'Commutative Algebra'),
- ('Math:CV', 'Complex Variables'),
- ('Math:DG', 'Differential Geometry'),
- ('Math:DS', 'Dynamical Systems'),
- ('Math:FA', 'Functional Analysis'),
- ('Math:GM', 'General Mathematics'),
- ('Math:GN', 'General Topology'),
- ('Math:GT', 'Geometric Topology'),
- ('Math:GR', 'Group Theory'),
- ('Math:HO', 'History and Overview'),
- ('Math:IT', 'Information Theory'),
- ('Math:KT', 'K-Theory and Homology'),
- ('Math:LO', 'Logic'),
- ('Math:MP', 'Mathematical Physics'),
- ('Math:MG', 'Metric Geometry'),
- ('Math:NT', 'Number Theory'),
- ('Math:NA', 'Numerical Analysis'),
- ('Math:OA', 'Operator Algebras'),
- ('Math:OC', 'Optimization and Control'),
- ('Math:PR', 'Probability'),
- ('Math:QA', 'Quantum Algebra'),
- ('Math:RT', 'Representation Theory'),
- ('Math:RA', 'Rings and Algebras'),
- ('Math:SP', 'Spectral Theory'),
- ('Math:ST', 'Statistics Theory'),
- ('Math:SG', 'Symplectic Geometry'),
- )
- ),
- ('Computer Science', (
- ('Comp:AI', 'Artificial Intelligence'),
- ('Comp:CC', 'Computational Complexity'),
- ('Comp:CE', 'Computational Engineering, Finance, and Science'),
- ('Comp:CG', 'Computational Geometry'),
- ('Comp:GT', 'Computer Science and Game Theory'),
- ('Comp:CV', 'Computer Vision and Pattern Recognition'),
- ('Comp:CY', 'Computers and Society'),
- ('Comp:CR', 'Cryptography and Security'),
- ('Comp:DS', 'Data Structures and Algorithms'),
- ('Comp:DB', 'Databases'),
- ('Comp:DL', 'Digital Libraries'),
- ('Comp:DM', 'Discrete Mathematics'),
- ('Comp:DC', 'Distributed, Parallel, and Cluster Computing'),
- ('Comp:ET', 'Emerging Technologies'),
- ('Comp:FL', 'Formal Languages and Automata Theory'),
- ('Comp:GL', 'General Literature'),
- ('Comp:GR', 'Graphics'),
- ('Comp:AR', 'Hardware Architecture'),
- ('Comp:HC', 'Human-Computer Interaction'),
- ('Comp:IR', 'Information Retrieval'),
- ('Comp:IT', 'Information Theory'),
- ('Comp:LG', 'Learning'),
- ('Comp:LO', 'Logic in Computer Science'),
- ('Comp:MS', 'Mathematical Software'),
- ('Comp:MA', 'Multiagent Systems'),
- ('Comp:MM', 'Multimedia'),
- ('Comp:NI', 'Networking and Internet Architecture'),
- ('Comp:NE', 'Neural and Evolutionary Computing'),
- ('Comp:NA', 'Numerical Analysis'),
- ('Comp:OS', 'Operating Systems'),
- ('Comp:OH', 'Other Computer Science'),
- ('Comp:PF', 'Performance'),
- ('Comp:PL', 'Programming Languages'),
- ('Comp:RO', 'Robotics'),
- ('Comp:SI', 'Social and Information Networks'),
- ('Comp:SE', 'Software Engineering'),
- ('Comp:SD', 'Sound'),
- ('Comp:SC', 'Symbolic Computation'),
- ('Comp:SY', 'Systems and Control'),
- )
- ),
-)
-subject_areas_raw_dict = dict(SCIPOST_SUBJECT_AREAS)
-
-# Make dict of the form {'Phys:AT': 'Atomic...', ...}
-subject_areas_dict = {}
-for k in subject_areas_raw_dict.keys():
- subject_areas_dict.update(dict(subject_areas_raw_dict[k]))
+from scipost.models import *
class ChoiceArrayField(ArrayField):
@@ -179,6 +60,19 @@ TITLE_CHOICES = (
title_dict = dict(TITLE_CHOICES)
+class TimeStampedModel(models.Model):
+ """
+ All objects should inherit from this abstract model.
+ This will ensure the creation of created and modified
+ timestamps in the objects.
+ """
+ created = models.DateTimeField(auto_now_add=True)
+ latest_activity = models.DateTimeField(auto_now=True)
+
+ class Meta:
+ abstract = True
+
+
class Contributor(models.Model):
"""
All users of SciPost are Contributors.
@@ -215,6 +109,9 @@ class Contributor(models.Model):
def __str__(self):
return '%s, %s' % (self.user.last_name, self.user.first_name)
+ def get_title(self):
+ return title_dict[self.title]
+
def is_currently_available(self):
unav_periods = UnavailabilityPeriod.objects.filter(contributor=self)
diff --git a/submissions/models.py b/submissions/models.py
index 3ba5afaa0caeef7137e377f01222331dc86e6b6a..0ecd0511faf59794e06165781bcf84f35bd883f6 100644
--- a/submissions/models.py
+++ b/submissions/models.py
@@ -8,8 +8,8 @@ from django.template import Template, Context
from .models import *
from scipost.models import ChoiceArrayField, Contributor, title_dict, Remark
-from scipost.models import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS
-from scipost.models import subject_areas_dict, TITLE_CHOICES
+from scipost.constants import SCIPOST_DISCIPLINES, SCIPOST_SUBJECT_AREAS, subject_areas_dict
+from scipost.models import TITLE_CHOICES
from journals.models import SCIPOST_JOURNALS_SUBMIT, SCIPOST_JOURNALS_DOMAINS
from journals.models import SCIPOST_JOURNALS_SPECIALIZATIONS
from journals.models import journals_submit_dict, journals_domains_dict, journals_spec_dict
diff --git a/theses/migrations/0006_auto_20161219_2012.py b/theses/migrations/0006_auto_20161219_2012.py
new file mode 100644
index 0000000000000000000000000000000000000000..935f906aacc44850699e1d60558ba9c3fd845f31
--- /dev/null
+++ b/theses/migrations/0006_auto_20161219_2012.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.3 on 2016-12-19 19:12
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('theses', '0005_remove_thesislink_specialization'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='thesislink',
+ name='domain',
+ field=models.CharField(choices=[('E', 'Experimental'), ('T', 'Theoretical'), ('C', 'Computational'), ('ET', 'Exp. & Theor.'), ('EC', 'Exp. & Comp.'), ('TC', 'Theor. & Comp.'), ('ETC', 'Exp., Theor. & Comp.')], max_length=3),
+ ),
+ ]
diff --git a/theses/models.py b/theses/models.py
index 139948b9175deb6bc62fdc098bef6d3fc4a4ef86..50ec6b1f47548e9f43d6f53d31d091883f4ed091 100644
--- a/theses/models.py
+++ b/theses/models.py
@@ -6,6 +6,7 @@ from django.template import Template, Context
from .models import *
from journals.models import *
+from scipost.constants import SCIPOST_DISCIPLINES, subject_areas_dict, disciplines_dict
from scipost.models import *