From 8a5cbd47c4d4614bce18ba1621a89d37d2e7bb79 Mon Sep 17 00:00:00 2001
From: "J.-S. Caux" <J.S.Caux@uva.nl>
Date: Mon, 20 Jul 2020 13:55:34 +0200
Subject: [PATCH] Remove all arXiv-related fields in Submission (Preprint took
 over)

---
 preprints/models.py                           |  5 ++++
 submissions/forms.py                          |  2 +-
 .../migrations/0086_auto_20200720_1333.py     | 25 +++++++++++++++++++
 .../0087_remove_submission_arxiv_link.py      | 17 +++++++++++++
 submissions/models/submission.py              |  6 -----
 5 files changed, 48 insertions(+), 7 deletions(-)
 create mode 100644 submissions/migrations/0086_auto_20200720_1333.py
 create mode 100644 submissions/migrations/0087_remove_submission_arxiv_link.py

diff --git a/preprints/models.py b/preprints/models.py
index 29ed24509..773f4655f 100644
--- a/preprints/models.py
+++ b/preprints/models.py
@@ -51,6 +51,11 @@ class Preprint(models.Model):
             return "https://scipost.org%s" % self.get_absolute_url()
         return self.get_absolute_url().replace("/abs/", "/pdf/")
 
+    @property
+    def is_SciPost(self):
+        """Return True if this preprint is hosted on SciPost."""
+        return 'scipost_' in self.identifier_w_vn_nr
+
     @property
     def is_arXiv(self):
         """Return True if this preprint is hosted on arXiv."""
diff --git a/submissions/forms.py b/submissions/forms.py
index ef23812c9..4f860387c 100644
--- a/submissions/forms.py
+++ b/submissions/forms.py
@@ -554,6 +554,7 @@ class SubmissionForm(forms.ModelForm):
     preprint_file = forms.FileField(
         help_text=('Please submit the processed .pdf (not the source files; '
         'these will only be required at the post-acceptance proofs stage)'))
+    arxiv_link = forms.URLField(label='arXiv link (including version nr)')
 
     class Meta:
         model = Submission
@@ -575,7 +576,6 @@ class SubmissionForm(forms.ModelForm):
             'remarks_for_editors',
             'referees_suggested',
             'referees_flagged',
-            'arxiv_link',
         ]
         widgets = {
             'is_resubmission_of': forms.HiddenInput(),
diff --git a/submissions/migrations/0086_auto_20200720_1333.py b/submissions/migrations/0086_auto_20200720_1333.py
new file mode 100644
index 000000000..63b946339
--- /dev/null
+++ b/submissions/migrations/0086_auto_20200720_1333.py
@@ -0,0 +1,25 @@
+# Generated by Django 2.2.11 on 2020-07-20 11:33
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('submissions', '0085_auto_20200720_0648'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='submission',
+            name='arxiv_identifier_w_vn_nr',
+        ),
+        migrations.RemoveField(
+            model_name='submission',
+            name='arxiv_identifier_wo_vn_nr',
+        ),
+        migrations.RemoveField(
+            model_name='submission',
+            name='arxiv_vn_nr',
+        ),
+    ]
diff --git a/submissions/migrations/0087_remove_submission_arxiv_link.py b/submissions/migrations/0087_remove_submission_arxiv_link.py
new file mode 100644
index 000000000..6b44cf977
--- /dev/null
+++ b/submissions/migrations/0087_remove_submission_arxiv_link.py
@@ -0,0 +1,17 @@
+# Generated by Django 2.2.11 on 2020-07-20 11:54
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('submissions', '0086_auto_20200720_1333'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='submission',
+            name='arxiv_link',
+        ),
+    ]
diff --git a/submissions/models/submission.py b/submissions/models/submission.py
index 9686aaddc..e8f1a45ef 100644
--- a/submissions/models/submission.py
+++ b/submissions/models/submission.py
@@ -112,12 +112,6 @@ class Submission(models.Model):
         'submissions.iThenticateReport', on_delete=models.SET_NULL,
         null=True, blank=True, related_name='to_submission')
 
-    # Arxiv identifiers with/without version number
-    arxiv_identifier_w_vn_nr = models.CharField(max_length=15, default='0000.00000v0')
-    arxiv_identifier_wo_vn_nr = models.CharField(max_length=10, default='0000.00000')
-    arxiv_vn_nr = models.PositiveSmallIntegerField(default=1)
-    arxiv_link = models.URLField(verbose_name='arXiv link (including version nr)')
-
     pdf_refereeing_pack = models.FileField(upload_to='UPLOADS/REFEREE/%Y/%m/',
                                            max_length=200, blank=True)
 
-- 
GitLab