From 92aa646606adcee663487ca5c324d21b334e08ed Mon Sep 17 00:00:00 2001
From: George Katsikas <giorgakis.katsikas@gmail.com>
Date: Wed, 24 Jul 2024 18:30:42 +0300
Subject: [PATCH] allow note authors to delete regardless of privacy
---
scipost_django/pins/views.py | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/scipost_django/pins/views.py b/scipost_django/pins/views.py
index a274544ed..2a99a4eb7 100644
--- a/scipost_django/pins/views.py
+++ b/scipost_django/pins/views.py
@@ -41,17 +41,12 @@ def _hx_note_delete(request, pk):
if note is None:
return HTMXResponse("Note not found", tag="danger")
- if note.visibility == Note.VISIBILITY_PRIVATE:
- if note.author == request.user.contributor:
- note.delete()
- return HttpResponse()
- else:
- response = HTMXResponse(
- "You are not the author of this note.", tag="danger"
- )
+ if note.author == request.user.contributor:
+ note.delete()
+ return HttpResponse()
else:
response = HTMXResponse(
- "Deletion of non-private notes is disabled.", tag="danger"
+ "You are not the author of this note.", tag="danger"
)
response["HX-Trigger"] = "notes-updated"
--
GitLab