From a42814590d357ac069ed9bf12929f35cdfc66a13 Mon Sep 17 00:00:00 2001
From: George Katsikas <giorgakis.katsikas@gmail.com>
Date: Wed, 17 Jul 2024 16:11:32 +0300
Subject: [PATCH] use profile in referee indications form
---
scipost_django/submissions/forms/__init__.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/scipost_django/submissions/forms/__init__.py b/scipost_django/submissions/forms/__init__.py
index 9f59a2977..7147b131b 100644
--- a/scipost_django/submissions/forms/__init__.py
+++ b/scipost_django/submissions/forms/__init__.py
@@ -3758,7 +3758,7 @@ class RefereeIndicationForm(forms.ModelForm):
def __init__(self, *args, **kwargs):
self.submission = kwargs.pop("submission")
- self.user = kwargs.pop("user")
+ self.profile = kwargs.pop("profile")
super().__init__(*args, **kwargs)
self.helper = FormHelper()
@@ -3778,6 +3778,7 @@ class RefereeIndicationForm(forms.ModelForm):
css_class="col",
),
Div(Field("reason"), css_class="col-12 col-xl-3 h-100"),
+ Div(Field("id", type="hidden"), css_class="d-none"),
css_class="row",
)
)
@@ -3798,7 +3799,8 @@ class RefereeIndicationForm(forms.ModelForm):
)
if cleaned_data.get("indication") == RefereeIndication.INDICATION_AGAINST:
- if reason := cleaned_data.get("reason"):
+ reason = cleaned_data.get("reason")
+ if reason is None or reason == "":
self.add_error(
"reason",
"You must provide a reason when indicating against a referee.",
@@ -3811,9 +3813,9 @@ class RefereeIndicationForm(forms.ModelForm):
return cleaned_data
- def save(self):
+ def save(self, commit=True):
indication = super().save(commit=False)
indication.submission = self.submission
- indication.indicated_by = self.user.profile
+ indication.indicated_by = self.profile
indication.save()
return indication
--
GitLab