From bdc9cc8089cd756854d54cfcd53508d230530382 Mon Sep 17 00:00:00 2001
From: George Katsikas <giorgakis.katsikas@gmail.com>
Date: Thu, 16 Nov 2023 13:10:29 +0100
Subject: [PATCH] fix calculation of voter senior colleges
---
scipost_django/colleges/models/nomination.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/scipost_django/colleges/models/nomination.py b/scipost_django/colleges/models/nomination.py
index 3a6cf2c23..eb4afc61c 100644
--- a/scipost_django/colleges/models/nomination.py
+++ b/scipost_django/colleges/models/nomination.py
@@ -277,9 +277,12 @@ class FellowshipNominationVotingRound(models.Model):
if is_edadmin(user):
return True
- fellowships = user.contributor.fellowships.active().senior()
- senior_in_college = self.nomination.college in fellowships.values("college")
-
+ user_senior_colleges = (
+ user.contributor.fellowships.active()
+ .senior()
+ .values_list("college__id", flat=True)
+ )
+ senior_in_college = self.nomination.college.id in user_senior_colleges
eligibility_per_fellowship = [
fellowship in self.eligible_to_vote.all()
for fellowship in user.contributor.fellowships.all()
--
GitLab