From d4089b45e0f409471831d48ff5b9f1477c72febd Mon Sep 17 00:00:00 2001
From: Jorran de Wit <jorrandewit@outlook.com>
Date: Fri, 26 May 2017 22:56:30 +0200
Subject: [PATCH] Fix duplicate EICRecommendation saved on resubmission
---
submissions/forms.py | 2 +-
submissions/views.py | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/submissions/forms.py b/submissions/forms.py
index 3ddbc8f48..4b6fdcc84 100644
--- a/submissions/forms.py
+++ b/submissions/forms.py
@@ -93,7 +93,7 @@ class SubmissionChecks:
identifiers = self.identifier_into_parts(identifier)
submission = (Submission.objects
.filter(arxiv_identifier_wo_vn_nr=identifiers['arxiv_identifier_wo_vn_nr'])
- .order_by('-arxiv_vn_nr').last())
+ .order_by('arxiv_vn_nr').last())
# If submissions are found; check their statuses
if submission:
diff --git a/submissions/views.py b/submissions/views.py
index 56fc14ca6..a3764b96f 100644
--- a/submissions/views.py
+++ b/submissions/views.py
@@ -6,7 +6,7 @@ from django.contrib.auth.decorators import login_required, permission_required
from django.contrib.auth.models import Group
from django.core.urlresolvers import reverse, reverse_lazy
from django.db import transaction
-from django.http import Http404
+from django.http import Http404, HttpResponseRedirect
from django.shortcuts import get_object_or_404, render, redirect
from django.template import Template, Context
from django.utils import timezone
@@ -75,10 +75,9 @@ class RequestSubmission(CreateView):
# Send emails
SubmissionUtils.load({'submission': submission})
SubmissionUtils.send_authors_submission_ack_email()
- return super().form_valid(form)
+ return HttpResponseRedirect(self.success_url)
def form_invalid(self, form):
- # r = form.errors
for error_messages in form.errors.values():
messages.warning(self.request, *error_messages)
return super().form_invalid(form)
--
GitLab