From fae9a445f7cfbeef804e814b87d39e5726dea3a1 Mon Sep 17 00:00:00 2001
From: "J.-S. Caux" <J.S.Caux@uva.nl>
Date: Mon, 12 Dec 2016 18:02:47 +0100
Subject: [PATCH] Correct bug again
---
submissions/views.py | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/submissions/views.py b/submissions/views.py
index f6e6da368..9e9b12d69 100644
--- a/submissions/views.py
+++ b/submissions/views.py
@@ -351,12 +351,15 @@ def submission_detail_wo_vn_nr(request, arxiv_identifier_wo_vn_nr):
def submission_detail(request, arxiv_identifier_w_vn_nr):
submission = get_object_or_404(Submission, arxiv_identifier_w_vn_nr=arxiv_identifier_w_vn_nr)
- if (submission.status in SUBMISSION_STATUS_PUBLICLY_UNLISTED
- and not request.user.groups.filter(name='SciPost Administrators').exists()
- and not request.user.groups.filter(name='Editorial Administrators').exists()
- and not request.user.groups.filter(name='Editorial College').exists()
- and request.user.contributor not in submission.authors.all()
- ):
+ try:
+ if (submission.status in SUBMISSION_STATUS_PUBLICLY_UNLISTED
+ and not request.user.groups.filter(name='SciPost Administrators').exists()
+ and not request.user.groups.filter(name='Editorial Administrators').exists()
+ and not request.user.groups.filter(name='Editorial College').exists()
+ and request.user.contributor not in submission.authors.all()
+ ):
+ raise PermissionDenied
+ except AttributeError:
raise PermissionDenied
other_versions = Submission.objects.filter(
arxiv_identifier_wo_vn_nr=submission.arxiv_identifier_wo_vn_nr
--
GitLab