Correct bug: voting deactivated if College decision already taken

submissions/models.py

@@ -73,6 +73,13 @@ SUBMISSION_STATUS_PUBLICLY_INVISIBLE = [
     'withdrawn',
 ]
 
+# Submissions for which voting on a related recommendation is deprecated:
+SUBMISSION_STATUS_VOTING_DEPRECATED = [
+    'rejected',
+    'published',
+    'withdrawn',
+]
+
 
 # SUBMISSION_ACTION_REQUIRED = (
 #     ('assign_EIC', 'Editor-in-charge to be assigned'),

submissions/views.py

@@ -475,7 +475,8 @@ def pool(request):
         recommendation=-1).exclude(recommendation=-2).exclude(
             voted_for__in=[contributor]).exclude(
             voted_against__in=[contributor]).exclude(
-            voted_abstain__in=[contributor])
+            voted_abstain__in=[contributor]).exclude(
+            submission__status__in=SUBMISSION_STATUS_VOTING_DEPRECATED)
     rec_vote_form = RecommendationVoteForm()
     context = {'submissions_in_pool': submissions_in_pool,
                'recommendations_undergoing_voting': recommendations_undergoing_voting,