SciPost Code Repository

Skip to content
Snippets Groups Projects
Commit 4ceaf2db authored by Jorran de Wit's avatar Jorran de Wit
Browse files

Fix: remove double remarks

parent 824cff9b
No related branches found
No related tags found
No related merge requests found
<li> <li id="{{remark.id}}">
<div class="font-weight-bold"> <div class="font-weight-bold">
{{remark.contributor.user.first_name}} {{remark.contributor.user.last_name}} <small class="text-muted">on {{remark.date}}</small> {{remark.contributor.user.first_name}} {{remark.contributor.user.last_name}} <small class="text-muted">on {{remark.date}}</small>
</div> </div>
......
...@@ -11,9 +11,6 @@ ...@@ -11,9 +11,6 @@
<h3 class="pb-0">Requested changes</h3> <h3 class="pb-0">Requested changes</h3>
<p class="pl-md-3">{{recommendation.requested_changes}}</p> <p class="pl-md-3">{{recommendation.requested_changes}}</p>
<h3 class="pb-0">Remarks for Editorial College</h3>
<p class="pl-md-3">{{recommendation.remarks_for_editorial_college}}</p>
{% block recommendation_before_recommendation %}{% endblock %} {% block recommendation_before_recommendation %}{% endblock %}
<h3 class="pb-0">Recommendation</h3> <h3 class="pb-0">Recommendation</h3>
......
...@@ -397,21 +397,18 @@ def add_remark(request, arxiv_identifier_w_vn_nr): ...@@ -397,21 +397,18 @@ def add_remark(request, arxiv_identifier_w_vn_nr):
""" """
submission = get_object_or_404(Submission.objects.get_pool(request.user), submission = get_object_or_404(Submission.objects.get_pool(request.user),
arxiv_identifier_w_vn_nr=arxiv_identifier_w_vn_nr) arxiv_identifier_w_vn_nr=arxiv_identifier_w_vn_nr)
if request.method == 'POST':
remark_form = RemarkForm(request.POST) remark_form = RemarkForm(request.POST or None)
if remark_form.is_valid(): if remark_form.is_valid():
remark = Remark(contributor=request.user.contributor, remark = Remark(contributor=request.user.contributor,
submission=submission, submission=submission,
date=timezone.now(), date=timezone.now(),
remark=remark_form.cleaned_data['remark']) remark=remark_form.cleaned_data['remark'])
remark.save() remark.save()
return redirect(reverse('submissions:pool')) messages.success(request, 'Your remark has succesfully been posted')
else:
errormessage = 'The form was invalidly filled.'
return render(request, 'scipost/error.html', {'errormessage': errormessage})
else: else:
errormessage = 'This view can only be posted to.' messages.warning(request, 'The form was invalidly filled.')
return render(request, 'scipost/error.html', {'errormessage': errormessage}) return redirect(reverse('submissions:pool'))
@login_required @login_required
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment