Fix contributor mail-receive setting check

invitations/models.py

@@ -178,7 +178,7 @@ class CitationNotification(models.Model):
         if self.invitation:
             return self.invitation.last_name
         elif self.contributor:
-            return self.contributor.last_name
+            return self.contributor.user.last_name
 
     @property
     def get_title(self):

invitations/views.py

@@ -71,8 +71,9 @@ class CitationNotificationsProcessView(PermissionsMixin, RequestArgumentMixin,
         Form is valid; use the MailEditorMixin to send out the mail if
         (possible) Contributor didn't opt-out from mails.
         """
+        citation = form.get_all_notifications().filter(contributor__isnull=False).first()
+        contributor = citation.contributor
         form.get_all_notifications().update(processed=True)
-        contributor = form.get_all_notifications().filter(contributor__isnull=False).first()
         self.send_mail = (contributor and contributor.accepts_SciPost_emails) or not contributor
         return super().form_valid(form)
 

mails/templates/mail_templates/citation_notification.html

@@ -54,7 +54,7 @@ Dear {{ notification.get_title }} {{ notification.last_name }},
     The SciPost Team
 </p>
 
-{% if notification.get_first_related_contributor %}
+{% if notification.get_first_related_contributor and notification.get_first_related_contributor.activation_key %}
     <p style="font-size: 10px;">
         Don\'t want to receive such emails? <a href="https://scipost.org/{% url 'scipost:unsubscribe' notification.get_first_related_contributor.id notification.get_first_related_contributor.activation_key %}">Unsubscribe</a>
     </p>