Fix UserFactory bug

Passwords generated by factoryboy were directly
 put into the table as a string, unhashed! However,
 if the testclient tried to login, it used all
 auth methods a normal user uses as well. This caused
 the test user to never be able to login with the
 generated password.

commentaries/test_views.py

@@ -52,22 +52,17 @@ class VetCommentaryRequestsTest(TestCase):
         """Test http response on GET requests"""
         # Registered Contributor should get 200
         self.client.login(username=self.contributor.user.username,
-                          password=self.contributor.user.password)
+                          password='adm1n')
 
         # Wrong permissions group!
-        reponse = self.client.get(self.view_url)
-        self.assertEquals(reponse.status_code, 403)
+        response = self.client.get(self.view_url)
+        self.assertEquals(response.status_code, 403)
 
         # Right permissions group!
-        # self.client.logout()
         group = Group.objects.get(name="Vetting Editors")
         self.contributor.user.groups.add(group)
-        # Permission group is still empty!?!? These fixtures just don't seem to work properly.
-
-        # self.client.login(username=self.contributor.user.username,
-        #                   password=self.contributor.user.password)
-        reponse = self.client.get(self.view_url)
-        self.assertEquals(reponse.status_code, 200)
+        response = self.client.get(self.view_url)
+        self.assertEquals(response.status_code, 200)
 
     # def test_get_valid_unvetted_commentaries(self):
     #     """Test if valid commentaries are sent back to user."""

scipost/factories.py

@@ -21,10 +21,11 @@ class UserFactory(factory.django.DjangoModelFactory):
         model = get_user_model()
 
     username = factory.Faker('user_name')
-    password = factory.Faker('password')
+    password = factory.PostGenerationMethodCall('set_password', 'adm1n')
     email = factory.Faker('safe_email')
     first_name = factory.Faker('first_name')
     last_name = factory.Faker('last_name')
+    is_active = True
     # When user object is created, associate new Contributor object to it.
     contributor = factory.RelatedFactory(ContributorFactory, 'user')