Fix vetting Commentaries bug
Due to the new Commentary request forms, which were also used during vetting (choice=modify), the vetting went wrong sometimes. If the vetting action was 'modify', the user was redirected to the old form which didn't exist anymore. As a result of how the contruction of this modify structure, the Commentary was first deleted and thus the data was lost. The requester did receive a mail that his/her Commentary was accessible on SciPost however. I fixed this by recontructing the vetting views. I combined the vetting list and the vet request. I removed the action removing the Commentary and made this a redirect to a new view which is a modify page accessible only for EdCol Admins to modify+accept the Commentary. Also, the mail for 'modify' vetting is also just sent at *after* modification now.
Showing
- commentaries/forms.py 12 additions, 6 deletionscommentaries/forms.py
- commentaries/templates/commentaries/modify_commentary_request.html 44 additions, 0 deletions...ies/templates/commentaries/modify_commentary_request.html
- commentaries/templates/commentaries/request_published_article.html 1 addition, 1 deletion...ies/templates/commentaries/request_published_article.html
- commentaries/templates/commentaries/vet_commentary_requests.html 2 additions, 1 deletion...aries/templates/commentaries/vet_commentary_requests.html
- commentaries/test_forms.py 4 additions, 3 deletionscommentaries/test_forms.py
- commentaries/urls.py 6 additions, 3 deletionscommentaries/urls.py
- commentaries/views.py 54 additions, 35 deletionscommentaries/views.py
Loading
Please register or sign in to comment