SciPost Code Repository

Skip to content
Snippets Groups Projects
  1. Mar 25, 2018
  2. Sep 25, 2017
  3. Aug 18, 2017
  4. Jul 29, 2017
  5. Jul 28, 2017
  6. Apr 12, 2017
  7. Mar 27, 2017
  8. Mar 26, 2017
  9. Mar 25, 2017
    • Jorran de Wit's avatar
      Major template overhaul... · ab25a419
      Jorran de Wit authored
      This commit contains the removal of html from 'the important' models
       or at least contains replacements for model methods such as `print_as...()`,
       etc. etc. Except for `header_as_li`, methods are not completely deleted yet.
      
      > Fixed/Improved the nested comments and comments in reports. They were
       not shown before.
      
      > Improved DRY principle in several templates/codes.
      
      > Created Managers in the `submissions` app to filter i.e. "pool" submissions
       (so exclude potential author from judging on his own publication) for the
       pool view in the query; not in the template!
      
      > More...
      ab25a419
  10. Feb 15, 2017
  11. Feb 14, 2017
  12. Feb 12, 2017
  13. Feb 01, 2017
  14. Jan 15, 2017
    • Geert Kapteijns's avatar
      Extract ThesisLink#header_as_table to partial template · 419a19c6
      Geert Kapteijns authored
      Markup logic should be in templates, not in model layer.
      
      Partial template is named _header_as_table to signal
      that it is ment to be included into other templates
      (analogous to the private method naming convention.)
      The full text of several of the thesis link's fields
      (domain, subject_area, etc.) are fetched from constant dicts
      in custom filters defined in theses.templatetags.theses_extras.
      419a19c6
  15. Dec 19, 2016
  16. Dec 14, 2016
    • Geert Kapteijns's avatar
      Set blank=False on domain field of ThesisLink · de1087c0
      Geert Kapteijns authored
      A blank domain throws an error in /theses/.
      I've also installed factory_boy (pip install -r requirements.txt
      to get it) and set up a ThesisLinkFactory and a unit tests that
      tests whether ThesisLink validates for a blank domain field.
      
      Not sure if this is exactly how you're supposed to validate
      a model, but it's a start. First unit test of the project, whoohoo!
      de1087c0
    • Geert Kapteijns's avatar
      Define THESIS_TYPES in ThesisLink model itself · 9b7fbbd5
      Geert Kapteijns authored
      This is recommended. Also give names like
      MASTER_THESIS = 'MA' to avoid magic strings and allow for easy
      reference, e.g. thesis.type = ThesisLink.MASTER_THESIS. This sort
      of thing helps in maintainability of the codebase, since if we want
      to change the abbreviation to 'MASTER' for some reason, we have it
      defined in one place, and not in 100 places in the code.
      9b7fbbd5
    • Geert Kapteijns's avatar
      Make PEP8 improvements · 9f505220
      Geert Kapteijns authored
      9f505220
  17. Dec 12, 2016
  18. Nov 26, 2016
  19. Nov 25, 2016
  20. Aug 11, 2016
  21. May 29, 2016
  22. Apr 22, 2016
  23. Apr 17, 2016
  24. Apr 15, 2016
  25. Apr 12, 2016
  26. Apr 01, 2016
  27. Mar 28, 2016
  28. Mar 26, 2016
  29. Mar 20, 2016
  30. Mar 19, 2016
  31. Feb 27, 2016
  32. Feb 07, 2016
  33. Feb 04, 2016
Loading