- Feb 12, 2017
-
-
Jorran de Wit authored
-
- Feb 01, 2017
-
-
Jorran de Wit authored
-
- Jan 15, 2017
-
-
Geert Kapteijns authored
Markup logic should be in templates, not in model layer. Partial template is named _header_as_table to signal that it is ment to be included into other templates (analogous to the private method naming convention.) The full text of several of the thesis link's fields (domain, subject_area, etc.) are fetched from constant dicts in custom filters defined in theses.templatetags.theses_extras.
-
- Dec 19, 2016
-
-
Jorran de Wit authored
Move few constants to a seperate file away from models. This implies minor edits in other apps relying on these few constants.
-
- Dec 14, 2016
-
-
Geert Kapteijns authored
A blank domain throws an error in /theses/. I've also installed factory_boy (pip install -r requirements.txt to get it) and set up a ThesisLinkFactory and a unit tests that tests whether ThesisLink validates for a blank domain field. Not sure if this is exactly how you're supposed to validate a model, but it's a start. First unit test of the project, whoohoo!
-
Geert Kapteijns authored
This is recommended. Also give names like MASTER_THESIS = 'MA' to avoid magic strings and allow for easy reference, e.g. thesis.type = ThesisLink.MASTER_THESIS. This sort of thing helps in maintainability of the codebase, since if we want to change the abbreviation to 'MASTER' for some reason, we have it defined in one place, and not in 100 places in the code.
-
Geert Kapteijns authored
-
- Dec 12, 2016
-
-
Geert Kapteijns authored
I've opted for hanging indentation foo = long_function_name( var_one, var_two, var_three, var_four) instead of aligning with opening delimiter foo = long_function_name(var_one, var_two, var_three, var_four) because the former makes more sense to me. See https://www.python.org/dev/peps/pep-0008/#indentation
-
- Nov 26, 2016
-
-
Jean-Sébastien Caux authored
-
- Nov 25, 2016
-
-
Jean-Sébastien Caux authored
-
- Aug 11, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
- May 29, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 22, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 17, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 15, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 12, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 01, 2016
-
-
Jean-Sébastien Caux authored
-
- Mar 28, 2016
-
-
Jean-Sébastien Caux authored
-
- Mar 26, 2016
-
-
Jean-Sébastien Caux authored
-
- Mar 20, 2016
-
-
Jean-Sébastien Caux authored
-
- Mar 19, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
- Feb 27, 2016
-
-
Jean-Sébastien Caux authored
-
- Feb 07, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
- Feb 04, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-