SciPost Code Repository

Skip to content
Snippets Groups Projects
Commit 3c7de1f0 authored by George Katsikas's avatar George Katsikas :goat:
Browse files

fix: :ambulance:️ set orcid to none if field empty

Fix default value for orcid field and exclude self from duplicate check
parent 763dbd1b
No related branches found
No related tags found
No related merge requests found
0
\ No newline at end of file
......@@ -477,15 +477,18 @@ class UpdatePersonalDataForm(forms.ModelForm):
self.instance.profile.acad_field = self.cleaned_data["acad_field"]
if self.cleaned_data["orcid_id"] != self.instance.profile.orcid_id:
self.instance.profile.orcid_authenticated = False
self.instance.profile.orcid_id = self.cleaned_data["orcid_id"]
self.instance.profile.orcid_id = self.cleaned_data["orcid_id"] or None
self.instance.profile.webpage = self.cleaned_data["webpage"]
self.instance.profile.save()
self.instance.profile.specialties.set(self.cleaned_data["specialties"])
return super().save()
def clean_orcid_id(self):
orcid_id = self.cleaned_data.get("orcid_id", "")
if orcid_id and Profile.objects.filter(orcid_id=orcid_id).exists():
if (
orcid_id := self.cleaned_data.get("orcid_id", "")
) and Profile.objects.filter(orcid_id=orcid_id).exclude(
id=self.instance.profile.id
).exists():
error_message = format_html(
"This ORCID id is already in use by another member. Is it yours? "
"<a href='mailto:techsupport@scipost.org'>Contact tech support</a>."
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment