move more html from Contributor to partial templates

scipost/models.py

@@ -112,14 +112,6 @@ class Contributor(models.Model):
         # Redundant, to be removed in future
         return self.get_discipline_display()
 
-    def expertises_as_ul(self):
-        output = '<ul>'
-        if self.expertises:
-            for exp in self.expertises:
-                output += '<li>%s</li>' % subject_areas_dict[exp]
-        output += '</ul>'
-        return mark_safe(output)
-
     def expertises_as_string(self):
         if self.expertises:
             return ', '.join([subject_areas_dict[exp].lower() for exp in self.expertises])

scipost/templates/scipost/_expertises_as_ul.html

+{% load scipost_extras %}
+
+<ul>
+    {% for expertise in contributor.expertises %}
+        <li>
+            {{ expertise|get_specialization_display }}
+        </li>
+    {% endfor %}
+</ul>

scipost/templates/scipost/personal_page.html

@@ -88,7 +88,7 @@
 
                     <h3 class="mt-3">Your expertises:</h3>
                     {% if contributor.expertises %}
-                        {{ contributor.expertises_as_ul }}
+                        {% include "scipost/_expertises_as_ul.html" with contributor=contributor %}
                     {% else %}
                         <p>You haven't listed your expertise(s).<br/>
                         Do so by <a href="{% url 'scipost:update_personal_data' %}">updating your personal data</a>