SciPost Code Repository

Skip to content
Snippets Groups Projects
  1. Feb 11, 2022
  2. May 22, 2021
  3. Sep 27, 2020
  4. Nov 05, 2019
  5. Sep 21, 2019
  6. Jan 08, 2019
  7. Mar 25, 2018
  8. Mar 14, 2018
  9. May 14, 2017
  10. May 08, 2017
  11. Apr 23, 2017
  12. Feb 25, 2017
  13. Jan 30, 2017
  14. Jan 29, 2017
  15. Dec 20, 2016
    • Geert Kapteijns's avatar
      Replace vet_thesislink_requests by FormView · 0100cbde
      Geert Kapteijns authored
      This does not work yet. I wrote some failing tests, but while
      I was doing that, I came to the conclusion that I want to make
      the route of the get request different from the route of the post
      request.
      0100cbde
  16. Dec 19, 2016
  17. Dec 15, 2016
  18. Dec 14, 2016
    • Geert Kapteijns's avatar
      Set blank=False on domain field of ThesisLink · de1087c0
      Geert Kapteijns authored
      A blank domain throws an error in /theses/.
      I've also installed factory_boy (pip install -r requirements.txt
      to get it) and set up a ThesisLinkFactory and a unit tests that
      tests whether ThesisLink validates for a blank domain field.
      
      Not sure if this is exactly how you're supposed to validate
      a model, but it's a start. First unit test of the project, whoohoo!
      de1087c0
    • Geert Kapteijns's avatar
      Define THESIS_TYPES in ThesisLink model itself · 9b7fbbd5
      Geert Kapteijns authored
      This is recommended. Also give names like
      MASTER_THESIS = 'MA' to avoid magic strings and allow for easy
      reference, e.g. thesis.type = ThesisLink.MASTER_THESIS. This sort
      of thing helps in maintainability of the codebase, since if we want
      to change the abbreviation to 'MASTER' for some reason, we have it
      defined in one place, and not in 100 places in the code.
      9b7fbbd5
Loading