- Dec 20, 2016
-
-
Geert Kapteijns authored
This does not work yet. I wrote some failing tests, but while I was doing that, I came to the conclusion that I want to make the route of the get request different from the route of the post request.
-
Geert Kapteijns authored
-
- Dec 19, 2016
-
-
Geert Kapteijns authored
-
Jorran de Wit authored
Move few constants to a seperate file away from models. This implies minor edits in other apps relying on these few constants.
-
Geert Kapteijns authored
-
Jorran de Wit authored
-
Geert Kapteijns authored
The acknowledgement message is no longer hardcoded in theses/views.py, but resides in the top-level strings module.
-
- Dec 16, 2016
-
-
Geert Kapteijns authored
-
Geert Kapteijns authored
This function helps to create form data from models. See example given.
-
Geert Kapteijns authored
-
Geert Kapteijns authored
-
Geert Kapteijns authored
Removes some 40 lines of boilerplate, since CreateView handles the creation of a new ThesisLink.
-
- Dec 15, 2016
-
-
Geert Kapteijns authored
A CreateView class based view should replace the current request_thesislink function based view, since it saves many lines of code and is less error prone and more easily readable.
-
Geert Kapteijns authored
-
Jean-Sébastien Caux authored
-
Geert Kapteijns authored
-
Geert Kapteijns authored
You can now just call ContributorFactory() to get a freshly instantiated Contributor to be used for testing purposes.
-
- Dec 14, 2016
-
-
Geert Kapteijns authored
A blank domain throws an error in /theses/. I've also installed factory_boy (pip install -r requirements.txt to get it) and set up a ThesisLinkFactory and a unit tests that tests whether ThesisLink validates for a blank domain field. Not sure if this is exactly how you're supposed to validate a model, but it's a start. First unit test of the project, whoohoo!
-
Geert Kapteijns authored
This is recommended. Also give names like MASTER_THESIS = 'MA' to avoid magic strings and allow for easy reference, e.g. thesis.type = ThesisLink.MASTER_THESIS. This sort of thing helps in maintainability of the codebase, since if we want to change the abbreviation to 'MASTER' for some reason, we have it defined in one place, and not in 100 places in the code.
-
Geert Kapteijns authored
test_forms.py, test_models.py, test_views.py, as per recommendation of the two scoops book.
-
Geert Kapteijns authored
-
- Dec 13, 2016
-
-
Geert Kapteijns authored
-
- Dec 12, 2016
-
-
Geert Kapteijns authored
I've opted for hanging indentation foo = long_function_name( var_one, var_two, var_three, var_four) instead of aligning with opening delimiter foo = long_function_name(var_one, var_two, var_three, var_four) because the former makes more sense to me. See https://www.python.org/dev/peps/pep-0008/#indentation
-
- Dec 05, 2016
-
-
Jean-Sébastien Caux authored
-
- Nov 26, 2016
-
-
Jean-Sébastien Caux authored
-
- Nov 25, 2016
-
-
Jean-Sébastien Caux authored
-
- Nov 09, 2016
-
-
Jean-Sébastien Caux authored
-
- Aug 15, 2016
-
-
Jean-Sébastien Caux authored
-
- Aug 11, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
- May 30, 2016
-
-
Jean-Sébastien Caux authored
-
- May 29, 2016
-
-
Jean-Sébastien Caux authored
-
- May 21, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 22, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 20, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
- Apr 19, 2016
-
-
Jean-Sébastien Caux authored
-
- Apr 18, 2016
-
-
Jean-Sébastien Caux authored
-
Jean-Sébastien Caux authored
-
- Apr 17, 2016
-
-
Jean-Sébastien Caux authored
-